renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-22 12:14:01 +08:00
Code

netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock()

Browse Source 
Sparse reports warnings at nf_conntrack_all_lock()
	and nf_conntrack_all_unlock()

warning: context imbalance in nf_conntrack_all_lock()
	- wrong count at exit
warning: context imbalance in nf_conntrack_all_unlock()
	- unexpected unlock

Add the missing __acquires(&nf_conntrack_locks_all_lock)
Add missing __releases(&nf_conntrack_locks_all_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Jules Irenge 2020-03-11 01:09:05 +00:00 committed by Pablo Neira Ayuso
parent 19f8f717f6
commit 6b36d4829c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/netfilter/nf_conntrack_core.c
View File

@ -143,6 +143,7 @@ static bool nf_conntrack_double_lock(struct net *net, unsigned int h1,
} }
static void nf_conntrack_all_lock(void) static void nf_conntrack_all_lock(void)
__acquires(&nf_conntrack_locks_all_lock)
{ {
int i; int i;
@ -162,6 +163,7 @@ static void nf_conntrack_all_lock(void)
} }
static void nf_conntrack_all_unlock(void) static void nf_conntrack_all_unlock(void)
__releases(&nf_conntrack_locks_all_lock)
{ {
/* All prior stores must be complete before we clear /* All prior stores must be complete before we clear
* 'nf_conntrack_locks_all'. Otherwise nf_conntrack_lock() * 'nf_conntrack_locks_all'. Otherwise nf_conntrack_lock()