mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 12:43:55 +08:00
thermal: Add some error messages
When registering a thermal zone device, we currently return -EINVAL in four cases. This makes it a little hard to debug the real cause of the failure. Print some error messages to make it easier for developer to figure out what happened. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This commit is contained in:
parent
1851799e1d
commit
67eed44b8a
@ -1245,17 +1245,26 @@ thermal_zone_device_register(const char *type, int trips, int mask,
|
||||
int count;
|
||||
struct thermal_governor *governor;
|
||||
|
||||
if (!type || strlen(type) == 0)
|
||||
if (!type || strlen(type) == 0) {
|
||||
pr_err("Error: No thermal zone type defined\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
if (type && strlen(type) >= THERMAL_NAME_LENGTH)
|
||||
if (type && strlen(type) >= THERMAL_NAME_LENGTH) {
|
||||
pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n",
|
||||
type, THERMAL_NAME_LENGTH);
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips)
|
||||
if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) {
|
||||
pr_err("Error: Incorrect number of thermal trips\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
if (!ops)
|
||||
if (!ops) {
|
||||
pr_err("Error: Thermal zone device ops not defined\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
||||
if (trips > 0 && (!ops->get_trip_type || !ops->get_trip_temp))
|
||||
return ERR_PTR(-EINVAL);
|
||||
|
Loading…
Reference in New Issue
Block a user