renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-23 22:25:40 +08:00
Code

platform/x86: ideapad-laptop: use dev_{err,warn} or appropriate variant to display log messages

Browse Source 
Having the device name in the log message makes it easier to determine
in the context of which device the message was printed, so utilize the
appropriate variants of dev_{err,warn,...} when printing log messages.

Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Link: https://lore.kernel.org/r/20210203215403.290792-12-pobrn@protonmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Barnabás Pőcze 2021-02-03 21:55:32 +00:00 committed by Hans de Goede
parent 40e0447d6f
commit 654324c45d
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/platform/x86/ideapad-laptop.c
View File

@ -235,7 +235,7 @@ static int read_ec_data(acpi_handle handle, int cmd, unsigned long *data)
return 0; return 0;
} }
} }
pr_err("timeout in %s\n", __func__); acpi_handle_err(handle, "timeout in %s\n", __func__);
return -1; return -1;
} }
@ -258,7 +258,7 @@ static int write_ec_cmd(acpi_handle handle, int cmd, unsigned long data)
if (val == 0) if (val == 0)
return 0; return 0;
} }
pr_err("timeout in %s\n", __func__); acpi_handle_err(handle, "timeout in %s\n", __func__);
return -1; return -1;
} }
@ -974,13 +974,15 @@ static int ideapad_input_init(struct ideapad_private *priv)
error = sparse_keymap_setup(inputdev, ideapad_keymap, NULL); error = sparse_keymap_setup(inputdev, ideapad_keymap, NULL);
if (error) { if (error) {
pr_err("Unable to setup input device keymap\n"); dev_err(&priv->platform_device->dev,
"Unable to setup input device keymap\n");
goto err_free_dev; goto err_free_dev;
} }
error = input_register_device(inputdev); error = input_register_device(inputdev);
if (error) { if (error) {
pr_err("Unable to register input device\n"); dev_err(&priv->platform_device->dev,
"Unable to register input device\n");
goto err_free_dev; goto err_free_dev;
} }
@ -1034,7 +1036,8 @@ static void ideapad_check_special_buttons(struct ideapad_private *priv)
ideapad_input_report(priv, 64); ideapad_input_report(priv, 64);
break; break;
default: default:
pr_info("Unknown special button: %lu\n", bit); dev_info(&priv->platform_device->dev,
"Unknown special button: %lu\n", bit);
break; break;
} }
} }
@ -1094,7 +1097,8 @@ static int ideapad_backlight_init(struct ideapad_private *priv)
&ideapad_backlight_ops, &ideapad_backlight_ops,
&props); &props);
if (IS_ERR(blightdev)) { if (IS_ERR(blightdev)) {
pr_err("Could not register backlight device\n"); dev_err(&priv->platform_device->dev,
"Could not register backlight device\n");
return PTR_ERR(blightdev); return PTR_ERR(blightdev);
} }
@ -1207,7 +1211,8 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
*/ */
break; break;
default: default:
pr_info("Unknown event: %lu\n", bit); dev_info(&priv->platform_device->dev,
"Unknown event: %lu\n", bit);
} }
} }
} }
@ -1215,12 +1220,15 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
#if IS_ENABLED(CONFIG_ACPI_WMI) #if IS_ENABLED(CONFIG_ACPI_WMI)
static void ideapad_wmi_notify(u32 value, void *context) static void ideapad_wmi_notify(u32 value, void *context)
{ {
struct ideapad_private *priv = context;
switch (value) { switch (value) {
case 128: case 128:
ideapad_input_report(context, value); ideapad_input_report(priv, value);
break; break;
default: default:
pr_info("Unknown WMI event %u\n", value); dev_info(&priv->platform_device->dev,
"Unknown WMI event: %u\n", value);
} }
} }
#endif #endif