renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-19 02:54:00 +08:00
Code

cpufreq: Drop unnecessary checks from show() and store()

Browse Source 
The show() and store() routines in the cpufreq core don't need to
check if the struct freq_attr they want to use really provides the
callbacks they need as expected (if that's not the case, it means
a bug in the code anyway), so change them to avoid doing that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Rafael J. Wysocki 2016-02-12 23:56:21 +01:00
parent dd02a3d920
commit 6541aef01a
1 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/cpufreq/cpufreq.c
View File

@ -818,12 +818,7 @@ static ssize_t show(struct kobject *kobj, struct attribute *attr, char *buf)
ssize_t ret; ssize_t ret;
down_read(&policy->rwsem); down_read(&policy->rwsem);
ret = fattr->show(policy, buf);
if (fattr->show)
ret = fattr->show(policy, buf);
else
ret = -EIO;
up_read(&policy->rwsem); up_read(&policy->rwsem);
return ret; return ret;
@ -838,18 +833,12 @@ static ssize_t store(struct kobject *kobj, struct attribute *attr,
get_online_cpus(); get_online_cpus();
if (!cpu_online(policy->cpu)) if (cpu_online(policy->cpu)) {
goto unlock; down_write(&policy->rwsem);
down_write(&policy->rwsem);
if (fattr->store)
ret = fattr->store(policy, buf, count); ret = fattr->store(policy, buf, count);
else up_write(&policy->rwsem);
ret = -EIO; }
up_write(&policy->rwsem);
unlock:
put_online_cpus(); put_online_cpus();
return ret; return ret;