mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-24 05:04:00 +08:00
OMAP: PM: SmartReflex: fix potential NULL dereference
kzalloc() may fail, if so return -ENOMEM. Also Walter Harms suggested to use kasprintf() instead of kzalloc+strcpy+strcat. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Kevin Hilman <khilman@ti.com>
This commit is contained in:
parent
8743410d49
commit
5c56f32e80
@ -260,9 +260,11 @@ static int sr_late_init(struct omap_sr *sr_info)
|
||||
if (sr_class->class_type == SR_CLASS2 &&
|
||||
sr_class->notify_flags && sr_info->irq) {
|
||||
|
||||
name = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL);
|
||||
strcpy(name, "sr_");
|
||||
strcat(name, sr_info->voltdm->name);
|
||||
name = kasprintf(GFP_KERNEL, "sr_%s", sr_info->voltdm->name);
|
||||
if (name == NULL) {
|
||||
ret = -ENOMEM;
|
||||
goto error;
|
||||
}
|
||||
ret = request_irq(sr_info->irq, sr_interrupt,
|
||||
0, name, (void *)sr_info);
|
||||
if (ret)
|
||||
|
Loading…
Reference in New Issue
Block a user