renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-20 19:23:57 +08:00
Code

pref_counter: tools: report: Robustify in case of weird events

Browse Source 
This error condition:

  aldebaran:~/linux/linux/Documentation/perf_counter> perf report
  dso__load_sym: cannot get elf header.
  failed to open: /etc/ld.so.cache
  problem processing PERF_EVENT_MMAP, bailing out

caused the profile to be very short - as the error was at the beginning
of the file and we bailed out completely.

Be more permissive and consider the event broken instead.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: John Kacur <jkacur@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar 2009-05-27 22:13:17 +02:00
parent 2d65537ee7
commit 55717314c4
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Documentation/perf_counter/builtin-report.c
View File

@ -1117,9 +1117,9 @@ more:
}
if (thread == NULL) {
fprintf(stderr, "problem processing %d event, bailing out\n",
fprintf(stderr, "problem processing %d event, skipping it.\n",
event->header.type);
goto done;
goto broken_event;
}
if (event->header.misc & PERF_EVENT_MISC_KERNEL) {
@ -1149,8 +1149,8 @@ more:
if (hist_entry__add(thread, map, dso, sym, ip, level)) {
fprintf(stderr,
"problem incrementing symbol count, bailing out\n");
goto done;
"problem incrementing symbol count, skipping event\n");
goto broken_event;
}
}
total++;
@ -1169,8 +1169,8 @@ more:
event->mmap.filename);
}
if (thread == NULL || map == NULL) {
fprintf(stderr, "problem processing PERF_EVENT_MMAP, bailing out\n");
goto done;
fprintf(stderr, "problem processing PERF_EVENT_MMAP, skipping event.\n");
goto broken_event;
}
thread__insert_map(thread, map);
total_mmap++;
@ -1187,8 +1187,8 @@ more:
}
if (thread == NULL ||
thread__set_comm(thread, event->comm.comm)) {
fprintf(stderr, "problem processing PERF_EVENT_COMM, bailing out\n");
goto done;
fprintf(stderr, "problem processing PERF_EVENT_COMM, skipping event.\n");
goto broken_event;
}
total_comm++;
break;
@ -1221,7 +1221,6 @@ broken_event:
goto more;
rc = EXIT_SUCCESS;
done:
close(input);
if (dump_trace) {