mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 12:43:55 +08:00
usb: musb: dsps: fix devm_ioremap_resource error detection code
devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. Furthermore, the value returned by devm_ioremap_resource should be tested. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
parent
272b05a988
commit
51ef74f640
@ -361,8 +361,8 @@ static int dsps_musb_init(struct musb *musb)
|
||||
return -EINVAL;
|
||||
|
||||
reg_base = devm_ioremap_resource(dev, r);
|
||||
if (!musb->ctrl_base)
|
||||
return -EINVAL;
|
||||
if (IS_ERR(reg_base))
|
||||
return PTR_ERR(reg_base);
|
||||
musb->ctrl_base = reg_base;
|
||||
|
||||
/* NOP driver needs change if supporting dual instance */
|
||||
|
Loading…
Reference in New Issue
Block a user