mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 21:54:06 +08:00
HID: magicmouse: fix crash when disconnecting Magic Trackpad 2
When the Apple Magic Trackpad 2 is connected over USB it registers four hid_device report descriptors, however, the driver only handles the one with type HID_TYPE_USBMOUSE and ignores the other three, thus, no driver data is attached to them. When the device is disconnected, the remove callback is called for the four hid_device report descriptors, crashing when the driver data is NULL. Check that the driver data is not NULL before using it in the remove callback. Signed-off-by: José Expósito <jose.exposito89@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
a4b494099a
commit
4fb1251925
@ -779,7 +779,10 @@ err_stop_hw:
|
||||
static void magicmouse_remove(struct hid_device *hdev)
|
||||
{
|
||||
struct magicmouse_sc *msc = hid_get_drvdata(hdev);
|
||||
cancel_delayed_work_sync(&msc->work);
|
||||
|
||||
if (msc)
|
||||
cancel_delayed_work_sync(&msc->work);
|
||||
|
||||
hid_hw_stop(hdev);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user