renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-27 06:34:11 +08:00
Code

efi/x86: drop task_lock() from efi_switch_mm()

Browse Source 
efi_switch_mm() is a wrapper around switch_mm() which saves current's
->active_mm, sets the requests mm as ->active_mm and invokes
switch_mm().
I don't think that task_lock() is required during that procedure. It
protects ->mm which isn't changed here.

It needs to be mentioned that during the whole procedure (switch to
EFI's mm and back) the preemption needs to be disabled. A context switch
at this point would reset the cr3 value based on current->mm. Also, this
function may not be invoked at the same time on a different CPU because
it would overwrite the efi_scratch.prev_mm information.

Remove task_lock() and also update the comment to reflect it.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
This commit is contained in:
Sebastian Andrzej Siewior 2018-07-24 21:28:55 +02:00 committed by Ard Biesheuvel
parent 3425d934fc
commit 4eda11175f
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
arch/x86/platform/efi/efi_64.c
View File

@ -619,18 +619,16 @@ void __init efi_dump_pagetable(void)
/* /*
* Makes the calling thread switch to/from efi_mm context. Can be used * Makes the calling thread switch to/from efi_mm context. Can be used
* for SetVirtualAddressMap() i.e. current->active_mm == init_mm as well * in a kernel thread and user context. Preemption needs to remain disabled
* as during efi runtime calls i.e current->active_mm == current_mm. * while the EFI-mm is borrowed. mmgrab()/mmdrop() is not used because the mm
* We are not mm_dropping()/mm_grabbing() any mm, because we are not * can not change under us.
* losing/creating any references. * It should be ensured that there are no concurent calls to this function.
*/ */
void efi_switch_mm(struct mm_struct *mm) void efi_switch_mm(struct mm_struct *mm)
{ {
task_lock(current);
efi_scratch.prev_mm = current->active_mm; efi_scratch.prev_mm = current->active_mm;
current->active_mm = mm; current->active_mm = mm;
switch_mm(efi_scratch.prev_mm, mm, NULL); switch_mm(efi_scratch.prev_mm, mm, NULL);
task_unlock(current);
} }
#ifdef CONFIG_EFI_MIXED #ifdef CONFIG_EFI_MIXED