renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-18 18:23:53 +08:00
Code

staging: unisys: visornic: no need to check debugfs return values

Browse Source 
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Clean up the visornic driver code by not caring about the value of
debugfs calls.  This ends up removing a number of lines of code that are
not needed.

Cc: David Kershner <david.kershner@unisys.com>
Cc: Tim Sell <timothy.sell@unisys.com>
Cc: David Binder <david.binder@unisys.com>
Cc: Sameer Wadgaonkar <sameer.wadgaonkar@unisys.com>
Cc: Charles Daniels <cdaniels@fastmail.com>
Cc: sparmaintainer@unisys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2018-05-29 16:29:37 +02:00
parent e206a0d47e
commit 4d883eeac4
1 changed files with 6 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/staging/unisys/visornic/visornic_main.c
View File

@ -2126,30 +2126,19 @@ static struct visor_driver visornic_driver = {
*/
static int visornic_init(void)
{
struct dentry *ret;
int err = -ENOMEM;
int err;
visornic_debugfs_dir = debugfs_create_dir("visornic", NULL);
if (!visornic_debugfs_dir)
return err;
ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
&debugfs_info_fops);
if (!ret)
goto cleanup_debugfs;
ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
NULL, &debugfs_enable_ints_fops);
if (!ret)
goto cleanup_debugfs;
debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
&debugfs_info_fops);
debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir, NULL,
&debugfs_enable_ints_fops);
err = visorbus_register_visor_driver(&visornic_driver);
if (err)
goto cleanup_debugfs;
debugfs_remove_recursive(visornic_debugfs_dir);
return 0;
cleanup_debugfs:
debugfs_remove_recursive(visornic_debugfs_dir);
return err;
}