renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-29 15:43:59 +08:00
Code

hwmon: (nct7904) Fix incorrect temperature limitation register setting of LTD.

Browse Source 
According to kernel hwmon sysfs-interface documentation, temperature
critical max value, typically greater than corresponding temp_max values.
Thus, reads the LTD_HV_HL (LTD HIGH VALUE HIGH LIMITATION) and LTD_LV_HL
(LTD LOW VALUE HIGH LIMITATION) for case hwmon_temp_crit and
hwmon_temp_crit_hyst. Reads the LTD_HV_LL (HIGH VALUE LOW LIMITATION)
and LTD_LV_LL (LOW VALUE LOW LIMITATION) for case hwmon_temp_max
and hwmon_temp_max_hyst.

Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
Link: https://lore.kernel.org/r/20850618155720.24857-1-Amy.Shih@advantech.com.tw
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
amy.shih 2085-06-18 15:57:19 +00:00 committed by Guenter Roeck
parent 7b1b68f013
commit 4a2d78822f
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/hwmon/nct7904.c
View File

@ -398,22 +398,22 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
} }
return 0; return 0;
case hwmon_temp_max: case hwmon_temp_max:
reg1 = LTD_HV_HL_REG; reg1 = LTD_HV_LL_REG;
reg2 = TEMP_CH1_W_REG; reg2 = TEMP_CH1_W_REG;
reg3 = DTS_T_CPU1_W_REG; reg3 = DTS_T_CPU1_W_REG;
break; break;
case hwmon_temp_max_hyst: case hwmon_temp_max_hyst:
reg1 = LTD_LV_HL_REG; reg1 = LTD_LV_LL_REG;
reg2 = TEMP_CH1_WH_REG; reg2 = TEMP_CH1_WH_REG;
reg3 = DTS_T_CPU1_WH_REG; reg3 = DTS_T_CPU1_WH_REG;
break; break;
case hwmon_temp_crit: case hwmon_temp_crit:
reg1 = LTD_HV_LL_REG; reg1 = LTD_HV_HL_REG;
reg2 = TEMP_CH1_C_REG; reg2 = TEMP_CH1_C_REG;
reg3 = DTS_T_CPU1_C_REG; reg3 = DTS_T_CPU1_C_REG;
break; break;
case hwmon_temp_crit_hyst: case hwmon_temp_crit_hyst:
reg1 = LTD_LV_LL_REG; reg1 = LTD_LV_HL_REG;
reg2 = TEMP_CH1_CH_REG; reg2 = TEMP_CH1_CH_REG;
reg3 = DTS_T_CPU1_CH_REG; reg3 = DTS_T_CPU1_CH_REG;
break; break;
@ -507,22 +507,22 @@ static int nct7904_write_temp(struct device *dev, u32 attr, int channel,
switch (attr) { switch (attr) {
case hwmon_temp_max: case hwmon_temp_max:
reg1 = LTD_HV_HL_REG; reg1 = LTD_HV_LL_REG;
reg2 = TEMP_CH1_W_REG; reg2 = TEMP_CH1_W_REG;
reg3 = DTS_T_CPU1_W_REG; reg3 = DTS_T_CPU1_W_REG;
break; break;
case hwmon_temp_max_hyst: case hwmon_temp_max_hyst:
reg1 = LTD_LV_HL_REG; reg1 = LTD_LV_LL_REG;
reg2 = TEMP_CH1_WH_REG; reg2 = TEMP_CH1_WH_REG;
reg3 = DTS_T_CPU1_WH_REG; reg3 = DTS_T_CPU1_WH_REG;
break; break;
case hwmon_temp_crit: case hwmon_temp_crit:
reg1 = LTD_HV_LL_REG; reg1 = LTD_HV_HL_REG;
reg2 = TEMP_CH1_C_REG; reg2 = TEMP_CH1_C_REG;
reg3 = DTS_T_CPU1_C_REG; reg3 = DTS_T_CPU1_C_REG;
break; break;
case hwmon_temp_crit_hyst: case hwmon_temp_crit_hyst:
reg1 = LTD_LV_LL_REG; reg1 = LTD_LV_HL_REG;
reg2 = TEMP_CH1_CH_REG; reg2 = TEMP_CH1_CH_REG;
reg3 = DTS_T_CPU1_CH_REG; reg3 = DTS_T_CPU1_CH_REG;
break; break;