renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-05 03:44:03 +08:00
Code

regulator: raa215300: Change the scope of the variables {clkin_name, xin_name}

Browse Source 
Change the scope of the variables {clkin_name, xin_name} from global->local
to fix the below warning.

drivers/regulator/raa215300.c:42:12: sparse: sparse: symbol 'xin_name' was
not declared. Should it be static?

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306250552.Fan9WTiN-lkp@intel.com/
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230629104200.102663-1-biju.das.jz@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Biju Das 2023-06-29 11:42:00 +01:00 committed by Mark Brown
parent 06c2afb862
commit 42a95739c5
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/regulator/raa215300.c
View File

@ -38,8 +38,6 @@
#define RAA215300_REG_BLOCK_EN_RTC_EN BIT(6) #define RAA215300_REG_BLOCK_EN_RTC_EN BIT(6)
#define RAA215300_RTC_DEFAULT_ADDR 0x6f #define RAA215300_RTC_DEFAULT_ADDR 0x6f
const char *clkin_name = "clkin";
const char *xin_name = "xin";
static struct clk *clk; static struct clk *clk;
static const struct regmap_config raa215300_regmap_config = { static const struct regmap_config raa215300_regmap_config = {
@ -71,8 +69,10 @@ static int raa215300_clk_present(struct i2c_client *client, const char *name)
static int raa215300_i2c_probe(struct i2c_client *client) static int raa215300_i2c_probe(struct i2c_client *client)
{ {
struct device *dev = &client->dev; struct device *dev = &client->dev;
const char *clk_name = xin_name; const char *clkin_name = "clkin";
unsigned int pmic_version, val; unsigned int pmic_version, val;
const char *xin_name = "xin";
const char *clk_name = NULL;
struct regmap *regmap; struct regmap *regmap;
int ret; int ret;
@ -114,15 +114,17 @@ static int raa215300_i2c_probe(struct i2c_client *client)
ret = raa215300_clk_present(client, xin_name); ret = raa215300_clk_present(client, xin_name);
if (ret < 0) { if (ret < 0) {
return ret; return ret;
} else if (!ret) { } else if (ret) {
clk_name = xin_name;
} else {
ret = raa215300_clk_present(client, clkin_name); ret = raa215300_clk_present(client, clkin_name);
if (ret < 0) if (ret < 0)
return ret; return ret;
if (ret)
clk_name = clkin_name; clk_name = clkin_name;
} }
if (ret) { if (clk_name) {
char *name = pmic_version >= 0x12 ? "isl1208" : "raa215300_a0"; char *name = pmic_version >= 0x12 ? "isl1208" : "raa215300_a0";
struct device_node *np = client->dev.of_node; struct device_node *np = client->dev.of_node;
u32 addr = RAA215300_RTC_DEFAULT_ADDR; u32 addr = RAA215300_RTC_DEFAULT_ADDR;