renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-19 02:54:00 +08:00
Code

arm/arm64: KVM: Fix hyp mappings of vmalloc regions

Browse Source 
Using virt_to_phys on percpu mappings is horribly wrong as it may be
backed by vmalloc.  Introduce kvm_kaddr_to_phys which translates both
types of valid kernel addresses to the corresponding physical address.

At the same time resolves a typing issue where we were storing the
physical address as a 32 bit unsigned long (on arm), truncating the
physical address for addresses above the 4GB limit.  This caused
breakage on Keystone.

Cc: <stable@vger.kernel.org>	[3.10+]
Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
This commit is contained in:
Christoffer Dall 2013-11-15 13:14:12 -08:00
parent 5e01dc7b26
commit 40c2729bab
1 changed files with 28 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
arch/arm/kvm/mmu.c
View File

@ -307,6 +307,17 @@ out:
return err; return err;
} }
static phys_addr_t kvm_kaddr_to_phys(void *kaddr)
{
if (!is_vmalloc_addr(kaddr)) {
BUG_ON(!virt_addr_valid(kaddr));
return __pa(kaddr);
} else {
return page_to_phys(vmalloc_to_page(kaddr)) +
offset_in_page(kaddr);
}
}
/** /**
* create_hyp_mappings - duplicate a kernel virtual address range in Hyp mode * create_hyp_mappings - duplicate a kernel virtual address range in Hyp mode
* @from: The virtual kernel start address of the range * @from: The virtual kernel start address of the range
@ -318,16 +329,27 @@ out:
*/ */
int create_hyp_mappings(void *from, void *to) int create_hyp_mappings(void *from, void *to)
{ {
unsigned long phys_addr = virt_to_phys(from); phys_addr_t phys_addr;
unsigned long virt_addr;
unsigned long start = KERN_TO_HYP((unsigned long)from); unsigned long start = KERN_TO_HYP((unsigned long)from);
unsigned long end = KERN_TO_HYP((unsigned long)to); unsigned long end = KERN_TO_HYP((unsigned long)to);
/* Check for a valid kernel memory mapping */ start = start & PAGE_MASK;
if (!virt_addr_valid(from) || !virt_addr_valid(to - 1)) end = PAGE_ALIGN(end);
return -EINVAL;
return __create_hyp_mappings(hyp_pgd, start, end, for (virt_addr = start; virt_addr < end; virt_addr += PAGE_SIZE) {
__phys_to_pfn(phys_addr), PAGE_HYP); int err;
phys_addr = kvm_kaddr_to_phys(from + virt_addr - start);
err = __create_hyp_mappings(hyp_pgd, virt_addr,
virt_addr + PAGE_SIZE,
__phys_to_pfn(phys_addr),
PAGE_HYP);
if (err)
return err;
}
return 0;
} }
/** /**