renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-24 05:04:00 +08:00
Code

staging: fsl-dpaa2/ethsw: use bool when encoding learning/flooding state

Browse Source 
Use a bool instead of an u8 in ethsw_set_learning() and
ethsw_port_set_flood() to encode an binary type property.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1565700187-16048-6-git-send-email-ioana.ciornei@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ioana Ciornei 2019-08-13 15:43:02 +03:00 committed by Greg Kroah-Hartman
parent 47980a20a4
commit 38ec70cc87
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/fsl-dpaa2/ethsw/ethsw.c
View File

@ -149,12 +149,12 @@ static int ethsw_port_add_vlan(struct ethsw_port_priv *port_priv,
return 0; return 0;
} }
static int ethsw_set_learning(struct ethsw_core *ethsw, u8 flag) static int ethsw_set_learning(struct ethsw_core *ethsw, bool enable)
{ {
enum dpsw_fdb_learning_mode learn_mode; enum dpsw_fdb_learning_mode learn_mode;
int err; int err;
if (flag) if (enable)
learn_mode = DPSW_FDB_LEARNING_MODE_HW; learn_mode = DPSW_FDB_LEARNING_MODE_HW;
else else
learn_mode = DPSW_FDB_LEARNING_MODE_DIS; learn_mode = DPSW_FDB_LEARNING_MODE_DIS;
@ -165,24 +165,24 @@ static int ethsw_set_learning(struct ethsw_core *ethsw, u8 flag)
dev_err(ethsw->dev, "dpsw_fdb_set_learning_mode err %d\n", err); dev_err(ethsw->dev, "dpsw_fdb_set_learning_mode err %d\n", err);
return err; return err;
} }
ethsw->learning = !!flag; ethsw->learning = enable;
return 0; return 0;
} }
static int ethsw_port_set_flood(struct ethsw_port_priv *port_priv, u8 flag) static int ethsw_port_set_flood(struct ethsw_port_priv *port_priv, bool enable)
{ {
int err; int err;
err = dpsw_if_set_flooding(port_priv->ethsw_data->mc_io, 0, err = dpsw_if_set_flooding(port_priv->ethsw_data->mc_io, 0,
port_priv->ethsw_data->dpsw_handle, port_priv->ethsw_data->dpsw_handle,
port_priv->idx, flag); port_priv->idx, enable);
if (err) { if (err) {
netdev_err(port_priv->netdev, netdev_err(port_priv->netdev,
"dpsw_if_set_flooding err %d\n", err); "dpsw_if_set_flooding err %d\n", err);
return err; return err;
} }
port_priv->flood = !!flag; port_priv->flood = enable;
return 0; return 0;
} }