renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-30 16:13:54 +08:00
Code

staging: silicom : remove assignment in if condition

Browse Source 
This patch removes the assignment in if conditions to do away with the
checkpatch warning :'do not use assignment in if condition'.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Himangi Saraogi 2014-03-05 02:51:09 +05:30 committed by Greg Kroah-Hartman
parent ee3a636674
commit 338d1ad1ad
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/staging/silicom/bpctl_mod.c
View File

@ -2306,11 +2306,10 @@ static int set_tx(struct bpctl_dev *pbpctl_dev, int tx_state)
if (PEG5_IF_SERIES(pbpctl_dev->subdevice)) { if (PEG5_IF_SERIES(pbpctl_dev->subdevice)) {
if (tx_state) { if (tx_state) {
uint16_t mii_reg; uint16_t mii_reg;
if (! ret = bp75_read_phy_reg(pbpctl_dev,
(ret = BPCTLI_PHY_CONTROL,
bp75_read_phy_reg(pbpctl_dev, &mii_reg);
BPCTLI_PHY_CONTROL, if (!ret) {
&mii_reg))) {
if (mii_reg & BPCTLI_MII_CR_POWER_DOWN) { if (mii_reg & BPCTLI_MII_CR_POWER_DOWN) {
ret = ret =
bp75_write_phy_reg bp75_write_phy_reg
@ -2322,17 +2321,15 @@ static int set_tx(struct bpctl_dev *pbpctl_dev, int tx_state)
} }
} else { } else {
uint16_t mii_reg; uint16_t mii_reg;
if (! ret = bp75_read_phy_reg(pbpctl_dev,
(ret = BPCTLI_PHY_CONTROL,
bp75_read_phy_reg(pbpctl_dev, &mii_reg);
BPCTLI_PHY_CONTROL, if (!ret) {
&mii_reg))) {
mii_reg |= BPCTLI_MII_CR_POWER_DOWN; mii_reg |= BPCTLI_MII_CR_POWER_DOWN;
ret = ret = bp75_write_phy_reg(pbpctl_dev,
bp75_write_phy_reg(pbpctl_dev, BPCTLI_PHY_CONTROL,
BPCTLI_PHY_CONTROL, mii_reg);
mii_reg);
} }
} }