renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 20:53:53 +08:00
Code

staging: comedi: remove thisboard macro in the pcmda12 driver

Browse Source 
The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-05-22 17:42:55 -07:00 committed by Greg Kroah-Hartman
parent 57bbeb3b9b
commit 2fbffee060
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/comedi/drivers/pcmda12.c
View File

@ -80,11 +80,6 @@ static const struct comedi_lrange pcmda12_ranges = {
} }
}; };
/*
* Useful for shorthand access to the particular board structure
*/
#define thisboard ((const struct pcmda12_board *)dev->board_ptr)
struct pcmda12_private { struct pcmda12_private {
unsigned int ao_readback[CHANS]; unsigned int ao_readback[CHANS];
@ -167,6 +162,7 @@ static int ao_rinsn(struct comedi_device *dev, struct comedi_subdevice *s,
static int pcmda12_attach(struct comedi_device *dev, static int pcmda12_attach(struct comedi_device *dev,
struct comedi_devconfig *it) struct comedi_devconfig *it)
{ {
const struct pcmda12_board *board = comedi_board(dev);
struct comedi_subdevice *s; struct comedi_subdevice *s;
unsigned long iobase; unsigned long iobase;
@ -181,11 +177,7 @@ static int pcmda12_attach(struct comedi_device *dev,
} }
dev->iobase = iobase; dev->iobase = iobase;
/* dev->board_name = board->name;
* Initialize dev->board_name. Note that we can use the "thisboard"
* macro now, since we just initialized it in the last line.
*/
dev->board_name = thisboard->name;
/* /*
* Allocate the private structure area. alloc_private() is a * Allocate the private structure area. alloc_private() is a