mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 21:54:06 +08:00
net/hippi/rrunner: use memdup_user
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang <geliangtang@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3bb4858fda
commit
294316a4af
@ -1615,17 +1615,14 @@ static int rr_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
|
||||
return -EPERM;
|
||||
}
|
||||
|
||||
image = kmalloc(EEPROM_WORDS * sizeof(u32), GFP_KERNEL);
|
||||
oldimage = kmalloc(EEPROM_WORDS * sizeof(u32), GFP_KERNEL);
|
||||
if (!image || !oldimage) {
|
||||
error = -ENOMEM;
|
||||
goto wf_out;
|
||||
}
|
||||
image = memdup_user(rq->ifr_data, EEPROM_BYTES);
|
||||
if (IS_ERR(image))
|
||||
return PTR_ERR(image);
|
||||
|
||||
error = copy_from_user(image, rq->ifr_data, EEPROM_BYTES);
|
||||
if (error) {
|
||||
error = -EFAULT;
|
||||
goto wf_out;
|
||||
oldimage = kmalloc(EEPROM_BYTES, GFP_KERNEL);
|
||||
if (!oldimage) {
|
||||
kfree(image);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
if (rrpriv->fw_running){
|
||||
|
Loading…
Reference in New Issue
Block a user