mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-17 01:34:00 +08:00
[PARISC] Quiet sysfs_create_link __must_check warnings in pdc_stable
Failing to create the links doesn't seem like a fatal error in these paths. WARN_ON seems better than nothing though. Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
This commit is contained in:
parent
19c4d5664a
commit
26f0324922
@ -282,6 +282,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun
|
||||
unsigned short i;
|
||||
char in[count+1], *temp;
|
||||
struct device *dev;
|
||||
int ret;
|
||||
|
||||
if (!entry || !buf || !count)
|
||||
return -EINVAL;
|
||||
@ -333,7 +334,9 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry, const char *buf, size_t coun
|
||||
|
||||
/* Update the symlink to the real device */
|
||||
sysfs_remove_link(&entry->kobj, "device");
|
||||
sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
|
||||
ret = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
|
||||
WARN_ON(ret);
|
||||
|
||||
write_unlock(&entry->rw_lock);
|
||||
|
||||
printk(KERN_INFO PDCS_PREFIX ": changed \"%s\" path to \"%s\"\n",
|
||||
@ -1003,8 +1006,10 @@ pdcs_register_pathentries(void)
|
||||
entry->ready = 2;
|
||||
|
||||
/* Add a nice symlink to the real device */
|
||||
if (entry->dev)
|
||||
sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
|
||||
if (entry->dev) {
|
||||
err = sysfs_create_link(&entry->kobj, &entry->dev->kobj, "device");
|
||||
WARN_ON(err);
|
||||
}
|
||||
|
||||
write_unlock(&entry->rw_lock);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user