mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-15 00:34:10 +08:00
mm: Fix generic hugetlb pte check return type.
The include/asm-generic/hugetlb.h stubs that just vector huge_pte_*() calls to the pte_*() implementations won't work in certain situations. x86 and sparc, for example, return "unsigned long" from the bit checks, and just go "return pte_val(pte) & PTE_BIT_FOO;" But since huge_pte_*() returns 'int', if any high bits on 64-bit are relevant, they get chopped off. The net effect is that we can loop forever trying to COW a huge page, because the huge_pte_write() check signals false all the time. Reported-by: Gurudas Pai <gurudas.pai@oracle.com> Tested-by: Gurudas Pai <gurudas.pai@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Acked-by: David Rientjes <rientjes@google.com>
This commit is contained in:
parent
20928bd3f0
commit
2679494246
@ -6,12 +6,12 @@ static inline pte_t mk_huge_pte(struct page *page, pgprot_t pgprot)
|
|||||||
return mk_pte(page, pgprot);
|
return mk_pte(page, pgprot);
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline int huge_pte_write(pte_t pte)
|
static inline unsigned long huge_pte_write(pte_t pte)
|
||||||
{
|
{
|
||||||
return pte_write(pte);
|
return pte_write(pte);
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline int huge_pte_dirty(pte_t pte)
|
static inline unsigned long huge_pte_dirty(pte_t pte)
|
||||||
{
|
{
|
||||||
return pte_dirty(pte);
|
return pte_dirty(pte);
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user