mirror of
https://github.com/edk2-porting/linux-next.git
synced 2025-01-01 10:13:58 +08:00
wl12xx: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Kalle Valo <kvalo@codeaurora.org> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-wireless@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
parent
72efec9b67
commit
23f3896603
@ -125,20 +125,10 @@ WL12XX_DEBUGFS_FWSTATS_FILE(rxpipe, tx_xfr_host_int_trig_rx_data, "%u");
|
||||
int wl12xx_debugfs_add_files(struct wl1271 *wl,
|
||||
struct dentry *rootdir)
|
||||
{
|
||||
int ret = 0;
|
||||
struct dentry *entry, *stats, *moddir;
|
||||
struct dentry *stats, *moddir;
|
||||
|
||||
moddir = debugfs_create_dir(KBUILD_MODNAME, rootdir);
|
||||
if (!moddir || IS_ERR(moddir)) {
|
||||
entry = moddir;
|
||||
goto err;
|
||||
}
|
||||
|
||||
stats = debugfs_create_dir("fw_stats", moddir);
|
||||
if (!stats || IS_ERR(stats)) {
|
||||
entry = stats;
|
||||
goto err;
|
||||
}
|
||||
|
||||
DEBUGFS_FWSTATS_ADD(tx, internal_desc_overflow);
|
||||
|
||||
@ -232,12 +222,4 @@ int wl12xx_debugfs_add_files(struct wl1271 *wl,
|
||||
DEBUGFS_FWSTATS_ADD(rxpipe, tx_xfr_host_int_trig_rx_data);
|
||||
|
||||
return 0;
|
||||
|
||||
err:
|
||||
if (IS_ERR(entry))
|
||||
ret = PTR_ERR(entry);
|
||||
else
|
||||
ret = -ENOMEM;
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user