mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 13:43:55 +08:00
gpiolib: check if irqchip already has the irq hook replacements
Some drivers use a single irqchip for multiple gpiochips. As a result the irqchip hooks are overridden for the first gpiochip that was added, but for the other gpiochip instances this should not happen again, otherwise we would go into an infinite recursion. Check for this, but also log a message that the driver should be fixed since this is bad practice. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
d0121b8548
commit
171948ea33
@ -1858,6 +1858,16 @@ static void gpiochip_set_irq_hooks(struct gpio_chip *gpiochip)
|
||||
}
|
||||
if (WARN_ON(gpiochip->irq.irq_enable))
|
||||
return;
|
||||
/* Check if the irqchip already has this hook... */
|
||||
if (irqchip->irq_enable == gpiochip_irq_enable) {
|
||||
/*
|
||||
* ...and if so, give a gentle warning that this is bad
|
||||
* practice.
|
||||
*/
|
||||
chip_info(gpiochip,
|
||||
"detected irqchip that is shared with multiple gpiochips: please fix the driver.\n");
|
||||
return;
|
||||
}
|
||||
gpiochip->irq.irq_enable = irqchip->irq_enable;
|
||||
gpiochip->irq.irq_disable = irqchip->irq_disable;
|
||||
irqchip->irq_enable = gpiochip_irq_enable;
|
||||
|
Loading…
Reference in New Issue
Block a user