renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-24 21:24:00 +08:00
Code

hwmon: (emc2103) fix unable to change fan pwm1_enable attribute

Browse Source 
This patch fixes a bug which does not let FAN mode to be changed from
sysfs(pwm1_enable). i.e pwm1_enable can not be set to 3, it will always
remain at 0.

This is caused because the device driver handles the result of
"read_u8_from_i2c(client, REG_FAN_CONF1, &conf_reg)" incorrectly. The
driver thinks an error has occurred if the (result != 0). This has been
fixed by changing the condition to (result < 0).

Signed-off-by: Vishwas M <vishwas.reddy.vr@gmail.com>
Link: https://lore.kernel.org/r/20200707142747.118414-1-vishwas.reddy.vr@gmail.com
Fixes: 9df7305b5a ("hwmon: Add driver for SMSC EMC2103 temperature monitor and fan controller")
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Vishwas M 2020-07-07 19:57:47 +05:30 committed by Guenter Roeck
parent f28e360f29
commit 14b0e83dc4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hwmon/emc2103.c
View File

@ -443,7 +443,7 @@ static ssize_t pwm1_enable_store(struct device *dev,
} }
result = read_u8_from_i2c(client, REG_FAN_CONF1, &conf_reg); result = read_u8_from_i2c(client, REG_FAN_CONF1, &conf_reg);
if (result) { if (result < 0) {
count = result; count = result;
goto err; goto err;
} }