mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-15 16:53:54 +08:00
sound: hiface: move to use usb_control_msg_send()
The usb_control_msg_send() call can return an error if a "short" write happens, so move the driver over to using that call instead. v2: API change of use usb_control_msg_send() Cc: Jaroslav Kysela <perex@perex.cz> Reviewed-by: Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20200914153756.3412156-10-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20200923134348.23862-14-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
6d2d427e3b
commit
10fbd979bd
@ -156,16 +156,14 @@ static int hiface_pcm_set_rate(struct pcm_runtime *rt, unsigned int rate)
|
||||
* This control message doesn't have any ack from the
|
||||
* other side
|
||||
*/
|
||||
ret = usb_control_msg(device, usb_sndctrlpipe(device, 0),
|
||||
HIFACE_SET_RATE_REQUEST,
|
||||
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
|
||||
rate_value, 0, NULL, 0, 100);
|
||||
if (ret < 0) {
|
||||
ret = usb_control_msg_send(device, 0,
|
||||
HIFACE_SET_RATE_REQUEST,
|
||||
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
|
||||
rate_value, 0, NULL, 0, 100, GFP_KERNEL);
|
||||
if (ret)
|
||||
dev_err(&device->dev, "Error setting samplerate %d.\n", rate);
|
||||
return ret;
|
||||
}
|
||||
|
||||
return 0;
|
||||
return ret;
|
||||
}
|
||||
|
||||
static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream
|
||||
|
Loading…
Reference in New Issue
Block a user