renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-29 15:43:59 +08:00
Code

ath6kl: Fix a possible null-pointer dereference in ath6kl_htc_mbox_create()

Browse Source 
In ath6kl_htc_mbox_create(), when kzalloc() on line 2855 fails,
target->dev is assigned to NULL, and ath6kl_htc_mbox_cleanup(target) is
called on line 2885.

In ath6kl_htc_mbox_cleanup(), target->dev is used on line 2895:
    ath6kl_hif_cleanup_scatter(target->dev->ar);

Thus, a null-pointer dereference may occur.

To fix this bug, kfree(target) is called and NULL is returned when
kzalloc() on line 2855 fails.

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Jia-Ju Bai 2019-07-29 11:03:05 +08:00 committed by Kalle Valo
parent 72bb1aa91f
commit 0e7bf23e49
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/ath/ath6kl/htc_mbox.c
View File

@ -2855,8 +2855,8 @@ static void *ath6kl_htc_mbox_create(struct ath6kl *ar)
target->dev = kzalloc(sizeof(*target->dev), GFP_KERNEL); target->dev = kzalloc(sizeof(*target->dev), GFP_KERNEL);
if (!target->dev) { if (!target->dev) {
ath6kl_err("unable to allocate memory\n"); ath6kl_err("unable to allocate memory\n");
status = -ENOMEM; kfree(target);
goto err_htc_cleanup; return NULL;
} }
spin_lock_init(&target->htc_lock); spin_lock_init(&target->htc_lock);