renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 12:43:55 +08:00
Code

drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl

Browse Source 
This was previously reported as a security issue due to leakage of
uninitialized stack memory.  Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant. 

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Rosenberg 2010-09-16 22:34:26 -07:00 committed by David S. Miller
parent cd13539b8b
commit 0c796f91a5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/tulip/de4x5.c
View File

@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
tmp.lval[6] = inl(DE4X5_STRR); j+=4; tmp.lval[6] = inl(DE4X5_STRR); j+=4;
tmp.lval[7] = inl(DE4X5_SIGR); j+=4; tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
ioc->len = j; ioc->len = j;
if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT; if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
break; break;
#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */ #define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */