renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-21 11:44:01 +08:00
Code

sctp: fix transport encap_port update in sctp_vtag_verify

Browse Source 
transport encap_port update should be updated when sctp_vtag_verify()
succeeds, namely, returns 1, not returns 0. Correct it in this patch.

While at it, also fix the indentation.

Fixes: a1dd2cf2f1 ("sctp: allow changing transport encap_port by peer packets")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xin Long 2021-10-14 00:50:55 -04:00 committed by David S. Miller
parent c2402d43d1
commit 075718fdaf
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/net/sctp/sm.h
View File

@ -384,11 +384,11 @@ sctp_vtag_verify(const struct sctp_chunk *chunk,
* Verification Tag value does not match the receiver's own * Verification Tag value does not match the receiver's own
* tag value, the receiver shall silently discard the packet... * tag value, the receiver shall silently discard the packet...
*/ */
if (ntohl(chunk->sctp_hdr->vtag) == asoc->c.my_vtag) if (ntohl(chunk->sctp_hdr->vtag) != asoc->c.my_vtag)
return 1; return 0;
chunk->transport->encap_port = SCTP_INPUT_CB(chunk->skb)->encap_port; chunk->transport->encap_port = SCTP_INPUT_CB(chunk->skb)->encap_port;
return 0; return 1;
} }
/* Check VTAG of the packet matches the sender's own tag and the T bit is /* Check VTAG of the packet matches the sender's own tag and the T bit is