renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 20:53:53 +08:00
Code

serial: altera: constify uart_ops structures

Browse Source 
Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2016-09-01 19:51:32 +02:00 committed by Greg Kroah-Hartman
parent 5c7dcdb60d
commit 03bd797f33
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/altera_jtaguart.c
View File

@ -280,7 +280,7 @@ static int altera_jtaguart_verify_port(struct uart_port *port,
/* /*
* Define the basic serial functions we support. * Define the basic serial functions we support.
*/ */
static struct uart_ops altera_jtaguart_ops = { static const struct uart_ops altera_jtaguart_ops = {
.tx_empty = altera_jtaguart_tx_empty, .tx_empty = altera_jtaguart_tx_empty,
.get_mctrl = altera_jtaguart_get_mctrl, .get_mctrl = altera_jtaguart_get_mctrl,
.set_mctrl = altera_jtaguart_set_mctrl, .set_mctrl = altera_jtaguart_set_mctrl,

2
drivers/tty/serial/altera_uart.c
View File

@ -404,7 +404,7 @@ static void altera_uart_poll_put_char(struct uart_port *port, unsigned char c)
/* /*
* Define the basic serial functions we support. * Define the basic serial functions we support.
*/ */
static struct uart_ops altera_uart_ops = { static const struct uart_ops altera_uart_ops = {
.tx_empty = altera_uart_tx_empty, .tx_empty = altera_uart_tx_empty,
.get_mctrl = altera_uart_get_mctrl, .get_mctrl = altera_uart_get_mctrl,
.set_mctrl = altera_uart_set_mctrl, .set_mctrl = altera_uart_set_mctrl,