renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-26 15:45:14 +08:00
Code

media: imx: capture: constify vb2_ops structures

Browse Source 
These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const.  Thus the vb2_ops
structures themselves can be const.

Done with the help of Coccinelle.

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct vb2_ops i@p = { ... };

@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct vb2_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Julia Lawall 2017-08-05 06:47:13 -04:00 committed by Mauro Carvalho Chehab
parent ea3b08cdb1
commit 00f992af58
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/media/imx/imx-media-capture.c
View File

@ -62,7 +62,7 @@ struct capture_priv {
/* In bytes, per queue */ /* In bytes, per queue */
#define VID_MEM_LIMIT SZ_64M #define VID_MEM_LIMIT SZ_64M
static struct vb2_ops capture_qops; static const struct vb2_ops capture_qops;
/* /*
* Video ioctls follow * Video ioctls follow
@ -503,7 +503,7 @@ static void capture_stop_streaming(struct vb2_queue *vq)
spin_unlock_irqrestore(&priv->q_lock, flags); spin_unlock_irqrestore(&priv->q_lock, flags);
} }
static struct vb2_ops capture_qops = { static const struct vb2_ops capture_qops = {
.queue_setup = capture_queue_setup, .queue_setup = capture_queue_setup,
.buf_init = capture_buf_init, .buf_init = capture_buf_init,
.buf_prepare = capture_buf_prepare, .buf_prepare = capture_buf_prepare,