2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
|
* Copyright (C) 1995 Linus Torvalds
|
2009-02-21 02:56:40 +08:00
|
|
|
* Copyright (C) 2001, 2002 Andi Kleen, SuSE Labs.
|
2009-02-21 06:13:36 +08:00
|
|
|
* Copyright (C) 2008-2009, Red Hat Inc., Ingo Molnar
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2009-03-30 05:47:48 +08:00
|
|
|
#include <linux/magic.h> /* STACK_END_MAGIC */
|
|
|
|
|
#include <linux/sched.h> /* test_thread_flag(), ... */
|
|
|
|
|
#include <linux/kdebug.h> /* oops_begin/end, ... */
|
|
|
|
|
#include <linux/module.h> /* search_exception_table */
|
|
|
|
|
#include <linux/bootmem.h> /* max_low_pfn */
|
|
|
|
|
#include <linux/kprobes.h> /* __kprobes, ... */
|
|
|
|
|
#include <linux/mmiotrace.h> /* kmmio_handler, ... */
|
perf: Do the big rename: Performance Counters -> Performance Events
Bye-bye Performance Counters, welcome Performance Events!
In the past few months the perfcounters subsystem has grown out its
initial role of counting hardware events, and has become (and is
becoming) a much broader generic event enumeration, reporting, logging,
monitoring, analysis facility.
Naming its core object 'perf_counter' and naming the subsystem
'perfcounters' has become more and more of a misnomer. With pending
code like hw-breakpoints support the 'counter' name is less and
less appropriate.
All in one, we've decided to rename the subsystem to 'performance
events' and to propagate this rename through all fields, variables
and API names. (in an ABI compatible fashion)
The word 'event' is also a bit shorter than 'counter' - which makes
it slightly more convenient to write/handle as well.
Thanks goes to Stephane Eranian who first observed this misnomer and
suggested a rename.
User-space tooling and ABI compatibility is not affected - this patch
should be function-invariant. (Also, defconfigs were not touched to
keep the size down.)
This patch has been generated via the following script:
FILES=$(find * -type f | grep -vE 'oprofile|[^K]config')
sed -i \
-e 's/PERF_EVENT_/PERF_RECORD_/g' \
-e 's/PERF_COUNTER/PERF_EVENT/g' \
-e 's/perf_counter/perf_event/g' \
-e 's/nb_counters/nb_events/g' \
-e 's/swcounter/swevent/g' \
-e 's/tpcounter_event/tp_event/g' \
$FILES
for N in $(find . -name perf_counter.[ch]); do
M=$(echo $N | sed 's/perf_counter/perf_event/g')
mv $N $M
done
FILES=$(find . -name perf_event.*)
sed -i \
-e 's/COUNTER_MASK/REG_MASK/g' \
-e 's/COUNTER/EVENT/g' \
-e 's/\<event\>/event_id/g' \
-e 's/counter/event/g' \
-e 's/Counter/Event/g' \
$FILES
... to keep it as correct as possible. This script can also be
used by anyone who has pending perfcounters patches - it converts
a Linux kernel tree over to the new naming. We tried to time this
change to the point in time where the amount of pending patches
is the smallest: the end of the merge window.
Namespace clashes were fixed up in a preparatory patch - and some
stylistic fallout will be fixed up in a subsequent patch.
( NOTE: 'counters' are still the proper terminology when we deal
with hardware registers - and these sed scripts are a bit
over-eager in renaming them. I've undone some of that, but
in case there's something left where 'counter' would be
better than 'event' we can undo that on an individual basis
instead of touching an otherwise nicely automated patch. )
Suggested-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-arch@vger.kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-09-21 18:02:48 +08:00
|
|
|
#include <linux/perf_event.h> /* perf_sw_event */
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2009-03-30 05:47:48 +08:00
|
|
|
#include <asm/traps.h> /* dotraplinkage, ... */
|
|
|
|
|
#include <asm/pgalloc.h> /* pgd_*(), ... */
|
2008-04-04 06:53:23 +08:00
|
|
|
#include <asm/kmemcheck.h> /* kmemcheck_*(), ... */
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-01-30 20:32:19 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Page fault error code bits:
|
|
|
|
|
*
|
|
|
|
|
* bit 0 == 0: no page found 1: protection fault
|
|
|
|
|
* bit 1 == 0: read access 1: write access
|
|
|
|
|
* bit 2 == 0: kernel-mode access 1: user-mode access
|
|
|
|
|
* bit 3 == 1: use of reserved bit detected
|
|
|
|
|
* bit 4 == 1: fault was an instruction fetch
|
2008-01-30 20:32:19 +08:00
|
|
|
*/
|
2009-02-21 02:56:40 +08:00
|
|
|
enum x86_pf_error_code {
|
|
|
|
|
|
|
|
|
|
PF_PROT = 1 << 0,
|
|
|
|
|
PF_WRITE = 1 << 1,
|
|
|
|
|
PF_USER = 1 << 2,
|
|
|
|
|
PF_RSVD = 1 << 3,
|
|
|
|
|
PF_INSTR = 1 << 4,
|
|
|
|
|
};
|
2006-01-12 05:44:09 +08:00
|
|
|
|
2009-02-21 05:32:10 +08:00
|
|
|
/*
|
2009-02-22 17:24:18 +08:00
|
|
|
* Returns 0 if mmiotrace is disabled, or if the fault is not
|
|
|
|
|
* handled by mmiotrace:
|
2009-02-21 05:32:10 +08:00
|
|
|
*/
|
2009-08-28 01:23:11 +08:00
|
|
|
static inline int __kprobes
|
|
|
|
|
kmmio_fault(struct pt_regs *regs, unsigned long addr)
|
2008-05-13 03:20:56 +08:00
|
|
|
{
|
x86: mmiotrace full patch, preview 1
kmmio.c handles the list of mmio probes with callbacks, list of traced
pages, and attaching into the page fault handler and die notifier. It
arms, traps and disarms the given pages, this is the core of mmiotrace.
mmio-mod.c is a user interface, hooking into ioremap functions and
registering the mmio probes. It also decodes the required information
from trapped mmio accesses via the pre and post callbacks in each probe.
Currently, hooking into ioremap functions works by redefining the symbols
of the target (binary) kernel module, so that it calls the traced
versions of the functions.
The most notable changes done since the last discussion are:
- kmmio.c is a built-in, not part of the module
- direct call from fault.c to kmmio.c, removing all dynamic hooks
- prepare for unregistering probes at any time
- make kmmio re-initializable and accessible to more than one user
- rewrite kmmio locking to remove all spinlocks from page fault path
Can I abuse call_rcu() like I do in kmmio.c:unregister_kmmio_probe()
or is there a better way?
The function called via call_rcu() itself calls call_rcu() again,
will this work or break? There I need a second grace period for RCU
after the first grace period for page faults.
Mmiotrace itself (mmio-mod.c) is still a module, I am going to attack
that next. At some point I will start looking into how to make mmiotrace
a tracer component of ftrace (thanks for the hint, Ingo). Ftrace should
make the user space part of mmiotracing as simple as
'cat /debug/trace/mmio > dump.txt'.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-13 03:20:57 +08:00
|
|
|
if (unlikely(is_kmmio_active()))
|
|
|
|
|
if (kmmio_handler(regs, addr) == 1)
|
|
|
|
|
return -1;
|
|
|
|
|
return 0;
|
2008-05-13 03:20:56 +08:00
|
|
|
}
|
|
|
|
|
|
2009-08-28 01:23:11 +08:00
|
|
|
static inline int __kprobes notify_page_fault(struct pt_regs *regs)
|
2006-06-26 15:25:25 +08:00
|
|
|
{
|
2007-10-16 16:24:07 +08:00
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
|
|
/* kprobe_running() needs smp_processor_id() */
|
2009-02-21 05:42:57 +08:00
|
|
|
if (kprobes_built_in() && !user_mode_vm(regs)) {
|
2007-10-16 16:24:07 +08:00
|
|
|
preempt_disable();
|
|
|
|
|
if (kprobe_running() && kprobe_fault_handler(regs, 14))
|
|
|
|
|
ret = 1;
|
|
|
|
|
preempt_enable();
|
|
|
|
|
}
|
2006-06-26 15:25:25 +08:00
|
|
|
|
2007-10-16 16:24:07 +08:00
|
|
|
return ret;
|
2008-01-30 20:32:19 +08:00
|
|
|
}
|
2006-06-26 15:25:25 +08:00
|
|
|
|
2008-01-30 20:32:35 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Prefetch quirks:
|
|
|
|
|
*
|
|
|
|
|
* 32-bit mode:
|
|
|
|
|
*
|
|
|
|
|
* Sometimes AMD Athlon/Opteron CPUs report invalid exceptions on prefetch.
|
|
|
|
|
* Check that here and ignore it.
|
2008-01-30 20:32:35 +08:00
|
|
|
*
|
2009-02-21 02:56:40 +08:00
|
|
|
* 64-bit mode:
|
2008-01-30 20:32:35 +08:00
|
|
|
*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Sometimes the CPU reports invalid exceptions on prefetch.
|
|
|
|
|
* Check that here and ignore it.
|
|
|
|
|
*
|
|
|
|
|
* Opcode checker based on code by Richard Brunner.
|
2008-01-30 20:32:35 +08:00
|
|
|
*/
|
2009-02-21 03:37:05 +08:00
|
|
|
static inline int
|
|
|
|
|
check_prefetch_opcode(struct pt_regs *regs, unsigned char *instr,
|
|
|
|
|
unsigned char opcode, int *prefetch)
|
|
|
|
|
{
|
|
|
|
|
unsigned char instr_hi = opcode & 0xf0;
|
|
|
|
|
unsigned char instr_lo = opcode & 0x0f;
|
|
|
|
|
|
|
|
|
|
switch (instr_hi) {
|
|
|
|
|
case 0x20:
|
|
|
|
|
case 0x30:
|
|
|
|
|
/*
|
|
|
|
|
* Values 0x26,0x2E,0x36,0x3E are valid x86 prefixes.
|
|
|
|
|
* In X86_64 long mode, the CPU will signal invalid
|
|
|
|
|
* opcode if some of these prefixes are present so
|
|
|
|
|
* X86_64 will never get here anyway
|
|
|
|
|
*/
|
|
|
|
|
return ((instr_lo & 7) == 0x6);
|
|
|
|
|
#ifdef CONFIG_X86_64
|
|
|
|
|
case 0x40:
|
|
|
|
|
/*
|
|
|
|
|
* In AMD64 long mode 0x40..0x4F are valid REX prefixes
|
|
|
|
|
* Need to figure out under what instruction mode the
|
|
|
|
|
* instruction was issued. Could check the LDT for lm,
|
|
|
|
|
* but for now it's good enough to assume that long
|
|
|
|
|
* mode only uses well known segments or kernel.
|
|
|
|
|
*/
|
|
|
|
|
return (!user_mode(regs)) || (regs->cs == __USER_CS);
|
|
|
|
|
#endif
|
|
|
|
|
case 0x60:
|
|
|
|
|
/* 0x64 thru 0x67 are valid prefixes in all modes. */
|
|
|
|
|
return (instr_lo & 0xC) == 0x4;
|
|
|
|
|
case 0xF0:
|
|
|
|
|
/* 0xF0, 0xF2, 0xF3 are valid prefixes in all modes. */
|
|
|
|
|
return !instr_lo || (instr_lo>>1) == 1;
|
|
|
|
|
case 0x00:
|
|
|
|
|
/* Prefetch instruction is 0x0F0D or 0x0F18 */
|
|
|
|
|
if (probe_kernel_address(instr, opcode))
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
*prefetch = (instr_lo == 0xF) &&
|
|
|
|
|
(opcode == 0x0D || opcode == 0x18);
|
|
|
|
|
return 0;
|
|
|
|
|
default:
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static int
|
|
|
|
|
is_prefetch(struct pt_regs *regs, unsigned long error_code, unsigned long addr)
|
2008-01-30 20:32:19 +08:00
|
|
|
{
|
2009-02-21 02:56:40 +08:00
|
|
|
unsigned char *max_instr;
|
2006-12-07 09:14:06 +08:00
|
|
|
unsigned char *instr;
|
2008-01-30 20:32:19 +08:00
|
|
|
int prefetch = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-03-28 04:29:09 +08:00
|
|
|
/*
|
|
|
|
|
* If it was a exec (instruction fetch) fault on NX page, then
|
|
|
|
|
* do not ignore the fault:
|
|
|
|
|
*/
|
2006-01-12 05:44:09 +08:00
|
|
|
if (error_code & PF_INSTR)
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2008-01-30 20:32:35 +08:00
|
|
|
|
2009-02-21 03:37:05 +08:00
|
|
|
instr = (void *)convert_ip_to_linear(current, regs);
|
2005-04-17 06:24:59 +08:00
|
|
|
max_instr = instr + 15;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2005-06-23 15:08:46 +08:00
|
|
|
if (user_mode(regs) && instr >= (unsigned char *)TASK_SIZE)
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
|
|
2009-02-21 03:37:05 +08:00
|
|
|
while (instr < max_instr) {
|
2009-02-21 02:56:40 +08:00
|
|
|
unsigned char opcode;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-12-07 09:14:06 +08:00
|
|
|
if (probe_kernel_address(instr, opcode))
|
2008-01-30 20:32:19 +08:00
|
|
|
break;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
|
instr++;
|
|
|
|
|
|
2009-02-21 03:37:05 +08:00
|
|
|
if (!check_prefetch_opcode(regs, instr, opcode, &prefetch))
|
2005-04-17 06:20:36 +08:00
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
return prefetch;
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static void
|
|
|
|
|
force_sig_info_fault(int si_signo, int si_code, unsigned long address,
|
|
|
|
|
struct task_struct *tsk)
|
2008-01-30 20:32:35 +08:00
|
|
|
{
|
|
|
|
|
siginfo_t info;
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
info.si_signo = si_signo;
|
|
|
|
|
info.si_errno = 0;
|
|
|
|
|
info.si_code = si_code;
|
|
|
|
|
info.si_addr = (void __user *)address;
|
2009-09-16 17:50:09 +08:00
|
|
|
info.si_addr_lsb = si_code == BUS_MCEERR_AR ? PAGE_SHIFT : 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:32:35 +08:00
|
|
|
force_sig_info(si_signo, &info, tsk);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 05:50:24 +08:00
|
|
|
DEFINE_SPINLOCK(pgd_lock);
|
|
|
|
|
LIST_HEAD(pgd_list);
|
|
|
|
|
|
|
|
|
|
#ifdef CONFIG_X86_32
|
|
|
|
|
static inline pmd_t *vmalloc_sync_one(pgd_t *pgd, unsigned long address)
|
2008-01-30 20:32:19 +08:00
|
|
|
{
|
2009-02-21 05:50:24 +08:00
|
|
|
unsigned index = pgd_index(address);
|
|
|
|
|
pgd_t *pgd_k;
|
|
|
|
|
pud_t *pud, *pud_k;
|
|
|
|
|
pmd_t *pmd, *pmd_k;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2009-02-21 05:50:24 +08:00
|
|
|
pgd += index;
|
|
|
|
|
pgd_k = init_mm.pgd + index;
|
|
|
|
|
|
|
|
|
|
if (!pgd_present(*pgd_k))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* set_pgd(pgd, *pgd_k); here would be useless on PAE
|
|
|
|
|
* and redundant with the set_pmd() on non-PAE. As would
|
|
|
|
|
* set_pud.
|
|
|
|
|
*/
|
|
|
|
|
pud = pud_offset(pgd, address);
|
|
|
|
|
pud_k = pud_offset(pgd_k, address);
|
|
|
|
|
if (!pud_present(*pud_k))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
pmd = pmd_offset(pud, address);
|
|
|
|
|
pmd_k = pmd_offset(pud_k, address);
|
|
|
|
|
if (!pmd_present(*pmd_k))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
2009-02-18 15:05:19 +08:00
|
|
|
if (!pmd_present(*pmd))
|
2009-02-21 05:50:24 +08:00
|
|
|
set_pmd(pmd, *pmd_k);
|
2009-02-18 15:05:19 +08:00
|
|
|
else
|
2009-02-21 05:50:24 +08:00
|
|
|
BUG_ON(pmd_page(*pmd) != pmd_page(*pmd_k));
|
|
|
|
|
|
|
|
|
|
return pmd_k;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void vmalloc_sync_all(void)
|
|
|
|
|
{
|
|
|
|
|
unsigned long address;
|
|
|
|
|
|
|
|
|
|
if (SHARED_KERNEL_PMD)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
for (address = VMALLOC_START & PMD_MASK;
|
|
|
|
|
address >= TASK_SIZE && address < FIXADDR_TOP;
|
|
|
|
|
address += PMD_SIZE) {
|
|
|
|
|
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
struct page *page;
|
|
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pgd_lock, flags);
|
|
|
|
|
list_for_each_entry(page, &pgd_list, lru) {
|
|
|
|
|
if (!vmalloc_sync_one(page_address(page), address))
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
spin_unlock_irqrestore(&pgd_lock, flags);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* 32-bit:
|
|
|
|
|
*
|
|
|
|
|
* Handle a fault on the vmalloc or module mapping area
|
|
|
|
|
*/
|
2009-08-28 01:23:11 +08:00
|
|
|
static noinline __kprobes int vmalloc_fault(unsigned long address)
|
2009-02-21 05:50:24 +08:00
|
|
|
{
|
|
|
|
|
unsigned long pgd_paddr;
|
|
|
|
|
pmd_t *pmd_k;
|
|
|
|
|
pte_t *pte_k;
|
|
|
|
|
|
|
|
|
|
/* Make sure we are in vmalloc area: */
|
|
|
|
|
if (!(address >= VMALLOC_START && address < VMALLOC_END))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Synchronize this task's top level page-table
|
|
|
|
|
* with the 'reference' page table.
|
|
|
|
|
*
|
|
|
|
|
* Do _not_ use "current" here. We might be inside
|
|
|
|
|
* an interrupt in the middle of a task switch..
|
|
|
|
|
*/
|
|
|
|
|
pgd_paddr = read_cr3();
|
|
|
|
|
pmd_k = vmalloc_sync_one(__va(pgd_paddr), address);
|
|
|
|
|
if (!pmd_k)
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
pte_k = pte_offset_kernel(pmd_k, address);
|
|
|
|
|
if (!pte_present(*pte_k))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Did it hit the DOS screen memory VA from vm86 mode?
|
|
|
|
|
*/
|
|
|
|
|
static inline void
|
|
|
|
|
check_v8086_mode(struct pt_regs *regs, unsigned long address,
|
|
|
|
|
struct task_struct *tsk)
|
|
|
|
|
{
|
|
|
|
|
unsigned long bit;
|
|
|
|
|
|
|
|
|
|
if (!v8086_mode(regs))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
bit = (address - 0xA0000) >> PAGE_SHIFT;
|
|
|
|
|
if (bit < 32)
|
|
|
|
|
tsk->thread.screen_bitmap |= 1 << bit;
|
2008-01-30 20:32:19 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-06-27 14:35:15 +08:00
|
|
|
static bool low_pfn(unsigned long pfn)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-06-27 14:35:15 +08:00
|
|
|
return pfn < max_low_pfn;
|
|
|
|
|
}
|
2008-01-30 20:34:10 +08:00
|
|
|
|
2009-06-27 14:35:15 +08:00
|
|
|
static void dump_pagetable(unsigned long address)
|
|
|
|
|
{
|
|
|
|
|
pgd_t *base = __va(read_cr3());
|
|
|
|
|
pgd_t *pgd = &base[pgd_index(address)];
|
|
|
|
|
pmd_t *pmd;
|
|
|
|
|
pte_t *pte;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:34:10 +08:00
|
|
|
#ifdef CONFIG_X86_PAE
|
2009-06-27 14:35:15 +08:00
|
|
|
printk("*pdpt = %016Lx ", pgd_val(*pgd));
|
|
|
|
|
if (!low_pfn(pgd_val(*pgd) >> PAGE_SHIFT) || !pgd_present(*pgd))
|
|
|
|
|
goto out;
|
2008-01-30 20:34:10 +08:00
|
|
|
#endif
|
2009-06-27 14:35:15 +08:00
|
|
|
pmd = pmd_offset(pud_offset(pgd, address), address);
|
|
|
|
|
printk(KERN_CONT "*pde = %0*Lx ", sizeof(*pmd) * 2, (u64)pmd_val(*pmd));
|
2008-01-30 20:34:10 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We must not directly access the pte in the highpte
|
|
|
|
|
* case if the page table is located in highmem.
|
|
|
|
|
* And let's rather not kmap-atomic the pte, just in case
|
2009-02-21 02:56:40 +08:00
|
|
|
* it's allocated already:
|
2008-01-30 20:34:10 +08:00
|
|
|
*/
|
2009-06-27 14:35:15 +08:00
|
|
|
if (!low_pfn(pmd_pfn(*pmd)) || !pmd_present(*pmd) || pmd_large(*pmd))
|
|
|
|
|
goto out;
|
2008-01-30 20:34:10 +08:00
|
|
|
|
2009-06-27 14:35:15 +08:00
|
|
|
pte = pte_offset_kernel(pmd, address);
|
|
|
|
|
printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
|
|
|
|
|
out:
|
2008-01-30 20:34:10 +08:00
|
|
|
printk("\n");
|
2009-02-21 05:50:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#else /* CONFIG_X86_64: */
|
|
|
|
|
|
|
|
|
|
void vmalloc_sync_all(void)
|
|
|
|
|
{
|
2010-05-19 17:42:14 +08:00
|
|
|
sync_global_pgds(VMALLOC_START & PGDIR_MASK, VMALLOC_END);
|
2009-02-21 05:50:24 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* 64-bit:
|
|
|
|
|
*
|
|
|
|
|
* Handle a fault on the vmalloc area
|
|
|
|
|
*
|
|
|
|
|
* This assumes no large pages in there.
|
|
|
|
|
*/
|
2009-08-28 01:23:11 +08:00
|
|
|
static noinline __kprobes int vmalloc_fault(unsigned long address)
|
2009-02-21 05:50:24 +08:00
|
|
|
{
|
|
|
|
|
pgd_t *pgd, *pgd_ref;
|
|
|
|
|
pud_t *pud, *pud_ref;
|
|
|
|
|
pmd_t *pmd, *pmd_ref;
|
|
|
|
|
pte_t *pte, *pte_ref;
|
|
|
|
|
|
|
|
|
|
/* Make sure we are in vmalloc area: */
|
|
|
|
|
if (!(address >= VMALLOC_START && address < VMALLOC_END))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Copy kernel mappings over when needed. This can also
|
|
|
|
|
* happen within a race in page table update. In the later
|
|
|
|
|
* case just flush:
|
|
|
|
|
*/
|
|
|
|
|
pgd = pgd_offset(current->active_mm, address);
|
|
|
|
|
pgd_ref = pgd_offset_k(address);
|
|
|
|
|
if (pgd_none(*pgd_ref))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
if (pgd_none(*pgd))
|
|
|
|
|
set_pgd(pgd, *pgd_ref);
|
|
|
|
|
else
|
|
|
|
|
BUG_ON(pgd_page_vaddr(*pgd) != pgd_page_vaddr(*pgd_ref));
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Below here mismatches are bugs because these lower tables
|
|
|
|
|
* are shared:
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
pud = pud_offset(pgd, address);
|
|
|
|
|
pud_ref = pud_offset(pgd_ref, address);
|
|
|
|
|
if (pud_none(*pud_ref))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
if (pud_none(*pud) || pud_page_vaddr(*pud) != pud_page_vaddr(*pud_ref))
|
|
|
|
|
BUG();
|
|
|
|
|
|
|
|
|
|
pmd = pmd_offset(pud, address);
|
|
|
|
|
pmd_ref = pmd_offset(pud_ref, address);
|
|
|
|
|
if (pmd_none(*pmd_ref))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
if (pmd_none(*pmd) || pmd_page(*pmd) != pmd_page(*pmd_ref))
|
|
|
|
|
BUG();
|
|
|
|
|
|
|
|
|
|
pte_ref = pte_offset_kernel(pmd_ref, address);
|
|
|
|
|
if (!pte_present(*pte_ref))
|
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
|
|
pte = pte_offset_kernel(pmd, address);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Don't use pte_page here, because the mappings can point
|
|
|
|
|
* outside mem_map, and the NUMA hash lookup cannot handle
|
|
|
|
|
* that:
|
|
|
|
|
*/
|
|
|
|
|
if (!pte_present(*pte) || pte_pfn(*pte) != pte_pfn(*pte_ref))
|
|
|
|
|
BUG();
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const char errata93_warning[] =
|
2009-07-07 04:05:40 +08:00
|
|
|
KERN_ERR
|
|
|
|
|
"******* Your BIOS seems to not contain a fix for K8 errata #93\n"
|
|
|
|
|
"******* Working around it, but it may cause SEGVs or burn power.\n"
|
|
|
|
|
"******* Please consider a BIOS update.\n"
|
|
|
|
|
"******* Disabling USB legacy in the BIOS may also help.\n";
|
2009-02-21 05:50:24 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* No vm86 mode in 64-bit mode:
|
|
|
|
|
*/
|
|
|
|
|
static inline void
|
|
|
|
|
check_v8086_mode(struct pt_regs *regs, unsigned long address,
|
|
|
|
|
struct task_struct *tsk)
|
|
|
|
|
{
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int bad_address(void *p)
|
|
|
|
|
{
|
|
|
|
|
unsigned long dummy;
|
|
|
|
|
|
|
|
|
|
return probe_kernel_address((unsigned long *)p, dummy);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void dump_pagetable(unsigned long address)
|
|
|
|
|
{
|
2009-06-27 14:35:15 +08:00
|
|
|
pgd_t *base = __va(read_cr3() & PHYSICAL_PAGE_MASK);
|
|
|
|
|
pgd_t *pgd = base + pgd_index(address);
|
2005-04-17 06:20:36 +08:00
|
|
|
pud_t *pud;
|
|
|
|
|
pmd_t *pmd;
|
|
|
|
|
pte_t *pte;
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
if (bad_address(pgd))
|
|
|
|
|
goto bad;
|
|
|
|
|
|
2006-02-04 04:51:47 +08:00
|
|
|
printk("PGD %lx ", pgd_val(*pgd));
|
2009-02-21 02:56:40 +08:00
|
|
|
|
|
|
|
|
if (!pgd_present(*pgd))
|
|
|
|
|
goto out;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-06-26 19:57:56 +08:00
|
|
|
pud = pud_offset(pgd, address);
|
2009-02-21 02:56:40 +08:00
|
|
|
if (bad_address(pud))
|
|
|
|
|
goto bad;
|
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
printk("PUD %lx ", pud_val(*pud));
|
2008-02-04 23:48:09 +08:00
|
|
|
if (!pud_present(*pud) || pud_large(*pud))
|
2009-02-21 02:56:40 +08:00
|
|
|
goto out;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
|
pmd = pmd_offset(pud, address);
|
2009-02-21 02:56:40 +08:00
|
|
|
if (bad_address(pmd))
|
|
|
|
|
goto bad;
|
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
printk("PMD %lx ", pmd_val(*pmd));
|
2009-02-21 02:56:40 +08:00
|
|
|
if (!pmd_present(*pmd) || pmd_large(*pmd))
|
|
|
|
|
goto out;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
|
pte = pte_offset_kernel(pmd, address);
|
2009-02-21 02:56:40 +08:00
|
|
|
if (bad_address(pte))
|
|
|
|
|
goto bad;
|
|
|
|
|
|
2008-01-30 20:32:19 +08:00
|
|
|
printk("PTE %lx", pte_val(*pte));
|
2009-02-21 02:56:40 +08:00
|
|
|
out:
|
2005-04-17 06:20:36 +08:00
|
|
|
printk("\n");
|
|
|
|
|
return;
|
|
|
|
|
bad:
|
|
|
|
|
printk("BAD\n");
|
2009-02-21 05:12:18 +08:00
|
|
|
}
|
|
|
|
|
|
2009-02-21 05:50:24 +08:00
|
|
|
#endif /* CONFIG_X86_64 */
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/*
|
|
|
|
|
* Workaround for K8 erratum #93 & buggy BIOS.
|
|
|
|
|
*
|
|
|
|
|
* BIOS SMM functions are required to use a specific workaround
|
|
|
|
|
* to avoid corruption of the 64bit RIP register on C stepping K8.
|
|
|
|
|
*
|
|
|
|
|
* A lot of BIOS that didn't get tested properly miss this.
|
|
|
|
|
*
|
|
|
|
|
* The OS sees this as a page fault with the upper 32bits of RIP cleared.
|
|
|
|
|
* Try to work around it here.
|
|
|
|
|
*
|
|
|
|
|
* Note we only handle faults in kernel here.
|
|
|
|
|
* Does nothing on 32-bit.
|
2008-01-30 20:33:13 +08:00
|
|
|
*/
|
2008-01-30 20:32:19 +08:00
|
|
|
static int is_errata93(struct pt_regs *regs, unsigned long address)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2008-01-30 20:33:13 +08:00
|
|
|
#ifdef CONFIG_X86_64
|
2008-01-30 20:30:56 +08:00
|
|
|
if (address != regs->ip)
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:32:19 +08:00
|
|
|
if ((address >> 32) != 0)
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
address |= 0xffffffffUL << 32;
|
2008-01-30 20:32:19 +08:00
|
|
|
if ((address >= (u64)_stext && address <= (u64)_etext) ||
|
|
|
|
|
(address >= MODULES_VADDR && address <= MODULES_END)) {
|
2009-05-03 16:09:03 +08:00
|
|
|
printk_once(errata93_warning);
|
2008-01-30 20:30:56 +08:00
|
|
|
regs->ip = address;
|
2005-04-17 06:20:36 +08:00
|
|
|
return 1;
|
|
|
|
|
}
|
2008-01-30 20:33:13 +08:00
|
|
|
#endif
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2008-01-30 20:32:19 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-01-30 20:34:09 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Work around K8 erratum #100 K8 in compat mode occasionally jumps
|
|
|
|
|
* to illegal addresses >4GB.
|
|
|
|
|
*
|
|
|
|
|
* We catch this in the page fault handler because these addresses
|
|
|
|
|
* are not reachable. Just detect this case and return. Any code
|
2008-01-30 20:34:09 +08:00
|
|
|
* segment in LDT is compatibility mode.
|
|
|
|
|
*/
|
|
|
|
|
static int is_errata100(struct pt_regs *regs, unsigned long address)
|
|
|
|
|
{
|
|
|
|
|
#ifdef CONFIG_X86_64
|
2009-02-21 02:56:40 +08:00
|
|
|
if ((regs->cs == __USER32_CS || (regs->cs & (1<<2))) && (address >> 32))
|
2008-01-30 20:34:09 +08:00
|
|
|
return 1;
|
|
|
|
|
#endif
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2008-01-30 20:34:09 +08:00
|
|
|
static int is_f00f_bug(struct pt_regs *regs, unsigned long address)
|
|
|
|
|
{
|
|
|
|
|
#ifdef CONFIG_X86_F00F_BUG
|
|
|
|
|
unsigned long nr;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:34:09 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Pentium F0 0F C7 C8 bug workaround:
|
2008-01-30 20:34:09 +08:00
|
|
|
*/
|
|
|
|
|
if (boot_cpu_data.f00f_bug) {
|
|
|
|
|
nr = (address - idt_descr.address) >> 3;
|
|
|
|
|
|
|
|
|
|
if (nr == 6) {
|
|
|
|
|
do_invalid_op(regs, 0);
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 06:00:29 +08:00
|
|
|
static const char nx_warning[] = KERN_CRIT
|
|
|
|
|
"kernel tried to execute NX-protected page - exploit attempt? (uid: %d)\n";
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static void
|
|
|
|
|
show_fault_oops(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
2008-01-30 20:34:10 +08:00
|
|
|
{
|
2008-01-30 20:34:10 +08:00
|
|
|
if (!oops_may_print())
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (error_code & PF_INSTR) {
|
2008-02-02 00:49:43 +08:00
|
|
|
unsigned int level;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:34:10 +08:00
|
|
|
pte_t *pte = lookup_address(address, &level);
|
|
|
|
|
|
2009-02-21 06:00:29 +08:00
|
|
|
if (pte && pte_present(*pte) && !pte_exec(*pte))
|
|
|
|
|
printk(nx_warning, current_uid());
|
2008-01-30 20:34:10 +08:00
|
|
|
}
|
|
|
|
|
|
2008-01-30 20:34:10 +08:00
|
|
|
printk(KERN_ALERT "BUG: unable to handle kernel ");
|
2008-01-30 20:34:10 +08:00
|
|
|
if (address < PAGE_SIZE)
|
2008-01-30 20:34:10 +08:00
|
|
|
printk(KERN_CONT "NULL pointer dereference");
|
2008-01-30 20:34:10 +08:00
|
|
|
else
|
2008-01-30 20:34:10 +08:00
|
|
|
printk(KERN_CONT "paging request");
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-07-01 21:38:13 +08:00
|
|
|
printk(KERN_CONT " at %p\n", (void *) address);
|
2008-01-30 20:34:10 +08:00
|
|
|
printk(KERN_ALERT "IP:");
|
2008-01-30 20:34:10 +08:00
|
|
|
printk_address(regs->ip, 1);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-01-30 20:34:10 +08:00
|
|
|
dump_pagetable(address);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
pgtable_bad(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-21 02:56:40 +08:00
|
|
|
struct task_struct *tsk;
|
|
|
|
|
unsigned long flags;
|
|
|
|
|
int sig;
|
|
|
|
|
|
|
|
|
|
flags = oops_begin();
|
|
|
|
|
tsk = current;
|
|
|
|
|
sig = SIGKILL;
|
2005-09-13 00:49:24 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
printk(KERN_ALERT "%s: Corrupted page table at address %lx\n",
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
tsk->comm, address);
|
2005-04-17 06:20:36 +08:00
|
|
|
dump_pagetable(address);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
|
|
|
|
tsk->thread.cr2 = address;
|
|
|
|
|
tsk->thread.trap_no = 14;
|
|
|
|
|
tsk->thread.error_code = error_code;
|
|
|
|
|
|
2008-01-30 20:31:23 +08:00
|
|
|
if (__die("Bad pagetable", regs, error_code))
|
2008-10-22 18:00:09 +08:00
|
|
|
sig = 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-10-22 18:00:09 +08:00
|
|
|
oops_end(flags, regs, sig);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
no_context(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
struct task_struct *tsk = current;
|
2009-01-21 17:39:51 +08:00
|
|
|
unsigned long *stackend;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
int sig;
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* Are we prepared to handle this kernel fault? */
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (fixup_exception(regs))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* 32-bit:
|
|
|
|
|
*
|
|
|
|
|
* Valid to do another page fault here, because if this fault
|
|
|
|
|
* had been triggered by is_prefetch fixup_exception would have
|
|
|
|
|
* handled it.
|
|
|
|
|
*
|
|
|
|
|
* 64-bit:
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Hall of shame of CPU/BIOS bugs.
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*/
|
|
|
|
|
if (is_prefetch(regs, error_code, address))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (is_errata93(regs, address))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Oops. The kernel tried to access some bad page. We'll have to
|
2009-02-21 02:56:40 +08:00
|
|
|
* terminate things with extreme prejudice:
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*/
|
|
|
|
|
flags = oops_begin();
|
|
|
|
|
|
|
|
|
|
show_fault_oops(regs, error_code, address);
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
stackend = end_of_stack(tsk);
|
2009-11-20 22:00:14 +08:00
|
|
|
if (tsk != &init_task && *stackend != STACK_END_MAGIC)
|
2009-01-21 17:39:51 +08:00
|
|
|
printk(KERN_ALERT "Thread overran stack, or stack corrupted\n");
|
|
|
|
|
|
2009-02-21 06:07:48 +08:00
|
|
|
tsk->thread.cr2 = address;
|
|
|
|
|
tsk->thread.trap_no = 14;
|
|
|
|
|
tsk->thread.error_code = error_code;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
|
|
|
|
|
sig = SIGKILL;
|
|
|
|
|
if (__die("Oops", regs, error_code))
|
|
|
|
|
sig = 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
/* Executive summary in case the body of the oops scrolled away */
|
|
|
|
|
printk(KERN_EMERG "CR2: %016lx\n", address);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
oops_end(flags, regs, sig);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/*
|
|
|
|
|
* Print out info about fatal segfaults, if the show_unhandled_signals
|
|
|
|
|
* sysctl is set:
|
|
|
|
|
*/
|
|
|
|
|
static inline void
|
|
|
|
|
show_signal_msg(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address, struct task_struct *tsk)
|
|
|
|
|
{
|
|
|
|
|
if (!unhandled_signal(tsk, SIGSEGV))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (!printk_ratelimit())
|
|
|
|
|
return;
|
|
|
|
|
|
2009-07-11 15:10:04 +08:00
|
|
|
printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx",
|
2009-02-21 02:56:40 +08:00
|
|
|
task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
|
|
|
|
|
tsk->comm, task_pid_nr(tsk), address,
|
|
|
|
|
(void *)regs->ip, (void *)regs->sp, error_code);
|
|
|
|
|
|
|
|
|
|
print_vma_addr(KERN_CONT " in ", regs->ip);
|
|
|
|
|
|
|
|
|
|
printk(KERN_CONT "\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
__bad_area_nosemaphore(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address, int si_code)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
struct task_struct *tsk = current;
|
|
|
|
|
|
|
|
|
|
/* User mode accesses just cause a SIGSEGV */
|
|
|
|
|
if (error_code & PF_USER) {
|
|
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* It's possible to have interrupts off here:
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*/
|
|
|
|
|
local_irq_enable();
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Valid to do another page fault here because this one came
|
2009-02-21 02:56:40 +08:00
|
|
|
* from user space:
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*/
|
|
|
|
|
if (is_prefetch(regs, error_code, address))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (is_errata100(regs, address))
|
|
|
|
|
return;
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
if (unlikely(show_unhandled_signals))
|
|
|
|
|
show_signal_msg(regs, error_code, address, tsk);
|
|
|
|
|
|
|
|
|
|
/* Kernel addresses are always protection faults: */
|
|
|
|
|
tsk->thread.cr2 = address;
|
|
|
|
|
tsk->thread.error_code = error_code | (address >= TASK_SIZE);
|
|
|
|
|
tsk->thread.trap_no = 14;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
|
|
|
|
|
force_sig_info_fault(SIGSEGV, si_code, address, tsk);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (is_f00f_bug(regs, address))
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
no_context(regs, error_code, address);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
bad_area_nosemaphore(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
__bad_area_nosemaphore(regs, error_code, address, SEGV_MAPERR);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static void
|
|
|
|
|
__bad_area(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address, int si_code)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
struct mm_struct *mm = current->mm;
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Something tried to access memory that isn't in our memory map..
|
|
|
|
|
* Fix it, but check if it's kernel or user first..
|
|
|
|
|
*/
|
|
|
|
|
up_read(&mm->mmap_sem);
|
|
|
|
|
|
|
|
|
|
__bad_area_nosemaphore(regs, error_code, address, si_code);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
bad_area(struct pt_regs *regs, unsigned long error_code, unsigned long address)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
__bad_area(regs, error_code, address, SEGV_MAPERR);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
bad_area_access_error(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
__bad_area(regs, error_code, address, SEGV_ACCERR);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* TODO: fixup for "mm-invoke-oom-killer-from-page-fault.patch" */
|
2009-02-21 02:56:40 +08:00
|
|
|
static void
|
|
|
|
|
out_of_memory(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
/*
|
|
|
|
|
* We ran out of memory, call the OOM killer, and return the userspace
|
2009-02-21 02:56:40 +08:00
|
|
|
* (which will retry the fault, or kill us if we got oom-killed):
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
*/
|
|
|
|
|
up_read(¤t->mm->mmap_sem);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
pagefault_out_of_memory();
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static void
|
2009-09-16 17:50:09 +08:00
|
|
|
do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address,
|
|
|
|
|
unsigned int fault)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
struct task_struct *tsk = current;
|
|
|
|
|
struct mm_struct *mm = tsk->mm;
|
2009-09-16 17:50:09 +08:00
|
|
|
int code = BUS_ADRERR;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
|
|
|
|
|
up_read(&mm->mmap_sem);
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* Kernel mode? Handle exceptions or die: */
|
2010-08-14 00:49:20 +08:00
|
|
|
if (!(error_code & PF_USER)) {
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
no_context(regs, error_code, address);
|
2010-08-14 00:49:20 +08:00
|
|
|
return;
|
|
|
|
|
}
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2009-02-21 06:39:02 +08:00
|
|
|
/* User-space => ok to do another page fault: */
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (is_prefetch(regs, error_code, address))
|
|
|
|
|
return;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
|
|
|
|
tsk->thread.cr2 = address;
|
|
|
|
|
tsk->thread.error_code = error_code;
|
|
|
|
|
tsk->thread.trap_no = 14;
|
|
|
|
|
|
2009-09-16 17:50:09 +08:00
|
|
|
#ifdef CONFIG_MEMORY_FAILURE
|
|
|
|
|
if (fault & VM_FAULT_HWPOISON) {
|
|
|
|
|
printk(KERN_ERR
|
|
|
|
|
"MCE: Killing %s:%d due to hardware memory corruption fault at %lx\n",
|
|
|
|
|
tsk->comm, tsk->pid, address);
|
|
|
|
|
code = BUS_MCEERR_AR;
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
force_sig_info_fault(SIGBUS, code, address, tsk);
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static noinline void
|
|
|
|
|
mm_fault_error(struct pt_regs *regs, unsigned long error_code,
|
|
|
|
|
unsigned long address, unsigned int fault)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
2009-02-21 02:56:40 +08:00
|
|
|
if (fault & VM_FAULT_OOM) {
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
out_of_memory(regs, error_code, address);
|
2009-02-21 02:56:40 +08:00
|
|
|
} else {
|
2009-09-16 17:50:09 +08:00
|
|
|
if (fault & (VM_FAULT_SIGBUS|VM_FAULT_HWPOISON))
|
|
|
|
|
do_sigbus(regs, error_code, address, fault);
|
2009-02-21 02:56:40 +08:00
|
|
|
else
|
|
|
|
|
BUG();
|
|
|
|
|
}
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
}
|
|
|
|
|
|
2008-02-07 05:39:43 +08:00
|
|
|
static int spurious_fault_check(unsigned long error_code, pte_t *pte)
|
|
|
|
|
{
|
|
|
|
|
if ((error_code & PF_WRITE) && !pte_write(*pte))
|
|
|
|
|
return 0;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2008-02-07 05:39:43 +08:00
|
|
|
if ((error_code & PF_INSTR) && !pte_exec(*pte))
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
|
}
|
|
|
|
|
|
2008-01-30 20:34:11 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Handle a spurious fault caused by a stale TLB entry.
|
|
|
|
|
*
|
|
|
|
|
* This allows us to lazily refresh the TLB when increasing the
|
|
|
|
|
* permissions of a kernel page (RO -> RW or NX -> X). Doing it
|
|
|
|
|
* eagerly is very expensive since that implies doing a full
|
|
|
|
|
* cross-processor TLB flush, even if no stale TLB entries exist
|
|
|
|
|
* on other processors.
|
|
|
|
|
*
|
2008-01-30 20:34:11 +08:00
|
|
|
* There are no security implications to leaving a stale TLB when
|
|
|
|
|
* increasing the permissions on a page.
|
|
|
|
|
*/
|
2009-08-28 01:23:11 +08:00
|
|
|
static noinline __kprobes int
|
2009-02-21 02:56:40 +08:00
|
|
|
spurious_fault(unsigned long error_code, unsigned long address)
|
2008-01-30 20:34:11 +08:00
|
|
|
{
|
|
|
|
|
pgd_t *pgd;
|
|
|
|
|
pud_t *pud;
|
|
|
|
|
pmd_t *pmd;
|
|
|
|
|
pte_t *pte;
|
2009-02-20 00:46:36 +08:00
|
|
|
int ret;
|
2008-01-30 20:34:11 +08:00
|
|
|
|
|
|
|
|
/* Reserved-bit violation or user access to kernel space? */
|
|
|
|
|
if (error_code & (PF_USER | PF_RSVD))
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
pgd = init_mm.pgd + pgd_index(address);
|
|
|
|
|
if (!pgd_present(*pgd))
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
pud = pud_offset(pgd, address);
|
|
|
|
|
if (!pud_present(*pud))
|
|
|
|
|
return 0;
|
|
|
|
|
|
2008-02-07 05:39:43 +08:00
|
|
|
if (pud_large(*pud))
|
|
|
|
|
return spurious_fault_check(error_code, (pte_t *) pud);
|
|
|
|
|
|
2008-01-30 20:34:11 +08:00
|
|
|
pmd = pmd_offset(pud, address);
|
|
|
|
|
if (!pmd_present(*pmd))
|
|
|
|
|
return 0;
|
|
|
|
|
|
2008-02-07 05:39:43 +08:00
|
|
|
if (pmd_large(*pmd))
|
|
|
|
|
return spurious_fault_check(error_code, (pte_t *) pmd);
|
|
|
|
|
|
2010-07-27 16:06:28 +08:00
|
|
|
/*
|
|
|
|
|
* Note: don't use pte_present() here, since it returns true
|
|
|
|
|
* if the _PAGE_PROTNONE bit is set. However, this aliases the
|
|
|
|
|
* _PAGE_GLOBAL bit, which for kernel pages give false positives
|
|
|
|
|
* when CONFIG_DEBUG_PAGEALLOC is used.
|
|
|
|
|
*/
|
2008-01-30 20:34:11 +08:00
|
|
|
pte = pte_offset_kernel(pmd, address);
|
2010-07-27 16:06:28 +08:00
|
|
|
if (!(pte_flags(*pte) & _PAGE_PRESENT))
|
2008-01-30 20:34:11 +08:00
|
|
|
return 0;
|
|
|
|
|
|
2009-02-20 00:46:36 +08:00
|
|
|
ret = spurious_fault_check(error_code, pte);
|
|
|
|
|
if (!ret)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* Make sure we have permissions in PMD.
|
|
|
|
|
* If not, then there's a bug in the page tables:
|
2009-02-20 00:46:36 +08:00
|
|
|
*/
|
|
|
|
|
ret = spurious_fault_check(error_code, (pte_t *) pmd);
|
|
|
|
|
WARN_ONCE(!ret, "PMD has incorrect permission bits\n");
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2009-02-20 00:46:36 +08:00
|
|
|
return ret;
|
2008-01-30 20:34:11 +08:00
|
|
|
}
|
|
|
|
|
|
2007-07-22 17:12:28 +08:00
|
|
|
int show_unhandled_signals = 1;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
static inline int
|
|
|
|
|
access_error(unsigned long error_code, int write, struct vm_area_struct *vma)
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
{
|
|
|
|
|
if (write) {
|
2009-02-21 02:56:40 +08:00
|
|
|
/* write, present and write, not present: */
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(!(vma->vm_flags & VM_WRITE)))
|
|
|
|
|
return 1;
|
2009-02-21 02:56:40 +08:00
|
|
|
return 0;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* read, present: */
|
|
|
|
|
if (unlikely(error_code & PF_PROT))
|
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
|
|
/* read, not present: */
|
|
|
|
|
if (unlikely(!(vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))))
|
|
|
|
|
return 1;
|
|
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-05 07:24:09 +08:00
|
|
|
static int fault_in_kernel_space(unsigned long address)
|
|
|
|
|
{
|
2009-02-21 06:32:28 +08:00
|
|
|
return address >= TASK_SIZE_MAX;
|
2009-02-05 07:24:09 +08:00
|
|
|
}
|
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
|
* This routine handles page faults. It determines the address,
|
|
|
|
|
* and the problem, and then passes it off to one of the appropriate
|
|
|
|
|
* routines.
|
|
|
|
|
*/
|
2009-02-21 06:22:34 +08:00
|
|
|
dotraplinkage void __kprobes
|
|
|
|
|
do_page_fault(struct pt_regs *regs, unsigned long error_code)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-02-21 02:56:40 +08:00
|
|
|
struct vm_area_struct *vma;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct task_struct *tsk;
|
2009-02-21 02:56:40 +08:00
|
|
|
unsigned long address;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct mm_struct *mm;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
int write;
|
2008-01-30 20:34:10 +08:00
|
|
|
int fault;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-03-25 23:30:10 +08:00
|
|
|
tsk = current;
|
|
|
|
|
mm = tsk->mm;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
|
|
|
|
/* Get the faulting address: */
|
2007-07-22 17:12:29 +08:00
|
|
|
address = read_cr2();
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-04-04 06:53:23 +08:00
|
|
|
/*
|
|
|
|
|
* Detect and handle instructions that would cause a page fault for
|
|
|
|
|
* both a tracked kernel page and a userspace page.
|
|
|
|
|
*/
|
|
|
|
|
if (kmemcheck_active(regs))
|
|
|
|
|
kmemcheck_hide(regs);
|
2009-06-16 16:23:32 +08:00
|
|
|
prefetchw(&mm->mmap_sem);
|
2008-04-04 06:53:23 +08:00
|
|
|
|
x86: mmiotrace full patch, preview 1
kmmio.c handles the list of mmio probes with callbacks, list of traced
pages, and attaching into the page fault handler and die notifier. It
arms, traps and disarms the given pages, this is the core of mmiotrace.
mmio-mod.c is a user interface, hooking into ioremap functions and
registering the mmio probes. It also decodes the required information
from trapped mmio accesses via the pre and post callbacks in each probe.
Currently, hooking into ioremap functions works by redefining the symbols
of the target (binary) kernel module, so that it calls the traced
versions of the functions.
The most notable changes done since the last discussion are:
- kmmio.c is a built-in, not part of the module
- direct call from fault.c to kmmio.c, removing all dynamic hooks
- prepare for unregistering probes at any time
- make kmmio re-initializable and accessible to more than one user
- rewrite kmmio locking to remove all spinlocks from page fault path
Can I abuse call_rcu() like I do in kmmio.c:unregister_kmmio_probe()
or is there a better way?
The function called via call_rcu() itself calls call_rcu() again,
will this work or break? There I need a second grace period for RCU
after the first grace period for page faults.
Mmiotrace itself (mmio-mod.c) is still a module, I am going to attack
that next. At some point I will start looking into how to make mmiotrace
a tracer component of ftrace (thanks for the hint, Ingo). Ftrace should
make the user space part of mmiotracing as simple as
'cat /debug/trace/mmio > dump.txt'.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-05-13 03:20:57 +08:00
|
|
|
if (unlikely(kmmio_fault(regs, address)))
|
2008-05-13 03:20:56 +08:00
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We fault-in kernel-space virtual memory on-demand. The
|
|
|
|
|
* 'reference' page table is init_mm.pgd.
|
|
|
|
|
*
|
|
|
|
|
* NOTE! We MUST NOT take any locks for this case. We may
|
|
|
|
|
* be in an interrupt or a critical region, and should
|
|
|
|
|
* only copy the information from the master page table,
|
|
|
|
|
* nothing more.
|
|
|
|
|
*
|
|
|
|
|
* This verifies that the fault happens in kernel space
|
|
|
|
|
* (error_code & 4) == 0, and that the fault was not a
|
2006-01-12 05:42:23 +08:00
|
|
|
* protection error (error_code & 9) == 0.
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2009-02-05 07:24:09 +08:00
|
|
|
if (unlikely(fault_in_kernel_space(address))) {
|
2008-04-04 06:53:23 +08:00
|
|
|
if (!(error_code & (PF_RSVD | PF_USER | PF_PROT))) {
|
|
|
|
|
if (vmalloc_fault(address) >= 0)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
if (kmemcheck_fault(regs, address, error_code))
|
|
|
|
|
return;
|
|
|
|
|
}
|
2008-01-30 20:34:11 +08:00
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* Can handle a stale RO->RW TLB: */
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (spurious_fault(error_code, address))
|
2008-01-30 20:34:11 +08:00
|
|
|
return;
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* kprobes don't want to hook the spurious faults: */
|
2009-02-06 06:12:39 +08:00
|
|
|
if (notify_page_fault(regs))
|
|
|
|
|
return;
|
2008-01-30 20:34:10 +08:00
|
|
|
/*
|
|
|
|
|
* Don't take the mm semaphore here. If we fixup a prefetch
|
2009-02-21 02:56:40 +08:00
|
|
|
* fault we could otherwise deadlock:
|
2008-01-30 20:34:10 +08:00
|
|
|
*/
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
bad_area_nosemaphore(regs, error_code, address);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
return;
|
2008-01-30 20:34:10 +08:00
|
|
|
}
|
|
|
|
|
|
2009-02-21 02:56:40 +08:00
|
|
|
/* kprobes don't want to hook the spurious faults: */
|
2009-02-13 16:44:22 +08:00
|
|
|
if (unlikely(notify_page_fault(regs)))
|
2009-02-06 06:12:39 +08:00
|
|
|
return;
|
2008-01-30 20:34:10 +08:00
|
|
|
/*
|
2008-10-13 04:16:12 +08:00
|
|
|
* It's safe to allow irq's after cr2 has been saved and the
|
|
|
|
|
* vmalloc fault has been handled.
|
|
|
|
|
*
|
|
|
|
|
* User-mode registers count as a user access even for any
|
2009-02-21 02:56:40 +08:00
|
|
|
* potential system fault or CPU buglet:
|
2008-01-30 20:34:10 +08:00
|
|
|
*/
|
2008-10-13 04:16:12 +08:00
|
|
|
if (user_mode_vm(regs)) {
|
|
|
|
|
local_irq_enable();
|
|
|
|
|
error_code |= PF_USER;
|
2009-02-21 02:56:40 +08:00
|
|
|
} else {
|
|
|
|
|
if (regs->flags & X86_EFLAGS_IF)
|
|
|
|
|
local_irq_enable();
|
|
|
|
|
}
|
2006-03-25 23:29:40 +08:00
|
|
|
|
2006-01-12 05:44:09 +08:00
|
|
|
if (unlikely(error_code & PF_RSVD))
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
pgtable_bad(regs, error_code, address);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
perf: Do the big rename: Performance Counters -> Performance Events
Bye-bye Performance Counters, welcome Performance Events!
In the past few months the perfcounters subsystem has grown out its
initial role of counting hardware events, and has become (and is
becoming) a much broader generic event enumeration, reporting, logging,
monitoring, analysis facility.
Naming its core object 'perf_counter' and naming the subsystem
'perfcounters' has become more and more of a misnomer. With pending
code like hw-breakpoints support the 'counter' name is less and
less appropriate.
All in one, we've decided to rename the subsystem to 'performance
events' and to propagate this rename through all fields, variables
and API names. (in an ABI compatible fashion)
The word 'event' is also a bit shorter than 'counter' - which makes
it slightly more convenient to write/handle as well.
Thanks goes to Stephane Eranian who first observed this misnomer and
suggested a rename.
User-space tooling and ABI compatibility is not affected - this patch
should be function-invariant. (Also, defconfigs were not touched to
keep the size down.)
This patch has been generated via the following script:
FILES=$(find * -type f | grep -vE 'oprofile|[^K]config')
sed -i \
-e 's/PERF_EVENT_/PERF_RECORD_/g' \
-e 's/PERF_COUNTER/PERF_EVENT/g' \
-e 's/perf_counter/perf_event/g' \
-e 's/nb_counters/nb_events/g' \
-e 's/swcounter/swevent/g' \
-e 's/tpcounter_event/tp_event/g' \
$FILES
for N in $(find . -name perf_counter.[ch]); do
M=$(echo $N | sed 's/perf_counter/perf_event/g')
mv $N $M
done
FILES=$(find . -name perf_event.*)
sed -i \
-e 's/COUNTER_MASK/REG_MASK/g' \
-e 's/COUNTER/EVENT/g' \
-e 's/\<event\>/event_id/g' \
-e 's/counter/event/g' \
-e 's/Counter/Event/g' \
$FILES
... to keep it as correct as possible. This script can also be
used by anyone who has pending perfcounters patches - it converts
a Linux kernel tree over to the new naming. We tried to time this
change to the point in time where the amount of pending patches
is the smallest: the end of the merge window.
Namespace clashes were fixed up in a preparatory patch - and some
stylistic fallout will be fixed up in a subsequent patch.
( NOTE: 'counters' are still the proper terminology when we deal
with hardware registers - and these sed scripts are a bit
over-eager in renaming them. I've undone some of that, but
in case there's something left where 'counter' would be
better than 'event' we can undo that on an individual basis
instead of touching an otherwise nicely automated patch. )
Suggested-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-arch@vger.kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-09-21 18:02:48 +08:00
|
|
|
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, 0, regs, address);
|
2009-03-13 19:21:33 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* If we're in an interrupt, have no user context or are running
|
|
|
|
|
* in an atomic region then we must not take the fault:
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(in_atomic() || !mm)) {
|
|
|
|
|
bad_area_nosemaphore(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-10-13 23:49:02 +08:00
|
|
|
/*
|
|
|
|
|
* When running in the kernel we expect faults to occur only to
|
2009-02-21 02:56:40 +08:00
|
|
|
* addresses in user space. All other faults represent errors in
|
|
|
|
|
* the kernel and should generate an OOPS. Unfortunately, in the
|
|
|
|
|
* case of an erroneous fault occurring in a code path which already
|
|
|
|
|
* holds mmap_sem we will deadlock attempting to validate the fault
|
|
|
|
|
* against the address space. Luckily the kernel only validly
|
|
|
|
|
* references user space from well defined areas of code, which are
|
|
|
|
|
* listed in the exceptions table.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
|
|
|
|
* As the vast majority of faults will be valid we will only perform
|
2009-02-21 02:56:40 +08:00
|
|
|
* the source reference check when there is a possibility of a
|
|
|
|
|
* deadlock. Attempt to lock the address space, if we cannot we then
|
|
|
|
|
* validate the source. If this is invalid we can skip the address
|
|
|
|
|
* space check, thus avoiding the deadlock:
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(!down_read_trylock(&mm->mmap_sem))) {
|
2006-01-12 05:44:09 +08:00
|
|
|
if ((error_code & PF_USER) == 0 &&
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
!search_exception_tables(regs->ip)) {
|
|
|
|
|
bad_area_nosemaphore(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
down_read(&mm->mmap_sem);
|
2009-01-29 23:02:12 +08:00
|
|
|
} else {
|
|
|
|
|
/*
|
2009-02-21 02:56:40 +08:00
|
|
|
* The above down_read_trylock() might have succeeded in
|
|
|
|
|
* which case we'll have missed the might_sleep() from
|
|
|
|
|
* down_read():
|
2009-01-29 23:02:12 +08:00
|
|
|
*/
|
|
|
|
|
might_sleep();
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
vma = find_vma(mm, address);
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(!vma)) {
|
|
|
|
|
bad_area(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
if (likely(vma->vm_start <= address))
|
2005-04-17 06:20:36 +08:00
|
|
|
goto good_area;
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(!(vma->vm_flags & VM_GROWSDOWN))) {
|
|
|
|
|
bad_area(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2008-01-30 20:32:19 +08:00
|
|
|
if (error_code & PF_USER) {
|
2008-01-30 20:33:13 +08:00
|
|
|
/*
|
|
|
|
|
* Accessing the stack below %sp is always a bug.
|
|
|
|
|
* The large cushion allows instructions like enter
|
2009-02-21 02:56:40 +08:00
|
|
|
* and pusha to work. ("enter $65535, $31" pushes
|
2008-01-30 20:33:13 +08:00
|
|
|
* 32 pointers and then decrements %sp by 65535.)
|
2006-06-26 19:59:50 +08:00
|
|
|
*/
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(address + 65536 + 32 * sizeof(unsigned long) < regs->sp)) {
|
|
|
|
|
bad_area(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(expand_stack(vma, address))) {
|
|
|
|
|
bad_area(regs, error_code, address);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Ok, we have a good vm_area for this memory access, so
|
|
|
|
|
* we can handle it..
|
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
good_area:
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
write = error_code & PF_WRITE;
|
2009-02-21 02:56:40 +08:00
|
|
|
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
if (unlikely(access_error(error_code, write, vma))) {
|
|
|
|
|
bad_area_access_error(regs, error_code, address);
|
|
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* If for any reason at all we couldn't handle the fault,
|
|
|
|
|
* make sure we exit gracefully rather than endlessly redo
|
2009-02-21 02:56:40 +08:00
|
|
|
* the fault:
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
2009-04-11 00:01:23 +08:00
|
|
|
fault = handle_mm_fault(mm, vma, address, write ? FAULT_FLAG_WRITE : 0);
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2007-07-19 16:47:05 +08:00
|
|
|
if (unlikely(fault & VM_FAULT_ERROR)) {
|
x86: optimise x86's do_page_fault (C entry point for the page fault path)
Impact: cleanup, restructure code to improve assembly
gcc isn't _all_ that smart about spilling registers to stack or reusing
stack slots, even with branch annotations. do_page_fault contained a lot
of functionality, so split unlikely paths into their own functions, and
mark them as noinline just to be sure. I consider this actually to be
somewhat of a cleanup too: the main function now contains about half
the number of lines so the normal path is easier to read, while the error
cases are also nicely split away.
Also, ensure the order of arguments to functions is always the same: regs,
addr, error_code. This can reduce code size a tiny bit, and just looks neater
too.
And add a couple of branch annotations.
Before:
do_page_fault:
subq $360, %rsp #,
After:
do_page_fault:
subq $56, %rsp #,
bloat-o-meter:
add/remove: 8/0 grow/shrink: 0/1 up/down: 2222/-1680 (542)
function old new delta
__bad_area_nosemaphore - 506 +506
no_context - 474 +474
vmalloc_fault - 424 +424
spurious_fault - 358 +358
mm_fault_error - 272 +272
bad_area_access_error - 89 +89
bad_area - 89 +89
bad_area_nosemaphore - 10 +10
do_page_fault 2464 784 -1680
Yes, the total size increases by 542 bytes, due to the extra function calls.
But these will very rarely be called (except for vmalloc_fault) in a normal
workload. Importantly, do_page_fault is less than 1/3rd it's original size,
and touches far less stack.
Existing gotos and branch hints did move a lot of the infrequently used text
out of the fastpath, but that's even further improved after this patch.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-01-20 11:24:26 +08:00
|
|
|
mm_fault_error(regs, error_code, address, fault);
|
|
|
|
|
return;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2009-02-21 02:56:40 +08:00
|
|
|
|
2009-03-13 19:21:34 +08:00
|
|
|
if (fault & VM_FAULT_MAJOR) {
|
2007-07-19 16:47:05 +08:00
|
|
|
tsk->maj_flt++;
|
perf: Do the big rename: Performance Counters -> Performance Events
Bye-bye Performance Counters, welcome Performance Events!
In the past few months the perfcounters subsystem has grown out its
initial role of counting hardware events, and has become (and is
becoming) a much broader generic event enumeration, reporting, logging,
monitoring, analysis facility.
Naming its core object 'perf_counter' and naming the subsystem
'perfcounters' has become more and more of a misnomer. With pending
code like hw-breakpoints support the 'counter' name is less and
less appropriate.
All in one, we've decided to rename the subsystem to 'performance
events' and to propagate this rename through all fields, variables
and API names. (in an ABI compatible fashion)
The word 'event' is also a bit shorter than 'counter' - which makes
it slightly more convenient to write/handle as well.
Thanks goes to Stephane Eranian who first observed this misnomer and
suggested a rename.
User-space tooling and ABI compatibility is not affected - this patch
should be function-invariant. (Also, defconfigs were not touched to
keep the size down.)
This patch has been generated via the following script:
FILES=$(find * -type f | grep -vE 'oprofile|[^K]config')
sed -i \
-e 's/PERF_EVENT_/PERF_RECORD_/g' \
-e 's/PERF_COUNTER/PERF_EVENT/g' \
-e 's/perf_counter/perf_event/g' \
-e 's/nb_counters/nb_events/g' \
-e 's/swcounter/swevent/g' \
-e 's/tpcounter_event/tp_event/g' \
$FILES
for N in $(find . -name perf_counter.[ch]); do
M=$(echo $N | sed 's/perf_counter/perf_event/g')
mv $N $M
done
FILES=$(find . -name perf_event.*)
sed -i \
-e 's/COUNTER_MASK/REG_MASK/g' \
-e 's/COUNTER/EVENT/g' \
-e 's/\<event\>/event_id/g' \
-e 's/counter/event/g' \
-e 's/Counter/Event/g' \
$FILES
... to keep it as correct as possible. This script can also be
used by anyone who has pending perfcounters patches - it converts
a Linux kernel tree over to the new naming. We tried to time this
change to the point in time where the amount of pending patches
is the smallest: the end of the merge window.
Namespace clashes were fixed up in a preparatory patch - and some
stylistic fallout will be fixed up in a subsequent patch.
( NOTE: 'counters' are still the proper terminology when we deal
with hardware registers - and these sed scripts are a bit
over-eager in renaming them. I've undone some of that, but
in case there's something left where 'counter' would be
better than 'event' we can undo that on an individual basis
instead of touching an otherwise nicely automated patch. )
Suggested-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-arch@vger.kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-09-21 18:02:48 +08:00
|
|
|
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, 0,
|
2009-04-08 21:01:33 +08:00
|
|
|
regs, address);
|
2009-03-13 19:21:34 +08:00
|
|
|
} else {
|
2007-07-19 16:47:05 +08:00
|
|
|
tsk->min_flt++;
|
perf: Do the big rename: Performance Counters -> Performance Events
Bye-bye Performance Counters, welcome Performance Events!
In the past few months the perfcounters subsystem has grown out its
initial role of counting hardware events, and has become (and is
becoming) a much broader generic event enumeration, reporting, logging,
monitoring, analysis facility.
Naming its core object 'perf_counter' and naming the subsystem
'perfcounters' has become more and more of a misnomer. With pending
code like hw-breakpoints support the 'counter' name is less and
less appropriate.
All in one, we've decided to rename the subsystem to 'performance
events' and to propagate this rename through all fields, variables
and API names. (in an ABI compatible fashion)
The word 'event' is also a bit shorter than 'counter' - which makes
it slightly more convenient to write/handle as well.
Thanks goes to Stephane Eranian who first observed this misnomer and
suggested a rename.
User-space tooling and ABI compatibility is not affected - this patch
should be function-invariant. (Also, defconfigs were not touched to
keep the size down.)
This patch has been generated via the following script:
FILES=$(find * -type f | grep -vE 'oprofile|[^K]config')
sed -i \
-e 's/PERF_EVENT_/PERF_RECORD_/g' \
-e 's/PERF_COUNTER/PERF_EVENT/g' \
-e 's/perf_counter/perf_event/g' \
-e 's/nb_counters/nb_events/g' \
-e 's/swcounter/swevent/g' \
-e 's/tpcounter_event/tp_event/g' \
$FILES
for N in $(find . -name perf_counter.[ch]); do
M=$(echo $N | sed 's/perf_counter/perf_event/g')
mv $N $M
done
FILES=$(find . -name perf_event.*)
sed -i \
-e 's/COUNTER_MASK/REG_MASK/g' \
-e 's/COUNTER/EVENT/g' \
-e 's/\<event\>/event_id/g' \
-e 's/counter/event/g' \
-e 's/Counter/Event/g' \
$FILES
... to keep it as correct as possible. This script can also be
used by anyone who has pending perfcounters patches - it converts
a Linux kernel tree over to the new naming. We tried to time this
change to the point in time where the amount of pending patches
is the smallest: the end of the merge window.
Namespace clashes were fixed up in a preparatory patch - and some
stylistic fallout will be fixed up in a subsequent patch.
( NOTE: 'counters' are still the proper terminology when we deal
with hardware registers - and these sed scripts are a bit
over-eager in renaming them. I've undone some of that, but
in case there's something left where 'counter' would be
better than 'event' we can undo that on an individual basis
instead of touching an otherwise nicely automated patch. )
Suggested-by: Stephane Eranian <eranian@google.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Paul Mackerras <paulus@samba.org>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-arch@vger.kernel.org>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-09-21 18:02:48 +08:00
|
|
|
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN, 1, 0,
|
2009-04-08 21:01:33 +08:00
|
|
|
regs, address);
|
2009-03-13 19:21:34 +08:00
|
|
|
}
|
2008-01-30 20:33:23 +08:00
|
|
|
|
2009-02-21 05:12:18 +08:00
|
|
|
check_v8086_mode(regs, address, tsk);
|
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
up_read(&mm->mmap_sem);
|
|
|
|
|
}
|
