Commit Graph

105264 Commits

Author SHA1 Message Date
Claudio Cambra
250609353a macosx: Calculate cellFrame min and max X and Y once only in action button cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
3be2b80f0f macosx: Draw title into action button cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
1c7546ae7a macosx: Scale the action button cell image proportionally
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
39fdce85a3 macosx: Draw accent-coloured image in action button cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
9d5db25879 macosx: Draw cell image within action cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
d6c7202f78 macosx: Implement drawing of basic background for action button cell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
af34283ee7 macosx: Add starter VLCLibraryHomeViewActionButtonCell
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
e32c614e86 macosx: Change home view actions view controller into just the view itself
This removes the need for a view controller. Additionally also fixes
some bugs with handling of actions in the buttons

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
dfd4e5a173 macosx: Set up strings on home view action buttons
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
f07bbb0759 macosx: Set height constraint on home view actions view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
eaea49a6e6 macosx: Add outlets for action view buttons
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
d90310ae70 macosx: Add action outlets for home actions view buttons
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
e901bf2062 macosx: Deduplicate adding of custom containers to home view stack view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
bedaaef9ba macosx: Add actions view to home view stack view controller
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
c1e445fe39 macosx: Add convenience init for home view actions view controller
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
ab0e8f141a macosx: Add starter VLCLibraryHomeViewActionsViewController
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
54ce37352a macosx: Implement basic home actions view design
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Claudio Cambra
2eb3878d9d macosx: Add starter VLCLibraryHomeViewActionsView XIB
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-19 06:56:02 +00:00
Fatih Uzunoglu
db55a1497b qt: restore interface window geometry before it is shown
... so that the interface window does not change its size
from the default size the platform window determines to
use.

Currently, the interface window gets resized immediately
after it is shown. This does not make any sense, the
target size should be set before for the window so that
the window is shown appropriately when it becomes visible.
2024-11-19 06:04:24 +00:00
Fatih Uzunoglu
6e136d2346 qt: check for frameless window hint when probing Win11 22H2 window backdrop effect
Backdrop effect needs the interface window to be translucent, as we want the DWM
composited backdrop effect to pass through.

It is additionally required to use `Qt::FramelessWindowHint` for transparent
windows on Windows, otherwise artifacts may occur. Since this flag is explicitly
not used on Windows unlike other platforms, this change effectively means that
the native effect is not going to be used.

It is not clear why `Qt::FramelessWindowHint` is not used on Windows when CSD
is in use, because it is the canonical way of making a QWindow frameless.
2024-11-19 06:04:24 +00:00
Fatih Uzunoglu
96b74dc604 qml: do not override dragStarted() and dragStopped() signal of Flickable
These signals seem to be added long time ago to Flickable but have not
been documented until recently, which explains why such names are used
here.
2024-11-19 05:12:19 +00:00
Fatih Uzunoglu
74c2000010 qt: do not convert rvalue into pointer in ModelRecoveryAgent 2024-11-19 04:39:36 +00:00
Fatih Uzunoglu
7fd98ed1c4 qt: do not serialize model for recovery if it is empty 2024-11-19 04:39:36 +00:00
Fatih Uzunoglu
93ad175b33 qt: return error code in PlaylistController::serialize() 2024-11-19 04:39:36 +00:00
Fatih Uzunoglu
a374c46d0b qml: use window popup for ToolTipExt with Qt 6.8 2024-11-18 15:51:44 +00:00
Fatih Uzunoglu
d17f538062 qml: do not offset the arrow in PointingTooltip when not necessary
Offsetting necessary when the popup is in a separate window, and
can cause issues if tool tip have fade animations.
2024-11-18 15:51:44 +00:00
Fatih Uzunoglu
554ab5d40f qml: calculate height properly in PointingTooltip
Height should take the arrow area into consideration.
2024-11-18 15:51:44 +00:00
Steve Lhomme
d689072f0d win32: thread: don't redefine SetThreadDescription with newer mingw-w64
Eventually the check can go away.
2024-11-18 12:01:59 +00:00
Claudio Cambra
d7576318dc macosx: Do not switch to idle when no more messages present
Prevents text from being shown during hide, instead keep old message

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
2be266ca86 macosx: Add an info image view to replace progress indicator when loading is over in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
60fdf6f08a macosx: Add separator for status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
c85753c55f macosx: Update scroll view constraints in navigation sidebar on changes of status notifier view height
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
79a0b6c1bc macosx: Update navigation sidebar scroll view insets depending on visibility of status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
c6ff665f86 macosx: Show and hide status notifier view in navigation sidebar depending on activation/deactivation
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
eac2b3393c macosx: Clear prior discovery messages when starting/finishing discovery in status notified view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
6b0eaa656b macosx: Define status messages once as properties
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
08e30ee2a5 macosx: Remove message after adding replacement message, keeping remaining count above 0 while updating status
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
df932a3227 macosx: Do not add messages every time discovery progress is emitted
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
5b6dee769b macosx: Emit notifications when messages are added, and cleared, in status view notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
e9a80a6e31 macosx: Add outlets for scroll view and status notifier view in sidebar view controller
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
0d49188295 macosx: Fix multiple and simultaneous loading/loaded library items messages in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
1817e93ff6 macosx: Track individual messages and compound them in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
23e5219fc1 macosx: Access notification.name only once in updateStatus
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
f5c5860c2d macosx: Display long load notifications in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
b4a9d2276c macosx: Present discovery completion messages as transient
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
d3986198f2 macosx: Track items that are currently loading in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
df45819caf macosx: Listen to all VLC notifications in status notifier
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
7ec183e17f macosx: Clarify use of transient messages pertaining to discovery
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
a11bbfa69d macosx: Ensure some messages stay presented in status notifier view
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00
Claudio Cambra
6f13f6cfd6 macosx: Add reference counting system to keep status notifier view active while necessary
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-17 16:40:59 +00:00