mirror of
https://github.com/u-boot/u-boot.git
synced 2024-11-24 20:54:24 +08:00
2ad6e27dcd
On Sunday, June 19, 2011 13:55:13 Ilya Yanok wrote: > On 18.06.2011 23:03, Mike Frysinger wrote: > >> - tools/Makefile put common/env_embedded.o and envcrc.o to object list > >> > >> conditionally. This fixes errors during dependency generation. > > > > pretty sure this breaks board builds. if the only thing this fixes is a > > I'm sorry but I can't see how this can break the builds. Could you > please be more specific? I've tried to build some boards, it actually > works... i might be thinking of a different env_embedded situation. a different problem with your patch to tools/Makefile: you copied the same logic multiple times which means more bitrot. why dont you do something like: > > harmless warning when generating dependency files, then i say ignore it. > > after all, this is how it has always worked in the past and no one really > > cared. > > Yep, they are harmless but they are not warnings but rather scary errors > actually. ;) I think it's better to fix them. i guess my threshold for being scared is a bit higher :p -mike |
||
---|---|---|
.. | ||
bddb | ||
easylogo | ||
env | ||
gdb | ||
imls | ||
logos | ||
scripts | ||
updater | ||
.gitignore | ||
bin2header.c | ||
bmp_logo.c | ||
default_image.c | ||
envcrc.c | ||
fdt_host.h | ||
fit_image.c | ||
gen_eth_addr.c | ||
getline.c | ||
getline.h | ||
img2brec.sh | ||
img2srec.c | ||
imximage.c | ||
imximage.h | ||
inca-swap-bytes.c | ||
jtagconsole | ||
kwbimage.c | ||
kwbimage.h | ||
Makefile | ||
mingw_support.c | ||
mingw_support.h | ||
mkimage.c | ||
mkimage.h | ||
mpc86x_clk.c | ||
ncb.c | ||
netconsole | ||
os_support.c | ||
os_support.h | ||
setlocalversion | ||
ubsha1.c |