mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2024-11-26 13:44:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

efi_loader: check uuid_str_to_bin return value

Browse Source 
Check the uuid_str_to_bin return value, skip the node
if the image-type-id property is wrong format.

Addresses-Coverity-ID: 463145 ("Error handling issues")
Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Masahisa Kojima 2023-07-31 17:53:02 +09:00 committed by Heinrich Schuchardt
parent 405b736e81
commit cd87d2c61c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/efi_loader/efi_firmware.c
View File

@ -159,7 +159,7 @@ static void efi_firmware_get_lsv_from_dtb(u8 image_index,
const fdt32_t *val;
const char *guid_str;
int len, offset, index;
int parent;
int parent, ret;
*lsv = 0;
@ -173,7 +173,11 @@ static void efi_firmware_get_lsv_from_dtb(u8 image_index,
guid_str = fdt_getprop(fdt, offset, "image-type-id", &len);
if (!guid_str)
continue;
uuid_str_to_bin(guid_str, guid.b, UUID_STR_FORMAT_GUID);
ret = uuid_str_to_bin(guid_str, guid.b, UUID_STR_FORMAT_GUID);
if (ret < 0) {
log_warning("Wrong image-type-id format.\n");
continue;
}
val = fdt_getprop(fdt, offset, "image-index", &len);
if (!val)