mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2024-12-02 00:53:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

env: fix crash using default -f -a

Browse Source 
env default -a -f calls env_check_apply on all existing environment
variables with a NULL value for "newval" as a way of cleaning up.
This causes string manipulation functions to crash on most architectures.
So replace a NULL argument with an empty string.

Reported-By: Stefano Babic <sbabic@denx.de>
Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
Tested-by: Stefano Babic <sbabic@denx.de>
This commit is contained in:
Gerlando Falauto 2012-10-05 00:46:10 +00:00 committed by Tom Rini
parent 961c437b6c
commit 7ac80551c4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common/cmd_nvedit.c
View File

@ -215,6 +215,9 @@ int env_check_apply(const char *name, const char *oldval,
{ {
int console = -1; int console = -1;
/* Default value for NULL to protect string-manipulating functions */
newval = newval ? : "";
/* Check for console redirection */ /* Check for console redirection */
if (strcmp(name, "stdin") == 0) if (strcmp(name, "stdin") == 0)
console = stdin; console = stdin;