efi_loader: error handling in read_console()

getc() might return an error code. Avoid an incorrect converison to
Unicode.

This addresses CoverityScan CID 184087.

Reported-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Heinrich Schuchardt 2018-10-02 06:43:38 +02:00 committed by Alexander Graf
parent eee6530ed1
commit 60d7987656

View File

@ -97,12 +97,17 @@ static u8 read_string(void *data)
/**
* read_console() - read byte from console
*
* @src - not used, needed to match interface
* Return: - byte read
* @data - not used, needed to match interface
* Return: - byte read or 0 on error
*/
static u8 read_console(void *data)
{
return getc();
int ch;
ch = getc();
if (ch < 0)
ch = 0;
return ch;
}
int console_read_unicode(s32 *code)