mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2024-11-28 07:03:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

tools: dumpimage: Provide more feedback on error

Browse Source 
The dumpimage utility errors out in a number of places without providing
sufficient feedback to allow the user to easily determine what they have
done wrong. Add addtional error messages to make the cause of the failure
more obvious.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
This commit is contained in:
Martyn Welch 2019-01-26 02:31:50 +00:00 committed by Tom Rini
parent 3c29a56736
commit 57a608e969
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/dumpimage.c
View File

@ -80,6 +80,8 @@ int main(int argc, char **argv)
case 'T':
params.type = genimg_get_type_id(optarg);
if (params.type < 0) {
fprintf(stderr, "%s: Invalid type\n",
params.cmdname);
usage();
}
break;
@ -101,8 +103,10 @@ int main(int argc, char **argv)
}
}
if (optind >= argc)
if (optind >= argc) {
fprintf(stderr, "%s: image file missing\n", params.cmdname);
usage();
}
/* set tparams as per input type_id */
tparams = imagetool_get_type(params.type);
@ -117,8 +121,11 @@ int main(int argc, char **argv)
* as per image type to be generated/listed
*/
if (tparams->check_params) {
if (tparams->check_params(&params))
if (tparams->check_params(&params)) {
fprintf(stderr, "%s: Parameter check failed\n",
params.cmdname);
usage();
}
}
if (params.iflag)