mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2024-12-05 02:23:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

getchar(): Correct usage

Browse Source 
The function getchar() returns an 'int' and not a 'char'. Coverity notes
that "Assigning the return value of getchar to char ... truncates its value."
and so for the most part we can resolve this easily by using 'int' as
intended, and often used throughout the codebase. A few places are not
so simple and would require further re-architecting of the code in order
to change this, so we leave them be.

Signed-off-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Tom Rini 2024-01-09 17:57:16 -05:00
parent bded9f13b2
commit 21a2c129ad
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/load.c
View File

@ -230,7 +230,7 @@ static ulong load_serial(long offset)
static int read_record(char *buf, ulong len)
{
char *p;
char c;
int c;
--len; /* always leave room for terminating '\0' byte */
@ -827,7 +827,7 @@ static void handle_send_packet(int n)
/* k_recv receives a OS Open image file over kermit line */
static int k_recv(void)
{
char new_char;
int new_char;
char k_state, k_state_saved;
int sum;
int done;

2
common/cli_readline.c
View File

@ -540,7 +540,7 @@ static int cread_line_simple(const char *const prompt, char *p)
int n = 0; /* buffer index */
int plen = 0; /* prompt length */
int col; /* output column cnt */
char c;
int c;
/* print prompt */
if (prompt) {