usb: ohci: Make usage of generic_{setup,shutdown}_phy() helpers

Replace ohci_setup_phy() and ohci_shutdown_phy () by respectively
generic_setup_phy() and generic_shutdown_phy().

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
This commit is contained in:
Patrice Chotard 2022-09-06 08:15:27 +02:00 committed by Marek Vasut
parent 84e561407a
commit 10005004db

View File

@ -23,56 +23,6 @@ struct generic_ohci {
int reset_count; /* number of reset in reset list */ int reset_count; /* number of reset in reset list */
}; };
static int ohci_setup_phy(struct udevice *dev, int index)
{
struct generic_ohci *priv = dev_get_priv(dev);
int ret;
ret = generic_phy_get_by_index(dev, index, &priv->phy);
if (ret) {
if (ret != -ENOENT) {
dev_err(dev, "failed to get usb phy\n");
return ret;
}
} else {
ret = generic_phy_init(&priv->phy);
if (ret) {
dev_dbg(dev, "failed to init usb phy\n");
return ret;
}
ret = generic_phy_power_on(&priv->phy);
if (ret) {
dev_dbg(dev, "failed to power on usb phy\n");
return generic_phy_exit(&priv->phy);
}
}
return 0;
}
static int ohci_shutdown_phy(struct udevice *dev)
{
struct generic_ohci *priv = dev_get_priv(dev);
int ret = 0;
if (generic_phy_valid(&priv->phy)) {
ret = generic_phy_power_off(&priv->phy);
if (ret) {
dev_dbg(dev, "failed to power off usb phy\n");
return ret;
}
ret = generic_phy_exit(&priv->phy);
if (ret) {
dev_dbg(dev, "failed to power off usb phy\n");
return ret;
}
}
return 0;
}
static int ohci_usb_probe(struct udevice *dev) static int ohci_usb_probe(struct udevice *dev)
{ {
struct ohci_regs *regs = dev_read_addr_ptr(dev); struct ohci_regs *regs = dev_read_addr_ptr(dev);
@ -135,7 +85,7 @@ static int ohci_usb_probe(struct udevice *dev)
goto clk_err; goto clk_err;
} }
err = ohci_setup_phy(dev, 0); err = generic_setup_phy(dev, &priv->phy, 0);
if (err) if (err)
goto reset_err; goto reset_err;
@ -146,7 +96,7 @@ static int ohci_usb_probe(struct udevice *dev)
return 0; return 0;
phy_err: phy_err:
ret = ohci_shutdown_phy(dev); ret = generic_shutdown_phy(&priv->phy);
if (ret) if (ret)
dev_err(dev, "failed to shutdown usb phy\n"); dev_err(dev, "failed to shutdown usb phy\n");
@ -171,7 +121,7 @@ static int ohci_usb_remove(struct udevice *dev)
if (ret) if (ret)
return ret; return ret;
ret = ohci_shutdown_phy(dev); ret = generic_shutdown_phy(&priv->phy);
if (ret) if (ret)
return ret; return ret;