mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2025-01-19 01:03:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

x86: Update the MP constants to avoid conflicts

Browse Source 
These constants conflict with error codes returned by the MP
implementation when something is wrong. In particular, mp_first_cpu()
returns MP_SELECT_BSP when running without multiprocessing enabled.
Since this is -2, it is interpreted as an error by callers, which
expect a positive CPU number for the first CPU.

Correct this by using a different range for the pre-defined CPU
numbers, above zero and out of the range of possible CPU values. For
now it is safe to assume there are no more than 64K CPUs.

This fixes the 'mtrr' command when CONFIG_SMP is not enabled.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
This commit is contained in:
Simon Glass 2021-06-27 17:51:02 -06:00 committed by Bin Meng
parent 92873f83d1
commit 0f5ca1d1f1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/x86/include/asm/mp.h
View File

@ -10,18 +10,22 @@
#include <asm/atomic.h>
#include <asm/cache.h>
#include <linux/bitops.h>
struct udevice;
enum {
/* Indicates that the function should run on all CPUs */
MP_SELECT_ALL = -1,
/*
* Indicates that the function should run on all CPUs. We use a large
* number, above the number of real CPUs we expect to find.
*/
MP_SELECT_ALL = BIT(16),
/* Run on boot CPUs */
MP_SELECT_BSP = -2,
MP_SELECT_BSP,
/* Run on non-boot CPUs */
MP_SELECT_APS = -3,
MP_SELECT_APS,
};
typedef int (*mp_callback_t)(struct udevice *cpu, void *arg);