mirrors/u-boot
0
0
Fork 0
mirror of https://github.com/u-boot/u-boot.git synced 2024-12-14 23:33:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

cmd: efidebug: fix a build error in show_efi_boot_opt()

Browse Source 
I detected the following error in sandbox with Clang on Travis CI:
    +cmd/efidebug.c:703:15: error: result of comparison of constant
     9223372036854775822 with expression of type 'int' is always false
     [-Werror,-Wtautological-constant-out-of-range-compare]
    +        else if (ret == EFI_NOT_FOUND)
    +                 ~~~ ^  ~~~~~~~~~~~~~

Simply changing a type of 'ret' to efi_status_t will fix this error.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
AKASHI Takahiro 2019-11-26 10:11:22 +09:00 committed by Heinrich Schuchardt
parent 1297989804
commit 0bffb8c46b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/efidebug.c
View File

@ -684,7 +684,7 @@ static void show_efi_boot_opt(int id)
efi_guid_t guid; efi_guid_t guid;
void *data = NULL; void *data = NULL;
efi_uintn_t size; efi_uintn_t size;
int ret; efi_status_t ret;
sprintf(var_name, "Boot%04X", id); sprintf(var_name, "Boot%04X", id);
p = var_name16; p = var_name16;
@ -693,7 +693,7 @@ static void show_efi_boot_opt(int id)
size = 0; size = 0;
ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL)); ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL));
if (ret == (int)EFI_BUFFER_TOO_SMALL) { if (ret == EFI_BUFFER_TOO_SMALL) {
data = malloc(size); data = malloc(size);
ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size,
data)); data));