From ac79cfc2a46b5904236a59a4c990d7b8926ce70d Mon Sep 17 00:00:00 2001 From: Andre Heider Date: Thu, 17 Sep 2020 08:52:00 +0200 Subject: [PATCH 1/5] treewide: configs: get rid of unused CONFIG_DEFAULT_CONSOLE These are all unused. Signed-off-by: Andre Heider Signed-off-by: Heinrich Schuchardt Acked-by: Krzysztof Kozlowski Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- include/configs/arndale.h | 2 -- include/configs/espresso7420.h | 3 --- include/configs/origen.h | 5 ----- include/configs/peach-pi.h | 3 --- include/configs/peach-pit.h | 3 --- include/configs/smdk5250.h | 2 -- include/configs/smdk5420.h | 5 ----- include/configs/smdkv310.h | 2 -- include/configs/snow.h | 2 -- include/configs/spring.h | 2 -- 10 files changed, 29 deletions(-) diff --git a/include/configs/arndale.h b/include/configs/arndale.h index 79e7418b9bf..5109f7de534 100644 --- a/include/configs/arndale.h +++ b/include/configs/arndale.h @@ -18,8 +18,6 @@ #define CONFIG_EXYNOS_SPL /* Miscellaneous configurable options */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" - #define CONFIG_IRAM_STACK 0x02050000 #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_STACK diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h index 5aeb009f030..2495db93f8d 100644 --- a/include/configs/espresso7420.h +++ b/include/configs/espresso7420.h @@ -18,9 +18,6 @@ #define CONFIG_SPL_STACK CONFIG_IRAM_END #define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_END -/* select serial console configuration */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - /* DRAM Memory Banks */ #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */ diff --git a/include/configs/origen.h b/include/configs/origen.h index 24b0338deb3..8a0e145c76c 100644 --- a/include/configs/origen.h +++ b/include/configs/origen.h @@ -24,11 +24,6 @@ #define CONFIG_MACH_TYPE MACH_TYPE_ORIGEN -/* select serial console configuration */ - -/* Console configuration */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - #define CONFIG_SYS_MEM_TOP_HIDE (1 << 20) /* ram console */ #define CONFIG_SYS_MONITOR_BASE 0x00000000 diff --git a/include/configs/peach-pi.h b/include/configs/peach-pi.h index a732e06a991..ba82aaf6537 100644 --- a/include/configs/peach-pi.h +++ b/include/configs/peach-pi.h @@ -23,9 +23,6 @@ #define CONFIG_SYS_SDRAM_BASE 0x20000000 #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_IRAM_TOP - 0x800) -/* select serial console configuration */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - /* Display */ #ifdef CONFIG_LCD #define CONFIG_EXYNOS_FB diff --git a/include/configs/peach-pit.h b/include/configs/peach-pit.h index 6c5960cb8da..16fb2f3a0e3 100644 --- a/include/configs/peach-pit.h +++ b/include/configs/peach-pit.h @@ -23,9 +23,6 @@ #define CONFIG_SYS_SDRAM_BASE 0x20000000 #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_IRAM_TOP - 0x800) -/* select serial console configuration */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - /* DRAM Memory Banks */ #define SDRAM_BANK_SIZE (512UL << 20UL) /* 512 MB */ diff --git a/include/configs/smdk5250.h b/include/configs/smdk5250.h index 82251b36150..3af13673f2a 100644 --- a/include/configs/smdk5250.h +++ b/include/configs/smdk5250.h @@ -18,6 +18,4 @@ #define CONFIG_BOARD_COMMON -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - #endif /* __CONFIG_SMDK_H */ diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h index 14ec099d53b..d06dfe43a23 100644 --- a/include/configs/smdk5420.h +++ b/include/configs/smdk5420.h @@ -24,11 +24,6 @@ #define CONFIG_SYS_SDRAM_BASE 0x20000000 #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_IRAM_TOP - 0x800) -/* select serial console configuration */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - /* USB */ #define CONFIG_USB_XHCI_EXYNOS diff --git a/include/configs/smdkv310.h b/include/configs/smdkv310.h index b970e4bc80e..ede057322f5 100644 --- a/include/configs/smdkv310.h +++ b/include/configs/smdkv310.h @@ -36,8 +36,6 @@ #define CONFIG_BOOTCOMMAND "fatload mmc 0 40007000 uImage; bootm 40007000" -/* Miscellaneous configurable options */ -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" /* memtest works on */ #define CONFIG_SYS_LOAD_ADDR (CONFIG_SYS_SDRAM_BASE + 0x3E00000) diff --git a/include/configs/snow.h b/include/configs/snow.h index c546a5a6d07..c082b2d82d8 100644 --- a/include/configs/snow.h +++ b/include/configs/snow.h @@ -17,6 +17,4 @@ #define CONFIG_BOARD_COMMON -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - #endif /* __CONFIG_SNOW_H */ diff --git a/include/configs/spring.h b/include/configs/spring.h index 272622a5ed9..0b052453a51 100644 --- a/include/configs/spring.h +++ b/include/configs/spring.h @@ -12,6 +12,4 @@ #define CONFIG_BOARD_COMMON -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" - #endif /* __CONFIG_SPRING_H */ From 9c04265f76320b372f41dcc0aa34a0660b2e96da Mon Sep 17 00:00:00 2001 From: Andre Heider Date: Thu, 17 Sep 2020 08:52:01 +0200 Subject: [PATCH 2/5] treewide: configs: fold CONFIG_DEFAULT_CONSOLE In prepartion to remove CONFIG_DEFAULT_CONSOLE, fold the current users. Signed-off-by: Andre Heider Acked-by: Krzysztof Kozlowski Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- include/configs/odroid.h | 7 +------ include/configs/odroid_xu3.h | 6 +----- include/configs/s5p_goni.h | 8 +------- include/configs/s5pc210_universal.h | 7 +------ include/configs/trats.h | 5 +---- include/configs/trats2.h | 7 +------ 6 files changed, 6 insertions(+), 34 deletions(-) diff --git a/include/configs/odroid.h b/include/configs/odroid.h index befb9f9aa15..1367d13891a 100644 --- a/include/configs/odroid.h +++ b/include/configs/odroid.h @@ -33,12 +33,7 @@ #include -/* select serial console configuration */ - -/* Console configuration */ - #define CONFIG_BOOTCOMMAND "run distro_bootcmd ; run autoboot" -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE) @@ -149,7 +144,7 @@ "elif test -e mmc ${mmcbootdev} uImage; then; " \ "run boot_uimg;" \ "fi;\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC1,115200n8\0" \ "mmcbootdev=0\0" \ "mmcbootpart=1\0" \ "mmcrootdev=0\0" \ diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index 564319c2311..0c86196152f 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -14,8 +14,6 @@ #define CONFIG_SYS_SDRAM_BASE 0x40000000 -/* select serial console configuration */ - #define TZPC_BASE_OFFSET 0x10000 #define SDRAM_BANK_SIZE (256UL << 20UL) /* 256 MB */ @@ -25,8 +23,6 @@ #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR - 0x1000000) -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" - /* USB */ #define CONFIG_USB_EHCI_EXYNOS @@ -97,7 +93,7 @@ MEM_LAYOUT_ENV_SETTINGS \ BOOTENV \ "rootfstype=ext4\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC2,115200n8\0" \ "fdtfile=exynos5422-odroidxu3.dtb\0" \ "board_name=odroidxu3\0" \ "mmcbootdev=0\0" \ diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h index d6d07a95b68..9688bdc4c03 100644 --- a/include/configs/s5p_goni.h +++ b/include/configs/s5p_goni.h @@ -34,10 +34,6 @@ /* Size of malloc() pool before and after relocation */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + (80 << 20)) -/* - * select serial console configuration - */ - /* MMC */ #define SDHCI_MAX_HOSTS 4 @@ -85,8 +81,6 @@ #define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" - #define CONFIG_RAMDISK_BOOT "root=/dev/ram0 rw rootfstype=ext4" \ " ${console} ${meminfo}" @@ -131,7 +125,7 @@ "bootchart=set opts init=/sbin/bootchartd; run bootcmd\0" \ "verify=n\0" \ "rootfstype=ext4\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC2,115200n8\0" \ "meminfo=mem=80M mem=256M@0x40000000 mem=128M@0x50000000\0" \ "loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x30007FC0 uImage\0" \ "mmcdev=0\0" \ diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h index da6ed975c36..e60c7c7eddb 100644 --- a/include/configs/s5pc210_universal.h +++ b/include/configs/s5pc210_universal.h @@ -22,12 +22,7 @@ #define SDRAM_BANK_SIZE (256 << 20) /* 256 MB */ -/* select serial console configuration */ - -/* Console configuration */ - #define CONFIG_BOOTCOMMAND "run mmcboot" -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC1,115200n8\0" #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE) @@ -102,7 +97,7 @@ "mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \ "verify=n\0" \ "rootfstype=ext4\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC1,115200n8\0" \ "mtdparts=" CONFIG_MTDPARTS_DEFAULT \ "mbrparts=" MBRPARTS_DEFAULT \ "meminfo=crashkernel=32M@0x50000000\0" \ diff --git a/include/configs/trats.h b/include/configs/trats.h index 3202627a7db..3d85792f0c0 100644 --- a/include/configs/trats.h +++ b/include/configs/trats.h @@ -29,12 +29,9 @@ /* memtest works on */ #define CONFIG_SYS_LOAD_ADDR (CONFIG_SYS_SDRAM_BASE + 0x4800000) -/* select serial console configuration */ - #define CONFIG_MACH_TYPE MACH_TYPE_TRATS #define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE) @@ -112,7 +109,7 @@ "mmcoops=mmc read 0 0x40000000 0x40 8; md 0x40000000 0x400\0" \ "verify=n\0" \ "rootfstype=ext4\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC2,115200n8\0" \ "meminfo=crashkernel=32M@0x50000000\0" \ "nfsroot=/nfsroot/arm\0" \ "bootblock=" CONFIG_BOOTBLOCK "\0" \ diff --git a/include/configs/trats2.h b/include/configs/trats2.h index 14549dd1a0c..3f7f5ce7604 100644 --- a/include/configs/trats2.h +++ b/include/configs/trats2.h @@ -27,12 +27,7 @@ /* memtest works on */ #define CONFIG_SYS_LOAD_ADDR (CONFIG_SYS_SDRAM_BASE + 0x3E00000) -/* select serial console configuration */ - -/* Console configuration */ - #define CONFIG_BOOTCOMMAND "run autoboot" -#define CONFIG_DEFAULT_CONSOLE "console=ttySAC2,115200n8\0" #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_LOAD_ADDR \ - GENERATED_GBL_DATA_SIZE) @@ -95,7 +90,7 @@ "boottrace=setenv opts initcall_debug; run bootcmd\0" \ "verify=n\0" \ "rootfstype=ext4\0" \ - "console=" CONFIG_DEFAULT_CONSOLE \ + "console=console=ttySAC2,115200n8\0" \ "kernelname=uImage\0" \ "loaduimage=ext4load mmc ${mmcdev}:${mmcbootpart} 0x40007FC0 " \ "${kernelname}\0" \ From 023951038f8871abaf7e9fa4c92d23a29e55d030 Mon Sep 17 00:00:00 2001 From: Andre Heider Date: Thu, 17 Sep 2020 08:52:02 +0200 Subject: [PATCH 3/5] Remove whitelist entry CONFIG_DEFAULT_CONSOLE There're no users left. Signed-off-by: Andre Heider Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- scripts/config_whitelist.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index 12f1209aa8f..85a3192e77f 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -290,7 +290,6 @@ CONFIG_DEBUG_UART_LINFLEXUART CONFIG_DEBUG_WRITECOUNT CONFIG_DEEP_SLEEP CONFIG_DEFAULT -CONFIG_DEFAULT_CONSOLE CONFIG_DEFAULT_IMMR CONFIG_DESIGNWARE_ETH CONFIG_DEVELOP From c87afd39d1f6c0e40e1514c479ffa164f43718d8 Mon Sep 17 00:00:00 2001 From: Andre Heider Date: Thu, 17 Sep 2020 08:52:03 +0200 Subject: [PATCH 4/5] configs: smdkv310: get rid of unused EXYNOS4_DEFAULT_UART_OFFSET Unused. Signed-off-by: Andre Heider Acked-by: Krzysztof Kozlowski Reviewed-by: Simon Glass Signed-off-by: Minkyu Kang --- include/configs/smdkv310.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/smdkv310.h b/include/configs/smdkv310.h index ede057322f5..fc2f6ecf6be 100644 --- a/include/configs/smdkv310.h +++ b/include/configs/smdkv310.h @@ -27,9 +27,6 @@ #define S5P_CHECK_DIDLE 0xBAD00000 #define S5P_CHECK_LPA 0xABAD0000 -/* select serial console configuration */ -#define EXYNOS4_DEFAULT_UART_OFFSET 0x010000 - /* MMC SPL */ #define CONFIG_SKIP_LOWLEVEL_INIT #define COPY_BL2_FNPTR_ADDR 0x00002488 From 8efad326ff33dd0262ce84d73aaced69f4b86c01 Mon Sep 17 00:00:00 2001 From: Jaehoon Chung Date: Thu, 22 Oct 2020 15:56:57 +0900 Subject: [PATCH 5/5] samsung: common: remove the duplicated stdio print message Remove duplicated stdio print message. It's already displayed in common/console.c. Loading Environment from MMC... OK In: serial Out: serial Err: serial Model: Odroid XU3/XU4/HC1/HC2 based on Exynos5422 Type: xu3 In: serial Out: serial Err: serial Signed-off-by: Jaehoon Chung Signed-off-by: Minkyu Kang --- board/samsung/common/board.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/samsung/common/board.c b/board/samsung/common/board.c index 752d84ec05c..470531fdbb2 100644 --- a/board/samsung/common/board.c +++ b/board/samsung/common/board.c @@ -304,7 +304,6 @@ int board_late_init(void) int mmcbootdev = get_boot_mmc_dev(); char mmcbootdev_str[16]; - stdio_print_current_devices(); ret = uclass_first_device_err(UCLASS_CROS_EC, &dev); if (ret && ret != -ENODEV) { /* Force console on */