mirror of
https://github.com/the-tcpdump-group/tcpdump.git
synced 2024-11-24 02:23:27 +08:00
63610e417b
bittok2str_internal() used to match on a single walking 1, so a bitmap token that had more than one bit set would never "match all" or "match any". Replace the bit-walking loop with a single bitwise test, that's faster and it provides "match all" for multiple-bit tokens if required. Also a 0 token would always match a 0 value, which makes no sense in bitmaps, so fix a 0 token to never match. Update the comment and fixup some indentation. This change had immediately chased a bug out of print-udld.c, where the tokens were wrong in udld_flags_values[]. Fix that, list the MBZ bits and rename the array for clarity. Update output for two tests. In the course of this debugging it became clear that in print-aoe.c I got both the tokens and the labels wrong in aoev1_aflag_str[]. Fix that, rename the listed MBZ bits for brevity and rename the array for clarity. Update output for one test.
4 lines
190 B
Plaintext
4 lines
190 B
Plaintext
1 06:58:21.1048579 AoE length 18, Ver 1, Flags: [Response, MBZ-1, MBZ-0]
|
|
Major: 0x40f6, Minor: 0x02, Command: Reserve/Release, Tag: 0x01010101
|
|
RCmd: Set reserve list, NMacs: 1 [|aoe]
|