Commit Graph

7071 Commits

Author SHA1 Message Date
Denis Ovsienko
eaaa2f168a Lose an unused variable in print-snmp.c.
./print-snmp.c:1200:17: warning: variable 'ind' set but not used
  [-Wunused-but-set-variable]

clang version 15.0.1
Target: aarch64-portbld-freebsd13.1
2022-12-18 21:38:58 +00:00
Francois-Xavier Le Bail
baee15d316 PTP: Replace some ' ,' with ', ' (style)
[skip ci]
2022-12-12 14:53:28 +01:00
Francois-Xavier Le Bail
d8b6f680b4 PTP: Remove an unused macro
Moreover:
Remove extra blank lines.

[skip ci]
2022-12-12 14:36:30 +01:00
Francois-Xavier Le Bail
e4b31af5a5 Fix a typo
[skip ci]
2022-12-11 20:04:47 +01:00
Francois-Xavier Le Bail
02a09dc8d3 Makefile.in: Add "make -s install" in the releasecheck target 2022-12-11 19:03:19 +01:00
Denis Ovsienko
d98b1777c7 Cirrus CI: Switch macOS to AArch64. [skip appveyor]
Same as in tcpslice and libpcap.
2022-12-10 16:11:58 +00:00
Francois-Xavier Le Bail
6037720bd5 CHANGES: Add a main-only change
[skip ci]
2022-12-08 14:41:42 +01:00
Donatas Abraitis
6657094214 bgp: Add support for BGP Role capabilty and OTC attribute
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-12-08 13:38:24 +00:00
Francois-Xavier Le Bail
e828b9a87a CHANGES: Add a main-only change 2022-11-30 13:42:50 +01:00
Francois-Xavier Le Bail
625657ada8 CI: Introduce and use TCPDUMP_CMAKE_TAINTED
The new environment variable provides means to declare all or some libpcap
cmake run of a specific environment (CI or a working copy) as tainted.
Add explicit conditions to exempt the cmake run that emit warnings
now and request the compiler to treat warnings as errors *iff* the cmake
run is not tainted. This way if a cmake run that is warning-free now
degrades later, CI will fail it.

The treat warnings as errors cmake option used is:
-Werror=dev
       Make developer warnings errors.

       Make  warnings  that  are  meant  for  the  author of the CMake-
       Lists.txt files errors. By default this will also turn on depre-
       cated warnings as errors.
2022-11-30 12:05:58 +01:00
Francois-Xavier Le Bail
047714a6b0 Cirrus CI: Add the "make releasecheck" command in the Linux task
There is no need to add this command in all tasks.
2022-11-26 09:10:33 +01:00
Francois-Xavier Le Bail
9fee4c6280 Makefile.in: Add the releasecheck target
This change do, in a fresh directory from a release archive:
1) a "configure --enable-smb" and build,
2) a "cmake -DENABLE_SMB=yes" and build.

It may allow to find some necessary files missing in the release archive.

Define CMAKE_MESSAGE_LOG_LEVEL=NOTICE to minimize the cmake output.
Define CMAKE_RULE_MESSAGES=OFF to minimize the make output in cmake case.

[skip ci]
2022-11-26 09:10:33 +01:00
Francois-Xavier Le Bail
9b05cc18ec cmake: Update the minimum required version to 2.8.12 (except Windows)
Windows minimum required is already 3.12.

This change avoids this warning:
CMake Deprecation Warning at CMakeLists.txt:7 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

(Same as in libpcap.)
2022-11-25 15:56:21 +01:00
Francois-Xavier Le Bail
fb4a8f6fb2 CREDITS: Add authors of changes backported to 4.99.2
[skip ci]
2022-11-21 21:56:39 +01:00
Francois-Xavier Le Bail
3aa9af0af4 CHANGES: Add more changes backported to 4.99.2
[skip ci]
2022-11-07 10:22:32 +01:00
Francois-Xavier Le Bail
8d5c919867 CHANGES: Move a change backported to 4.99
[skip ci]
2022-11-05 13:35:04 +01:00
Francois-Xavier Le Bail
9c53688beb CHANGES: Add a change backported to 4.99 2022-11-02 21:48:58 +01:00
Francois-Xavier Le Bail
a268f5d657 Remove the release candidate rcX targets
These tricky targets used "autoreconf -f" (via "make releasetar") and
they changed the VERSION and configure files locally.

If building a release candidate tar archive is needed, it's better to:
Update VERSION with rcX suffix and configure via "autoreconf -f",
commit them, add a tag and build the archive via "make releasetar".
It should display: Archive build from tag tcpdump-...rcX.

Note: the "autoreconf -f" command changes the configure file in an
uncontrolled way (runstatedir, #define LARGE_OFF_T, etc.) depending on
the autoconf version.
It is necessary to choose the parts that will be added in the commit
with "git add -i".

This is a follow-up to c378c2a04c.

[skip ci]
2022-10-31 17:20:18 +01:00
Denis Ovsienko
dd7d97a439 Refine the change log. [skip ci]
In the 4.99.2 section fix a typo and move changes that are not specific
to a particular protocol to the "source code" sub-section.
2022-10-30 23:17:08 +00:00
Denis Ovsienko
5be14bf712 Add a change log entry for CMake RPATH bug fix. [skip ci] 2022-10-30 13:44:24 +00:00
Denis Ovsienko
e0a01560dd doc: Update README.NetBSD.md after commit dcfed11. [skip ci] 2022-10-30 12:36:18 +00:00
Francois-Xavier Le Bail
c378c2a04c Use "git archive" for the "make releasetar" process
Use the release tag if it exists or use HEAD.

Remove the "autoreconf -f" command, because it changes the configure file
locally in an uncontrolled way (runstatedir, #define LARGE_OFF_T, etc.)
depending on the autoconf version. This command is run in the release
process before a commit and we can choose the parts that will be added
in the commit.

Note:
The following target (rcX) must be updated ou removed in a next step
because it was using "autoreconf -f" (via "make releasetar") and it
changes the VERSION and configure files locally.

This change
1) Ensures that we only release files from tag/HEAD, not locally
   modified ones.
2) Avoids disclosing personal data such as the username/group of the
   local user.
3) Puts by default a umask of 0002, which turns off the world write bit
   on files in the archive.
4) Avoids problems on some OSes (no more tar, Git builtin tar.gz
   handling).
2022-10-28 18:34:55 +02:00
Denis Ovsienko
7047194eaf man: Lose an excess newline in tcpdump(1).
This improves the derived HTML version and has no effect on the plain
text version, as far as I can tell.

[skip ci]
2022-10-19 21:40:50 +01:00
Francois-Xavier Le Bail
9ab792b713 CONTRIBUTING: Add some tags 2022-10-17 14:51:30 +02:00
Francois-Xavier Le Bail
51d9642c0a CONTRIBUTING.md: Add information about the instrumentation of functions 2022-10-17 14:25:54 +02:00
Francois-Xavier Le Bail
f90ee3e31b Rename the suffix of a pcapng test file to .pcapng 2022-10-16 07:55:42 +02:00
Francois-Xavier Le Bail
aeb956f1f0 CHANGES: Add a change backported to 4.99 2022-10-14 06:34:22 +02:00
Charles (Chas) Williams
c8a59b1d2a PTP: fix printing of the correction fields
The nanosecond part of the correction field is 48 bits and the
sub-nanosecond part is 16 bits.
2022-10-14 04:18:59 +00:00
Francois-Xavier Le Bail
fd4c7cc164 CHANGES: Add a change backported to 4.99
[skip ci]
2022-10-12 08:30:22 +02:00
Francois-Xavier Le Bail
a2bbbe3888 NFS: Fix the format for printing an unsigned int 2022-10-10 09:41:59 +02:00
Francois-Xavier Le Bail
e5538f78f8 CHANGES: Add a main-only change 2022-10-07 14:08:34 +02:00
Donatas Abraitis
13e98190d0 bgp: Add Origin Validation State extended community
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
2022-10-07 12:06:38 +00:00
Francois-Xavier Le Bail
c32a447935 BGP: Update an error message
From:
    [invalid total segments len 7]
To:
    [total segments length 7 != N x 6] (invalid)
2022-10-06 18:55:58 +02:00
Francois-Xavier Le Bail
33f0eb14e6 CHANGES: Add a main-only change 2022-10-05 18:28:57 +02:00
Colin Sames
97bae7d71c BGP: add dissector for BGPsec capability and path
BGPsec is specified in RFC8205. It adds a path attribute to BGP update
messages and a capability to BGP open messages.

tests: add pcap for BGPsec test
2022-10-03 16:57:06 +00:00
Guy Harris
2a6eaf16e1 configure: use pcap-config --static-pcap-only if available.
If we're linking with a libpcap in ../libpcap*, it's static, but we only
need to link with the libraries on wich it immediately depends, we don't
need to link with the libraries on which those libraries depend, etc..

So, if ../libpcap*/pcap-config supports --static-pcap-only, use that.
2022-09-30 16:29:34 -07:00
Francois-Xavier Le Bail
e91ca695c3 Remove a trailing space
[skip ci]
2022-09-30 08:54:19 +02:00
Francois-Xavier Le Bail
1b02732086 Update config.{guess,sub}, timestamps 2022-08-01
From repository git://git.savannah.gnu.org/config.git
2022-09-26 14:59:25 +02:00
Guy Harris
d58b413e83 cmake: expand a comment. [skip ci]
The requirement for setting the run-time path in an executable is not
unique to NetBSD; it also appears in the other BSDs, Linux, and Solaris.
2022-09-26 00:40:50 -07:00
Guy Harris
dcfed11c0b cmake: prevent stripping of the rpath on installation.
This should fix issue #1008.
2022-09-25 14:35:38 -07:00
Denis Ovsienko
77476409d9 Update some references to README files. [skip ci] 2022-09-24 12:46:55 +01:00
Denis Ovsienko
54e8329421 doc: Add a README file for NetBSD.
[skip ci]
2022-09-24 12:33:58 +01:00
Guy Harris
7e98b1916b CHANGES: add a change backported to 4.99. [skip ci] 2022-09-19 00:37:22 -07:00
Sam James
6de7b5fa70 configure.ac: fix configure tests broken with Clang 15 (implicit function declarations)
Clang 15 makes implicit function declarations fatal by default which
leads to some of tcpdump's configure tests silently failing/returning
the wrong result.

This adds the needed #includes to various tests for the functions used,
resolving the following errors:
```
net-analyzer/tcpdump-4.99.1/clang15.log:47:error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
net-analyzer/tcpdump-4.99.1/clang15.log:51:error: call to undeclared library function 'strcmp' with type 'int (const char *, const char *)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
net-analyzer/tcpdump-4.99.1/clang15.log:55:error: call to undeclared library function 'sscanf' with type 'int (const char *restrict, const char *restrict, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
net-analyzer/tcpdump-4.99.1/clang15.log:68:error: call to undeclared library function 'memset' with type 'void *(void *, int, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
net-analyzer/tcpdump-4.99.1/clang15.log:112:error: call to undeclared function 'ether_ntohost'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
net-analyzer/tcpdump-4.99.1/clang15.log:115:error: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
```

Signed-off-by: Sam James <sam@gentoo.org>
2022-09-19 00:28:58 -07:00
Francois-Xavier Le Bail
0b6f8abfb6 CHANGES: Add a change backported to 4.99
[skip ci]
2022-09-13 08:37:08 +02:00
Nicholas Reilly
425359f7b8 ICMPv6: Fix the Node Information flags
Don't use htons() when defining the constants because the flags
field is already eventually swapped by fetching with GET_BE_U_2().
Remove unused flags NI_SUPTYPE_FLAG_COMPRESS and NI_FQDN_FLAG_VALIDTTL.
Add a test file with various NI_NODEADDR_FLAG* flags.
2022-09-13 06:32:18 +00:00
Francois-Xavier Le Bail
6d7700936c CHANGES: Add some main-only changes
[skip ci]
2022-09-12 18:10:12 +02:00
Francois-Xavier Le Bail
9aa62d9532 CHANGES: Add some main-only changes
[skip ci]
2022-09-11 20:51:26 +02:00
Francois-Xavier Le Bail
60429463aa CHANGES: Add some changes backported to 4.99
[skip ci]
2022-09-11 20:43:34 +02:00
Francois-Xavier Le Bail
7be4868a41 CHANGES: Add a change backported to 4.99
[skip ci]
2022-09-11 15:38:36 +02:00