Commit Graph

5558 Commits

Author SHA1 Message Date
Francois-Xavier Le Bail
dc8f136aff Travis CI: Add debug infos
Add a folded 'cat Makefile' (without the mkdep part for autotools).
Add a folded 'cat config.h'.
Add a folded 'cat config.log' (for autotools).

The 'sleep 10' command is a workaround for a display problem on osx.
2019-03-21 16:41:44 +01:00
Francois-Xavier Le Bail
e96aba9a90 LMP: Fix a loop for undefined behavior at runtime
The error was:
print-lmp.c:1132:13: runtime error: unsigned integer overflow: 249 - 516
cannot be represented in type 'unsigned int'

Update the output of a test accordingly.
2019-03-20 21:29:00 +01:00
Francois-Xavier Le Bail
2bdc409a7e LMP: Rename a variable
Use 'length' as in most similar cases.
2019-03-20 14:14:42 +01:00
Francois-Xavier Le Bail
f6156d7d1d PPP: Update two error messages
Update the output of a test accordingly.
2019-03-20 13:49:53 +01:00
Francois-Xavier Le Bail
8270847a43 RIP: Update two error messages
Update the output of a test accordingly.
2019-03-20 13:49:53 +01:00
Francois-Xavier Le Bail
07268a08a0 Bluetooth: Print the protocol name 2019-03-19 14:53:13 +01:00
Francois-Xavier Le Bail
1fabc59c13 Add the nd_print_protocol() function
Use the ndo->ndo_protocol field to print the protocol name.
2019-03-19 14:50:52 +01:00
Francois-Xavier Le Bail
9eabb84a47 Squelch a clang warning
The warning was:
./tcpdump.c:182:5: warning: no previous extern declaration for non-static
variable 'dflag' [-Wmissing-variable-declarations]
2019-03-19 11:01:27 +01:00
Francois-Xavier Le Bail
d6ca6f1111 PPP: Fix two loops for undefined behavior at runtime
The errors were:
print-ppp.c:518:9: runtime error: unsigned integer overflow: 38 - 230
cannot be represented in type 'unsigned int'
print-ppp.c:1138:63: runtime error: unsigned integer overflow: 204 - 220
cannot be represented in type 'unsigned int'

Add a test case.
2019-03-18 23:04:07 +01:00
Francois-Xavier Le Bail
391ad4d31b PPP: Fix inaccurate variable names 2019-03-18 22:19:59 +01:00
Francois-Xavier Le Bail
79e7754fd2 Clean up whitespaces 2019-03-18 22:19:59 +01:00
Francois-Xavier Le Bail
ff10db64d6 NFS: Fix an undefined behavior at runtime
The error was:
print-nfs.c:537:2: runtime error: unsigned integer overflow:
4294967295 + 3 cannot be represented in type 'unsigned int'
print-nfs.c:541:14: runtime error: unsigned integer overflow:
4294967295 + 3 cannot be represented in type 'unsigned int'

Add a test case.
2019-03-17 21:37:01 +01:00
Francois-Xavier Le Bail
6c93708db1 CDP: Fix two loops for undefined behavior at runtime
The errors were:
print-cdp.c:363:13: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'u_int' (aka 'unsigned int')
print-cdp.c:375:13: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'u_int' (aka 'unsigned int')
2019-03-17 15:01:15 +01:00
Francois-Xavier Le Bail
d91fbd46e2 BRCMTAG: Fix some warnings
The warnings were:
no previous extern declaration for non-static variable 'brcm_tag_te_values'
[-Wmissing-variable-declarations]
no previous extern declaration for non-static variable 'brcm_tag_rc_values'
[-Wmissing-variable-declarations]
2019-03-16 17:25:19 +01:00
Loganaden Velvindron
cc2d4cbd8c ICMPv6: Add the IPv6-Only flag
This flag in defined in a draft which is close to getting published as
an IETF RFC: https://tools.ietf.org/html/draft-ietf-6man-ipv6only-flag-05.
2019-03-16 16:03:27 +01:00
Francois-Xavier Le Bail
82b4aa217c SNMP: Fix an undefined behavior at runtime
The error was:
print-snmp.c:503:14: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'uint32_t' (aka 'unsigned int')
2019-03-16 13:08:36 +01:00
Francois-Xavier Le Bail
c63521347c Travis CI: Print the devel libs in Linux builds 2019-03-15 15:49:48 +01:00
Francois-Xavier Le Bail
be3b825acd Travis CI: Fix the problem with folded outputs
Trailing newlines are now needed in travis_fold:start:* strings, because
of a Travis change.
Based on Travis support proposal.
2019-03-15 15:43:43 +01:00
Francois-Xavier Le Bail
a24cccfd4a IPX: Add a length check
This fix an undefined behavior at runtime.

The error was:
print-ipx.c:93:43: runtime error: unsigned integer overflow: 29 - 30
cannot be represented in type 'unsigned int'

Add a test case.
2019-03-11 22:07:06 +01:00
Francois-Xavier Le Bail
2f6c710131 IS-IS: Fix inaccurate variable names 2019-03-10 23:17:58 +01:00
Francois-Xavier Le Bail
d3712a11a5 Add two TFTP tests
There is one pcap file with two outputs, with/without the '-T tftp' option.
2019-03-10 16:17:03 +01:00
Francois-Xavier Le Bail
ce9a0a3817 TFTP: Print protocol name and length keyword
Update the output of a test accordingly.
2019-03-10 16:16:13 +01:00
Francois-Xavier Le Bail
0aca3bf945 Babel: Avoid an unsigned integer underflow 2019-03-09 21:20:40 +01:00
Francois-Xavier Le Bail
e65c17147a SMB: Avoid an unsigned integer underflow 2019-03-09 21:20:04 +01:00
Francois-Xavier Le Bail
59868ef671 RIP: Fix two loops for undefined behavior at runtime
1) RIPv2
The error was:
print-rip.c:386:9: runtime error: unsigned integer overflow: 16 - 20
cannot be represented in type 'unsigned int'

Without this change the unsigned integer variable 'len' is assigned a
very high value, because of underflow, and the loop continue incorrectly.

Add a test case.

2) RIPv1
Same bugfix, based on a code inspection, so comes without a test case.
2019-03-09 15:13:51 +01:00
Francois-Xavier Le Bail
8e41caf1e7 RIP: Fix inaccurate variable names 2019-03-08 15:52:07 +01:00
Francois-Xavier Le Bail
45f96d1da2 Clean up whitespaces/indentation 2019-03-08 15:26:45 +01:00
Francois-Xavier Le Bail
2b4a3e6a63 ICMP: Fix an undefined behavior at runtime
The error was:
print-icmp.c:491:13: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'u_int' (aka 'unsigned int')
2019-03-08 12:48:59 +01:00
Francois-Xavier Le Bail
9be45b2369 Use the ndo->ndo_protocol field instead of the protoname parameter
Moreover:
Fix a truncated string: "[!" is not the prefix for a truncated string.
Add two comments.
Clean up a whitespace.
2019-03-08 10:12:21 +01:00
Francois-Xavier Le Bail
e85072ad1d Fix a typo 2019-03-07 14:31:19 +01:00
Francois-Xavier Le Bail
c97c3571a0 TCP: Fix an undefined behavior at runtime
The error was:
print-tcp.c:831:22: runtime error: unsigned integer overflow: 0 - 1
cannot be represented in type 'u_int' (aka 'unsigned int')
2019-03-06 14:52:14 +01:00
Guy Harris
457a4acb89
Merge pull request #734 from jkcko/master
Support DLT_IEEE802_15_4_TAP.
2019-02-28 09:58:25 -08:00
Francois-Xavier Le Bail
0f9808547c Clean up whitespaces/indentation 2019-02-27 21:24:12 +01:00
Francois-Xavier Le Bail
bcbe2cd035 ISAKMP: Simplify an expression 2019-02-27 20:31:02 +01:00
Francois-Xavier Le Bail
b9ac2f3feb Clean up whitespaces 2019-02-27 20:13:59 +01:00
Francois-Xavier Le Bail
61857ddd22 Add two ndo_protocol reassignments after xxx_print() calls 2019-02-27 12:26:10 +01:00
Francois-Xavier Le Bail
cc734973ea Clean up whitespaces/indentation 2019-02-27 12:12:34 +01:00
Francois-Xavier Le Bail
a67cf88e5d IS-IS: Replace some ND_TTEST_*() calls with ND_TCHECK_*() calls 2019-02-25 17:40:02 +01:00
Francois-Xavier Le Bail
91b0ee0a59 IEEE 802.11: Replace some ND_TTEST_*() calls with ND_TCHECK_*() calls
Moreover:
Use 'goto trunc' in some length tests.
2019-02-24 10:55:12 +01:00
Francois-Xavier Le Bail
6d855c7007 Clean up whitespaces/indentation 2019-02-24 09:44:14 +01:00
Francois-Xavier Le Bail
7ceb3ae2a6 RSVP: Replace a ND_TTEST_*() call with ND_TCHECK_*() call 2019-02-23 22:31:06 +01:00
Francois-Xavier Le Bail
5b8c5e94fe GeoNet: Replace the ND_TTEST_*() calls with ND_TCHECK_*() calls
Moreover:
Add two comments
2019-02-23 19:56:00 +01:00
Francois-Xavier Le Bail
57d187a391 Clean up whitespaces 2019-02-23 19:51:59 +01:00
Francois-Xavier Le Bail
a14faa6873 OLSR: Replace the ND_TTEST_*() calls with ND_TCHECK_*() calls 2019-02-23 19:27:37 +01:00
Francois-Xavier Le Bail
a9c8816ff0 GRE: Replace the ND_TTEST_*() calls with ND_TCHECK_*() calls 2019-02-23 18:05:36 +01:00
Francois-Xavier Le Bail
77fa97a8d7 Clean up whitespaces/indentation 2019-02-23 17:31:48 +01:00
James Ko
5cf83c2fce Handle DLT_IEEE802_15_4_TAP.
https://github.com/jkcko/ieee802.15.4-tap
2019-02-20 09:08:03 -08:00
Francois-Xavier Le Bail
b4101b5314 Add a test for NFS write verifier cookie in TESTLIST
This is a followup to commit 8b9f7d9d76.

Moreover:
Rename the .pcap file to .pcapng.
2019-02-07 12:53:55 +01:00
Francois-Xavier Le Bail
a5211097d0 Remove some useless spaces 2019-02-01 13:59:45 +01:00
Francois-Xavier Le Bail
8102102345 Remove a useless space 2019-01-29 21:39:41 +01:00