ishaangandhi
dbf0433fef
Add dissector for ICMP Interface Identification Object
2021-07-13 19:02:32 +00:00
ishaangandhi
572f2e7cdf
Rename MPLS Extension to Multipart Extension
2021-07-13 19:02:32 +00:00
Michael Richardson
3a3edb296a
Merge pull request #918 from dcaratti/gh189
...
mptcp: add support for MP_TCPRST
2021-07-12 11:27:05 -04:00
Davide Caratti
1ac47641c5
mptcp: add support for MP_TCPRST
...
dissect the MP_TCPRST sub-option in accordance to RFC8684 §3.6.
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/189
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
2021-07-12 10:51:58 +02:00
Guy Harris
5ff873f0d2
Improve the handling of size suffixes for -C.
...
Support upper-case suffixes (K/M/G) as well as lower-case suffixes.
Make sure nothing *follows* the suffix.
We don't need to check for the suffix before parsing the number; the
parsing routines stop if they see a non-digit character.
2021-07-10 14:01:18 -07:00
Guy Harris
a36b3aeb87
Merge pull request #916 from stevekay/master
...
optional unit suffix on -C file size
2021-07-10 13:45:10 -07:00
Francois-Xavier Le Bail
e4adb4b6e1
Rename a test. It's about the AppleTalk protocol
2021-07-10 20:57:07 +02:00
Francois-Xavier Le Bail
24f217998d
CI: Add back running tcpdump -J/-L and capture, now with Cirrus VMs.
...
The Cirrus virtual machines are throwaway.
Revert partially f5739ad4ca
.
2021-07-08 16:25:15 +02:00
Francois-Xavier Le Bail
25f672ea6f
Print the supported time stamp types (-J) to stdout instead of stderr
...
It is not an error, thus print them to stdout.
2021-07-08 12:34:11 +02:00
Francois-Xavier Le Bail
3f7d71ef1e
Factorize some code
2021-07-08 11:55:21 +02:00
Francois-Xavier Le Bail
e55b187600
Print the list of data link types (-L) to stdout instead of stderr
...
It is not an error, thus print it to stdout.
2021-07-07 19:19:37 +02:00
Guy Harris
36fded6013
802.11: make the length in the IE structures a u_int.
...
This avoids narrowing warnings.
Clean up PRINT_RATE() a bit while we're at it (avoiding signed vs.
unsigned comparison warnings).
2021-07-06 13:32:38 -07:00
Guy Harris
33b6502c99
802.11: no need for an element ID in the structures for IEs.
...
Remove the element_id member, and, instead of copying over the entire IE
header, just set the length to the value we've already fetched.
2021-07-06 13:27:19 -07:00
Denis Ovsienko
f5739ad4ca
CI: Get Travis CI vestige sorted in build.sh.
...
Compiling user-provided source code and running the resulting binary
with sudo was a security problem, thus instead of fixing two no-op
blocks remove them altogether. If anyone later needs to debug features
that require higher privileges, they will need to come up with a better
solution. Simplify the debug output test condition and rephrase the
associated comment for clarity.
2021-07-05 19:47:29 +01:00
Denis Ovsienko
d56f061500
CI: List shared libraries on more OSes.
...
Running ldd on Linux only originates from the Travis CI setup, where the
OS was either Linux or macOS. However, ldd is available in BSD systems
too, and macOS seems to have its own tool for the same job.
2021-07-05 19:47:25 +01:00
Denis Ovsienko
779ff621bc
Address all shellcheck warnings in update-test.sh.
2021-07-05 14:28:34 +01:00
Denis Ovsienko
35a8fc576d
CI: Lose the output folding props.
...
Same as in libpcap.
2021-07-05 12:09:59 +01:00
Denis Ovsienko
63ea6b5d47
CI: Switch from bash to POSIX shell.
...
Same as in libpcap.
2021-07-05 11:59:03 +01:00
Denis Ovsienko
59ddbc3fd4
CI: Simplify some Coverity Scan props.
...
Same as in libpcap.
2021-07-05 11:32:03 +01:00
Francois-Xavier Le Bail
4762c8094d
AppVeyor: Update Npcap SDK to 1.10
2021-07-04 09:40:42 +02:00
Gokul Sivakumar
ff5484806e
Fix the misleading comment regarding "From DS", "To DS" Frame Control Flags
...
In the case where the "From DS" bit is not set and the "To DS" bit is set
in the Frame Control Bitmask, the comment line in the corresponding if else
block was misleading that the "From DS" bit is set and the "To DS" bit is
not set.
2021-06-27 19:00:00 +00:00
Francois-Xavier Le Bail
880b867ee7
Juniper: Add some bounds checks
...
Avoid to have p (current pointer on packet data) > ndo->ndo_snapend
in isoclns_print() in some cases.
Define ND_LONGJMP_FROM_TCHECK.
Remove some trunc labels.
2021-06-23 07:57:44 +02:00
Francois-Xavier Le Bail
4cb597de19
CHANGES: Set the date for the 4.99.1 release
2021-06-10 18:16:00 +02:00
Francois-Xavier Le Bail
f91ef58f2f
autoconf: Find a local libpcap even with rcX directory suffix
2021-06-07 21:01:15 +02:00
Francois-Xavier Le Bail
7eb602af59
AppVeyor: Update Npcap SDK to 1.07
2021-06-03 16:04:58 +00:00
Francois-Xavier Le Bail
c39eb09479
Use quoted include netdissect-stdinc.h instead of angle-bracketed one
...
Same as other printers.
2021-06-02 11:24:24 +02:00
Francois-Xavier Le Bail
657d672cb6
Makefile.in: Add the shellcheck target
...
Run shellcheck on the build.sh and the build_matrix.sh scripts.
(using 'gcc' format: GCC compatible output. See the shellcheck man page)
[skip ci]
2021-06-01 10:14:00 +02:00
Francois-Xavier Le Bail
815919247b
build_matrix.sh: Fix a shellcheck warning
...
The warning was:
Use "${var:?}" to ensure this never expands to /* . [SC2115]
2021-05-31 15:04:09 +02:00
Francois-Xavier Le Bail
5abf27529d
build.sh: Disable a shellcheck error
...
We need the $@ expansion.
The error was:
Double quote array expansions to avoid re-splitting elements. [SC2068]
2021-05-31 15:01:44 +02:00
Guy Harris
c7e9212a01
Merge Readme.Win32 into doc/README.Win32.md. [skip ci]
...
We should only have one "how to build on Windows" file.
2021-05-31 04:47:47 -07:00
Francois-Xavier Le Bail
4356f99512
Makefile.in: Add the build for release candidates
...
It adds rcX suffix to the version.
This avoid to manually update 'VERSION' and 'configure'.
Same as for libpcap.
2021-05-30 10:47:22 +02:00
Francois-Xavier Le Bail
f9f128373b
Update config.{guess,sub}, timestamps 2021-01-25,2021-03-10
...
From repository git://git.savannah.gnu.org/config.git
2021-05-27 17:26:38 +02:00
Francois-Xavier Le Bail
c0335764f4
BGP: Use a macro for repeated identical sizeof()
...
[skip ci]
2021-05-26 11:13:53 +02:00
Guy Harris
df2dc59f6c
Frame Relay: make the buffer big enough for the biggest message.
2021-05-25 23:25:41 -07:00
Guy Harris
bf8bf8de48
CHANGES: list the most recent change. [skip ci]
2021-05-25 22:28:09 -07:00
Guy Harris
51bc4bffb8
Frame Relay: have q922_string() handle errors better.
...
Have it return a string indicating an error, rather than a null string.
2021-05-25 22:26:48 -07:00
Guy Harris
ec3195c373
CHANGES: update with additional changes in the 4.99 branch. [skip ci]
...
Move some from the 5.0 list to the 4.99 list.
2021-05-25 17:53:34 -07:00
Guy Harris
e72a7ba0a2
ARP: fix overwrites of static buffer in q922_string().
...
Don't call GET_LINKADDR_STRING() twice in a given ND_PRINT() call.
Should address another problem in GitHub issue #919 .
2021-05-25 15:22:49 -07:00
Francois-Xavier Le Bail
cf6c3fb2ad
BGP: Fix overwrites of global 'astostr' temporary buffer
...
Remove the global 'astostr'.
Use a local 'astostr' in the functions that use it.
This should fix GitHub issue #919 .
Moreover:
Rename 'asbuf' to 'astostr'.
2021-05-25 18:34:15 +02:00
Francois-Xavier Le Bail
59d3227197
Fix a typo
...
[skip ci]
2021-05-22 14:16:17 +02:00
Francois-Xavier Le Bail
1609b127e2
netdissect.h: Keep the printers declarations names sorted
...
Moreover:
Declare macsec_print() on one line.
Remove an extra space.
[skip ci]
2021-05-22 14:01:57 +02:00
Francois-Xavier Le Bail
29973d83e8
Zephyr: Update 'length' type to unsigned
...
It is unsigned in the calling function udp_print().
2021-05-22 09:45:44 +02:00
Matthew Martin
ad090fd01a
DNS: Sync types with IANA
...
IANA reference:
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml
Remove the UNSPECA type parsing as IANA has that query type number
assigned to NID now.
2021-05-18 17:09:42 +00:00
Francois-Xavier Le Bail
af39d2298f
sFlow: Add some spaces (style)
...
[skip ci]
2021-05-17 18:21:35 +02:00
Neelabh
7b4e6191a7
Add support for IPv6 agent in sFlow.
2021-05-17 14:52:12 +00:00
Francois-Xavier Le Bail
d76dc9f90a
IEEE 802.15.4: Add a bounds check
...
This avoids to have cp (current pointer on packet data) > ndo->ndo_snapend
in hex_and_ascii_print(), via ndo_default_print(), via ND_DEFAULTPRINT(),
in some cases.
2021-05-14 20:34:43 +02:00
Francois-Xavier Le Bail
346ea98e51
IEEE 802.15.4: Add some bounds checks
...
This avoids to have cp (current pointer on packet data) > ndo->ndo_snapend
in hex_and_ascii_print(), via ndo_default_print(), via ND_DEFAULTPRINT(),
in some cases.
2021-05-12 08:54:58 +02:00
Denis Ovsienko
f8491f77ac
Recommend using the upstream CI in CONTRIBUTING. [skip ci]
...
CI configuration is a running target, and much of it works on Buildbot,
in which pull requests are the only practicable option for 3rd parties.
2021-05-11 23:41:31 +01:00
Francois-Xavier Le Bail
6f245276a2
ZEP: Add a bounds check
...
This avoids to have cp (current pointer on packet data) > ndo->ndo_snapend
in hex_and_ascii_print(), via ndo_default_print(), via ND_DEFAULTPRINT(),
in some cases.
2021-05-09 19:58:34 +02:00
Steve Kay
81e2588d2b
optional unit suffix on -C
2021-05-08 14:32:24 -04:00