Commit Graph

2765 Commits

Author SHA1 Message Date
Guy Harris
29c908c198 Fix typo, so setting CPPFLAGS in the environment works correctly.
Based-On-Patch-From: Simon Ruderich <simon@ruderich.org>
2012-03-03 13:36:17 -08:00
Guy Harris
e2b98d2cc6 Ask for more information if we don't find pcap_loop.
I give up.

People keep reporting that the configure process for tcpdump fails to
find pcap_loop, and the config.log file they send us says there's no
pcap_parse in libpcap, which suggests that something went wrong in the
build process for libpcap; perhaps they don't have Bison and the
configure script got confused and failed to cause the parser to be named
"pcap_parse", or something such as that, or perhaps Bison was recently
"improved" in a fashion that breaks that, but I've never been able to
reproduce this on any of the Linux distribution installations to which
*I* have access.

I therefore ask them to send the config.log output and make output for
libpcap; *not one of the reporters of this problem* has bothered to send
that information, so we're stuck.  Perhaps they don't care enough (in
which case, why did they bother asking us about it?), or perhaps they're
annoyed that we asked them a further question rather than Just Fixing
The Problem(TM) (in which case, all I have to say is "welcome to the
Wonderful World Of Computer Software(TM) - get used to it").

So let's just ask for all that information.  (I would not be surprised
if this doesn't suffice and that they *still* just send us the tcpdump
config.log output, but at least I'll be able to tell them that they
should have Read The Fine Error Message(TM).)
2012-03-03 13:32:11 -08:00
Guy Harris
7e4eb0a86c Fix printing of BGP optional headers.
Anonymously contributed patch; tested with Cisco and Arista routers by
the patch contributor.
2012-03-02 17:30:32 -08:00
Guy Harris
2886b89df6 Back out DLT_PFSYNC support.
Unfortunately, the DLT_PFSYNC support depends on header files included
from the pfctl command's source tree, and trying to arrange to find that
would be too much trouble.
2012-02-29 21:14:50 -08:00
Guy Harris
0d2d222ffb Add DLT_PFSYNC support.
From FreeBSD PR bin/124825: tcpdump(8) does not support pfsync(4) data,
which in turn was ported over from OpenBSD.  We already have CARP
support, so we did not port that part over.
2012-02-29 01:51:27 -08:00
Guy Harris
54825f266a Put the addresses early in the message format, and handle short messages.
Putting the addresses after "TIPC vX.Y" matches other protocols, such as
IPv4/IPv6.

Not all messages have full headers.

Also, constify some parameters and variables.
2012-02-29 01:09:40 -08:00
Guy Harris
9918c89832 Print only one line in non-verbose mode.
Also, don't print extra blank lines in verbose mode.
2012-02-28 21:12:26 -08:00
ABHIMANYU
2c233065b6 TIPC support.
Reviewed-and-much-modified-by: Guy Harris <guy@alum.mit.edu>
2012-02-28 20:36:55 -08:00
Guy Harris
93f33e57f5 Print a space after the options if there are any options. 2012-02-28 15:45:48 -08:00
Matthew Luckie
329023dbb2 Get rid of extra blank after unknown options.
Reviewed-By: Guy Harris <guy@alum.mit.edu>
2012-02-28 15:41:12 -08:00
Dagobert Michelsen
5d61759b24 Use expr instead of bashisms.
Reviewed-By: Guy Harris <guy@alum.mit.edu>
2012-02-28 15:31:38 -08:00
Michael Richardson
d02caa897a Merge remote branch 'github/master' 2012-02-23 20:15:15 -05:00
Michael Richardson
424d115b8b Merge pull request #7 from clifffrey/fix-lldp-network-policy
Fix LLDP Network Policy bit definitions.
2012-02-23 17:14:29 -08:00
Michael Richardson
aa7d6575c6 Merge pull request #6 from fenner/master
IGMPv3 Max Response Time is in units of 0.1 second.
2012-02-23 17:13:35 -08:00
Michael Richardson
dbe12c41ed Merge pull request #5 from kmaehashi/feature-SIGUSR1
Use SIGUSR1 to request info when SIGINFO is not defined
2012-02-23 17:12:26 -08:00
Michael Richardson
a50985b582 added test packet for icmpv6 advertisement interval fix 2012-02-23 20:11:32 -05:00
Cliff Frey
a71e402b5c Fix LLDP Network Policy bit definitions. 2012-02-23 11:19:48 -08:00
Bill Fenner
576da09dbc Previous commit accidentally used 6 seconds cutoff.
60 seconds == 600 in units of 0.1, oops.
2012-02-13 08:32:14 -08:00
Bill Fenner
da7a3c3c84 IGMPv3's Max Response Time is in units of 0.1 second.
If it's less than 60 seconds, print it as %.1fs, to be able to
accurately represent small values including the tenths-of-a-second.
Only use relts_print() when it is 60 seconds or more.
2012-02-13 08:27:08 -08:00
Kenichi Maehashi
4442071079 tcpdump now accepts SIGUSR1 as a signal to print the statistics on systems that does not support SIGINFO 2012-02-07 22:16:19 +09:00
Michael Richardson
8b82b3557c Merge remote branch 'github/master' 2012-01-23 14:10:51 -05:00
Michael Richardson
57b20fbcc9 Merge branch 'master' of git+ssh://bpf.tcpdump.org/tcpdump/master/git/tcpdump 2012-01-23 14:10:40 -05:00
Michael Richardson
1118847da5 permit -n flag to affect print-ip for protocol numbers 2012-01-23 14:10:16 -05:00
Michael Richardson
a4a13734bb Merge pull request #4 from infrastation/master
ND_OPT_ADVINTERVAL is in milliseconds, not seconds
2012-01-23 11:02:41 -08:00
Denis Ovsienko
91045106fb ND_OPT_ADVINTERVAL is in milliseconds, not seconds
RFC 6275 7.3. New Advertisement Interval Option Format

   Advertisement Interval

      32-bit unsigned integer.  The maximum time, in milliseconds,
      between successive unsolicited Router Advertisement messages sent
      by this router on this network interface.
2011-12-29 20:46:02 +04:00
Guy Harris
f062d715cd Note the length checks in the Babel printer. 2011-12-18 16:06:05 -08:00
Guy Harris
938becee00 Add length checks, use EXTRACT_16BITS().
Use EXTRACT_16BITS() rather than a hand-rolled macro to extract
big-endian 16-bit quantities from the packet.

When processing the message, check against the body length *and* the UDP
payload length, as well as against the raw frame length.
2011-12-18 16:05:05 -08:00
Guy Harris
a52a62784f Add the new PPPoE test files. 2011-12-17 11:41:33 -08:00
Guy Harris
4b285eac06 Merge branch 'master' of git+ssh://bpf.tcpdump.org/tcpdump/master/git/tcpdump 2011-12-17 11:38:33 -08:00
Michael Richardson
ac2a34f19c Merge pull request #3 from bodgit/master
Test case for PPPoE & RFC 4638 Payload Tag
2011-12-12 05:44:40 -08:00
Matt Dainty
d57e91f0fd Add simple PPPoE test case 2011-12-11 01:57:56 +00:00
Guy Harris
309ca62193 Add changes in 4.2.1. 2011-12-09 17:31:40 -08:00
Michael Richardson
104160e0b5 Merge remote branch 'github/master' 2011-12-09 20:04:11 -05:00
Michael Richardson
13028060e2 Merge pull request #2 from bodgit/master
Teach PPPoE parser about RFC 4638
2011-12-09 17:01:15 -08:00
Matt Dainty
ebdb1b1d30 Teach PPPoE parser about RFC 4638 2011-12-09 20:46:27 +00:00
Guy Harris
dde70ef8a6 Fix a typo (from the Red Hat tcpdump package) and use .LP. 2011-12-09 01:35:55 -08:00
Guy Harris
d6bb95e4f0 Get rid of an unused variable. 2011-12-08 23:06:00 -08:00
Sascha Wildner
684955d586 Fix a bunch of "sizeof(sizeof(XXX))".
In some places, there was one too many levels of sizeof() -
sizeof(sizeof(XXX)) is sizeof(size_t), but we wanted the size of type
XXX.

Reviewed-By: Guy Harris <guy@alum.mit.edu>
2011-12-07 10:42:12 -08:00
George Neville-Neil
5d52dbf4c7 Add a CARP dissector and a command-line option to dissect proto 112 as CARP.
CARP and VRRP both use IP protocol number 112, so there needs to be a -T
flag to specify that protocol 112 be dissected as CARP rather than VRRP.

Also update the man page.
2011-11-23 11:53:13 -08:00
Guy Harris
36b75f7121 Redo length checks in ospf6_print_lsa().
Check to make sure we haven't run past the end of the LSA by doing
length checks - and be a bit fussier about length checks.  Do more
end-of-packet checks as well.
2011-10-13 21:59:57 -07:00
Guy Harris
8b19304818 Constify some arguments. 2011-10-13 21:49:18 -07:00
Michal Sekletar
e26785e530 Put in missing break.
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2011-10-13 20:13:03 -07:00
Michal Sekletar
8dfb278a95 Remove unnecessary test.
Also, from me: add a comment explaining why the test isn't being done.

Reviewed-by: Guy Harris <guy@alum.mit.edu>
2011-10-13 20:10:11 -07:00
Guy Harris
f944e1e39d Clean up option-walking code.
Loop as long as the remaining option list length is not zero, even if
that means we try to process the remaining options if the remaining
length is 1, so that if the option length is bogus, we'll report it.

Check for a valid ESIS_OPTION_ES_CONF_TIME length - it's supposed to be
2.
2011-10-13 20:03:29 -07:00
zilog80a
026147c336 Fix test output - IP protocol 72 is in /etc/services on at least some UN*Xes.
Reviewed-By: Guy Harris <guy@alum.mit.edu>
2011-10-13 19:44:07 -07:00
Guy Harris
e40ffdfca7 Change name of Hilscher link types to say NETANALYER.
That makes the names a bit shorter, and mentions the specific Hilscher
product to which they apply.
2011-09-15 17:39:56 -07:00
Guy Harris
9c7d7c8a5c Add printers for the Hilscher Ethernet link-layer types. 2011-09-15 12:56:17 -07:00
Michael Richardson
8b6ba58727 Merge pull request #1 from jhsmt/master
restore some test cases for forces
2011-09-13 07:18:40 -07:00
Guy Harris
9daf436721 Handle systems with getrpcbynumber() but no header file for it.
Glibc 2.14 doesn't install the ONC RPC headers, but it installs the ONC
RPC routines, presumably for binary compatibility.  Don't use
getrpcbynumber() unless we have it *and* the header file to declare it.
2011-09-02 21:31:09 -07:00
Michael Richardson
894e8113f0 Merge branch 'master' of git+ssh://bpf.tcpdump.org/tcpdump/master/git/tcpdump
Conflicts:
	Makefile.in
2011-08-27 16:56:50 -04:00