Commit Graph

5228 Commits

Author SHA1 Message Date
Francois-Xavier Le Bail
23be4d1240 Remove two duplicate lines 2018-05-02 04:22:10 +02:00
Francois-Xavier Le Bail
0cced4fcdc Remove the safeputchar() function
Print the characters filtering out non-printable with fn_print_char().

Update the output of some tests accordingly.
2018-05-02 03:33:02 +02:00
Guy Harris
84faadecc0 Display the "wireless" flag and connection status. 2018-04-30 12:44:58 -07:00
Francois-Xavier Le Bail
378568f2a6 Fix some host-endian extract routines
The modified routines are not currently used.
2018-04-30 17:07:36 +02:00
Francois-Xavier Le Bail
255339b508 Don't use safeputchar() if unneeded 2018-04-30 14:03:17 +02:00
Francois-Xavier Le Bail
3e3e6d2ef4 Rename the fn_printX() functions to nd_printX()
The functions are: nd_print, nd_printztn, nd_printn and nd_printzp.
Trying to make it clearer that they currently have to be used only on part
of the packet buffer.
Update some comments.
2018-04-30 13:35:06 +02:00
Guy Harris
f7530ee4d5
Merge pull request #671 from eric-s-raymond/master
Fix a broken font escape in the manual page.
2018-04-15 10:52:52 -07:00
Eric S. Raymond
2edef3459f Fix a broken font escape in the manual page. 2018-04-15 13:40:25 -04:00
Guy Harris
ee29ee496c Some additional cleanups.
Use define(XXX) to check for signal codes being defined.

Make the signal handlers for SIGINFO/SIGUSR1 and SIGUSR2 static.
2018-04-08 17:31:22 -07:00
Guy Harris
87b129ad3a Use "pdd" rather than "p" for pcap_dumper_t *'s.
That squelches some "declaration shadows" warnings.

Clean up indentation while we're at it.
2018-04-08 17:29:41 -07:00
Guy Harris
fa8c4d8115
Merge pull request #670 from GuyLewin/master
SIGUSR2 flushes the packet buffer
2018-04-08 17:21:05 -07:00
Guy Lewin
0e79762874 Separate flushing the packet buffer from SIGINFO to SIGUSR2 2018-04-08 01:46:53 +03:00
Guy Lewin
ff30ebc542 When SIGINFO (or SIGUSR1) signal sent, also flush the buffer. Useful when you want to download the dump file and want to have all of the packets. 2018-04-08 01:04:58 +03:00
Guy Harris
869239c73b Don't define tstr[] if we won't be using it. 2018-04-04 13:20:23 -07:00
Guy Harris
10ec34dbf0 Don't define tstr[] if we won't be using it. 2018-04-04 13:19:18 -07:00
Guy Harris
1980b017c1 Don't define immediate_mode if we won't be using it. 2018-04-04 13:15:23 -07:00
Guy Harris
8b1d184e10
Merge pull request #667 from slavashw/master
Fix fail to capture on RDMA device on FreeBSD
2018-04-02 19:42:01 -07:00
Guy Harris
7e8de895e4 Allow index numbers in remote capture. 2018-04-01 02:17:42 -07:00
Guy Harris
32776c3bf6 Get rid of debugging printout. 2018-03-31 19:24:17 -07:00
Guy Harris
9373df8aa3 Don't set COMPILE_FLAGS if there aren't any flags to set.
Otherwise, you get a complaint about there being too few arguments to
set_target_properties().
2018-03-27 14:38:29 -07:00
Guy Harris
2846055e96 Add -W options. 2018-03-27 14:18:14 -07:00
Guy Harris
af51efcd6a The COMPILE_FLAGS property is a string, not a list.
Make C_ADDITIONAL_FLAGS a string as well, and use it appropriately.
2018-03-27 14:11:25 -07:00
Guy Harris
092ae6ddf7 Add C_ADDITIONAL_FLAGS to the compiler flags for targets. 2018-03-27 13:34:09 -07:00
Guy Harris
32f8ededb0 Initialize C_ADDITIONAL_FLAGS where we start setting it. 2018-03-27 13:16:17 -07:00
Guy Harris
111e17e87d Don't use CMAKE_C_STANDARD, it doesn't work on all versions of CMake.
It doesn't work at all prior to CMake 3.1 and, even in newer versions of
CMake, it doesn't support all the vendor compilers out there for various
UNIXes.
2018-03-27 13:13:30 -07:00
Slava Shwartsman
3e26499353 Fix fail to capture on RDMA device on FreeBSD
In pcap for RDMA devices, on FreeBSD where we have support for capsicum
but we don't have file descriptor for a live capture we will fail with:
"tcpdump: unable to limit pcap descriptor"
We just fail to set the proper access rights - don't fail the capture.

Signed-off-by: Slava Shwartsman <slavash@mellanox.com>

Fix fail to capture on RDMA device on FreeBSD

In pcap for RDMA devices, on FreeBSD where we have support for capsicum
but we don't have file descriptor for a live capture we will fail with:
"tcpdump: unable to limit pcap descriptor"
We just fail to set the proper access rights - don't fail the capture.

Signed-off-by: Slava Shwartsman <slavash@mellanox.com>
2018-03-22 09:38:02 +00:00
Guy Harris
28b4ea1f34 Return caplen for too-short packets.
That way, if we don't have a full PKTAP header, we don't print anything
in the -x/-X hex dump or -A ASCII dump (but do print it with
-xx/-XX/-AA).
2018-03-19 11:40:42 -07:00
Francois-Xavier Le Bail
56e6581c34 Remove useless comments 2018-03-19 15:16:32 +01:00
Francois-Xavier Le Bail
546558eabd Add the ndo_protocol field in the netdissect_options structure
Update this field in printer entry functions.
It will be used for some printings.
2018-03-16 19:44:47 +01:00
Francois-Xavier Le Bail
61f71d2046 IEEE 802.15.4: Refactor with two functions 2018-03-16 16:55:30 +01:00
Francois-Xavier Le Bail
89649d6e81 Move some smb prototypes in smb.h
Moreover:
Add a const qualifier
2018-03-16 11:20:51 +01:00
Francois-Xavier Le Bail
ba857360fc Add some const qualifiers 2018-03-16 10:39:25 +01:00
Francois-Xavier Le Bail
75397ef8d5 Fix naming
For coherency.
We have: DLT_IEEE802_11_RADIO_AVS and ieee802_11_radio_avs_if_print().
Thus rename ieee802_11_avs_radio_print() to ieee802_11_radio_avs_print().
2018-03-14 18:37:09 +01:00
Francois-Xavier Le Bail
a53605c61b Add a malloc/free process with garbage collector
Use it in the PPP printer.
2018-03-14 13:59:26 +01:00
Francois-Xavier Le Bail
fa196ecfbe Add a comment on a memory allocation we cannot free 2018-03-12 15:44:10 +01:00
Francois-Xavier Le Bail
2b56cf0923 Rx: Use ndo_error() when malloc() fails as in most similar cases 2018-03-11 16:01:19 +01:00
Francois-Xavier Le Bail
5eb4ffa131 Fix a typo 2018-03-10 14:49:07 +01:00
Francois-Xavier Le Bail
e830e4a34c Fix a typo 2018-03-10 13:42:33 +01:00
Francois-Xavier Le Bail
aeeb8cb733 Travis CI: Remove unused variable ENABLE_REMOTE 2018-03-09 21:31:54 +01:00
Francois-Xavier Le Bail
1290a0a5cc Remove a trailing space 2018-03-09 20:57:55 +01:00
Francois-Xavier Le Bail
1d7b43bd7e Remove the etherproto_string() unused function 2018-03-09 20:49:53 +01:00
Guy Harris
800d27dd0d Add "make check".
This assumes you can run tests/TESTrun.sh as a script, which means it
assumes your command interpreter will either recognize it as a shell
script and run it in a Bourne-compatible shell or will just try and
execute it and the #! header will cause it to be run by /bin/sh.

This probably won't work on Windows.
2018-03-05 19:11:09 -08:00
Guy Harris
e35d850fa5 Mention AppVeyor, and give some more information about Travis CI. 2018-03-05 16:31:52 -08:00
Francois-Xavier Le Bail
18905f7312 BGP: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 17:07:39 +01:00
Francois-Xavier Le Bail
57534b8c0a Ethernet: Rename a variable
From 'ep', often used as 'pointer to the end of current packet' to 'ehp'
as Ethernet header pointer.
2018-03-01 16:54:30 +01:00
Francois-Xavier Le Bail
5d938abef2 AoE: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 16:40:13 +01:00
Francois-Xavier Le Bail
19b51ded2e AHCP: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 16:40:09 +01:00
Francois-Xavier Le Bail
bdd97f5422 Loopback: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 16:40:04 +01:00
Francois-Xavier Le Bail
f86fd5a674 UDP: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 16:39:59 +01:00
Francois-Xavier Le Bail
ad69daa2e4 OpenFlow: Fix the uses of the pointer to the end of current packet
Must be based on packet header caplen.
2018-03-01 16:39:38 +01:00