The file could be compiled on demand using "make snprintf.o", although
with many warnings, but tcpdump build would never use the file
regardless of the variety of the build.
Some of the code there has been commented out since commit 45aef49 in
2001, and the rest became unused after commit 1ed63b5 in 2019.
It's specified by the C90 standard (and, as I remember, by the C89
standard, although I no longer have my paper copy); no need to worry
about ancient environments that lack it, and we have some cases where we
call it in code not protected by #ifdef HAVE_STRFTIME/#endif and haven't
seen any reports of problems.
Remove a copyright boilerplate that stood for IPv6 macros added via
commit c9d84d1 in 1999 and removed via commit 11f73ad in 2015. Remove
AC_LBL_SSLEAY, which is unused and obsolete. This change does not
result in any changes in any other files.
AC_LBL_FIXINCLUDES, AC_LBL_UNION_WAIT and AC_LBL_HAVE_RUN_PATH have no
purpose in this source tree. AC_LBL_SHLIBS_INIT does not exist. This
change does not introduce meaningful changes in any other files.
This change should fix the following Coverity Scan issues:
CID 1397795 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_pointer: Assigning value from tlv_tptr + 4UL to tlv_tptr here,
but that stored value is overwritten before it can be used.
CID 1397796 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value from tlv_tlen - 4UL to tlv_tlen here,
but that stored value is overwritten before it can be used.
As Guy Harris points out in bug report GH #1022, the function has been a
busy no-op since commit e6c39e6 in 2010. While at it, fixup the Python
code to work on Python 3:
for i in range(len(crc_table)/8):
TypeError: 'float' object cannot be interpreted as an integer
We use gethostbyaddr() to translate IP addresses in packets to names; we
don't use gethostbyname() to translate names to IP addresses (libpcap
does the latter when compiling filters, so we leave that up to it, and
nothing's left for us to do).
This probably has the same effect as checking for gethostbyname(), but
it makes it a bit clearer why we'd check for it.
List user-visible changes that have been made but did not appear in the
change log. Remove entries that are duplicate (including EIGRP from
4.99.1) or have been superseded by later changes (make releasetar).
