mirrors/tcpdump
0
0
Fork 0
mirror of https://github.com/the-tcpdump-group/tcpdump.git synced 2024-11-24 02:23:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

OSPF: Do more bounds checking

Browse Source
This commit is contained in:
Francois-Xavier Le Bail 2016-07-04 21:28:22 +02:00
parent 58aeb476df
commit d739da09bc
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
print-ospf.c
View File

@ -575,7 +575,7 @@ static const struct tok ospf_topology_values[] = {
/*
* Print all the per-topology metrics.
*/
static void
static int
ospf_print_tos_metrics(netdissect_options *ndo,
const union un_tos *tos)
{
@ -588,7 +588,8 @@ ospf_print_tos_metrics(netdissect_options *ndo,
/*
* All but the first metric contain a valid topology id.
*/
while (toscount) {
while (toscount > 0) {
ND_TCHECK(*tos);
ND_PRINT((ndo, "\n\t\ttopology %s (%u), metric %u",
tok2str(ospf_topology_values, "Unknown",
metric_count ? tos->metrics.tos_type : 0),
@ -598,6 +599,9 @@ ospf_print_tos_metrics(netdissect_options *ndo,
tos++;
toscount--;
}
return 0;
trunc:
return 1;
}
/*
@ -671,7 +675,8 @@ ospf_print_lsa(netdissect_options *ndo,
return (ls_end);
}
ospf_print_tos_metrics(ndo, &rlp->un_tos);
if (ospf_print_tos_metrics(ndo, &rlp->un_tos))
goto trunc;
rlp = (const struct rlalink *)((const u_char *)(rlp + 1) +
((rlp->un_tos.link.link_tos_count) * sizeof(union un_tos)));