mirrors/tcpdump
0
0
Fork 0
mirror of https://github.com/the-tcpdump-group/tcpdump.git synced 2024-11-23 18:14:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

ISAKMP: Use GET_U_1() to replace a direct dereference

Browse Source 
Moreover:
Remove an unnecessary cast and an & operator.
This commit is contained in:
Francois-Xavier Le Bail 2022-02-18 23:32:10 +01:00
parent aca1847899
commit 2800b89683
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
print-isakmp.c
View File

@ -741,10 +741,10 @@ static const char *etypestr[] = {
? npfunc[(x)] : NULL)
static int
iszero(const u_char *p, size_t l)
iszero(netdissect_options *ndo, const u_char *p, size_t l)
{
while (l != 0) {
if (*p)
if (GET_U_1(p))
return 0;
p++;
l--;
@ -2841,7 +2841,7 @@ ikev1_print(netdissect_options *ndo,
i = cookie_find(&base->i_ck);
if (i < 0) {
if (iszero((const u_char *)&base->r_ck, sizeof(base->r_ck))) {
if (iszero(ndo, base->r_ck, sizeof(base->r_ck))) {
/* the first packet */
ND_PRINT(" I");
if (bp2)