mirrors/shadow
0
0
Fork 0
mirror of https://github.com/shadow-maint/shadow.git synced 2024-12-18 14:23:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

usermod: fix off-by-one issues

Browse Source 
Allocate enough memory for the strings, two slashes and the NUL
terminator.

Reported-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Christian Göttsche 2023-03-02 16:18:45 +01:00 committed by Serge Hallyn
parent 170d24a251
commit 7a2b302e68
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/usermod.c
View File

@ -2048,7 +2048,7 @@ static void move_mailbox (void)
if (NULL == maildir) { if (NULL == maildir) {
return; return;
} }
len = strlen (prefix) + strlen (maildir) + strlen (user_name) + 2; len = strlen (prefix) + strlen (maildir) + strlen (user_name) + 3;
mailfile = ALLOCARRAY (len, char); mailfile = ALLOCARRAY (len, char);
/* /*
@ -2103,7 +2103,7 @@ static void move_mailbox (void)
(void) close (fd); (void) close (fd);
if (lflg) { if (lflg) {
len = strlen (prefix) + strlen (maildir) + strlen (user_newname) + 2; len = strlen (prefix) + strlen (maildir) + strlen (user_newname) + 3;
newmailfile = ALLOCARRAY(len, char); newmailfile = ALLOCARRAY(len, char);
if (prefix[0]) { if (prefix[0]) {
(void) snprintf (newmailfile, len, "%s/%s/%s", (void) snprintf (newmailfile, len, "%s/%s/%s",